Skip to contentSkip to conversation

mx25pdk: Adapt it for the new PMIC framework

PATCH New Fabio Estevam 3 participants 4 messages Dec 11, 2012

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx25pdk: Adapt it for the new PMIC framework

Make the necessary adaptions for the new PMIC framework, so that mx25pdk can be built again.

Signed-off-by Fabio Estevam <[email protected]>

---
Stefano,

Build tested only, as I did not manage to get access to a mx25pdk.

 board/freescale/mx25pdk/mx25pdk.c |   13 ++++++++++---
 include/configs/mx25pdk.h         |    6 +++---
 2 files changed, 13 insertions(+), 6 deletions(-)
board/freescale/mx25pdk/mx25pdk.c +10 -3
index 72fa6bc..d73e27e 100644
@@ -27,7 +27,7 @@
 #include <mmc.h>
 #include <fsl_esdhc.h>
 #include <i2c.h>
-#include <pmic.h>
+#include <power/pmic.h>
 #include <fsl_pmic.h>
 #include <mc34704.h>
 

@@ -110,11 +110,18 @@ int board_init(void)
 int board_late_init(void)
 {
 	struct pmic *p;
+	int ret;
 
 	mx25pdk_fec_init();
 
-	pmic_init();
-	p = get_pmic();
+	ret = pmic_init(I2C_PMIC);
+	if (ret)
+		return ret;
+
+	p = pmic_get("FSL_PMIC");
+	if (!p)
+		return -ENODEV;
+
 	/* Turn on Ethernet PHY supply */
 	pmic_reg_write(p, MC34704_GENERAL2_REG, ONOFFE);
include/configs/mx25pdk.h +3 -3
index b5338a0..bbb3161 100644
@@ -108,9 +108,9 @@
 #define CONFIG_SYS_FSL_ESDHC_NUM	1
 
 /* PMIC Configs */
-#define CONFIG_PMIC
-#define CONFIG_PMIC_I2C
-#define CONFIG_PMIC_FSL
+#define CONFIG_POWER
+#define CONFIG_POWER_I2C
+#define CONFIG_POWER_FSL
 #define CONFIG_PMIC_FSL_MC34704
 #define CONFIG_SYS_FSL_PMIC_I2C_ADDR	0x54
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 mx25pdk: Adapt it for the new PMIC framework

Quoted 8 lines · Fabio Estevam

Make the necessary adaptions for the new PMIC framework, so that mx25pdk can be built again.

Signed-off-by Fabio Estevam <[email protected]>

---
Stefano,

Build tested only, as I did not manage to get access to a mx25pdk.

Ok - I will merge it soon into u-boot-imx. If we will find some issues later, we will fix on the top of it.

Acked-by Stefano Babic <[email protected]>

Regards,
Stefano

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 mx25pdk: Adapt it for the new PMIC framework

Quoted 2 lines · Stefano Babic

Ok - I will merge it soon into u-boot-imx. If we will find some issues later, we will fix on the top of it.

Good, I have managed to get a mx25pdk and I can confirm that with this patch the FEC (which depends on a supply being turned on by the PMIC) is functional.

Regards,

Fabio Estevam

#3 lore raw

PATCH 1/1 mx25pdk: Adapt it for the new PMIC framework

In reply to Fabio Estevam
Quoted 5 lines · Fabio Estevam

Make the necessary adaptions for the new PMIC framework, so that mx25pdk can be built again.

Signed-off-by Fabio Estevam <[email protected]>

---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================