Skip to contentSkip to conversation

mm/hugetlb: create hugetlb cgroup file in hugetlb_init

PATCH In review Jianguo Wu 4 participants 5 messages Dec 13, 2012 – Dec 14, 2012 2 messages not in the archive

Subsystems (3)
Memory management cgroup HugeTLB
lore
Share & tools
lore

Jianguo Wu

author
#0 lore raw

PATCH v2 1/1 mm/hugetlb: create hugetlb cgroup file in hugetlb_init

Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, system will boot fail.

This failure is caused by following code path:
setup_hugepagesz
hugetlb_add_hstate
hugetlb_cgroup_file_init
cgroup_add_cftypes
kzalloc <--slab is *not available* yet

For this path, slab is not available yet, so memory allocated will be failed, and cause WARN_ON() in hugetlb_cgroup_file_init().

So I move hugetlb_cgroup_file_init() into hugetlb_init().

Changelog:
do code refactor as suggesting by Aneesh
add Reviewed-by and Acked-by

Signed-off-by Jianguo Wu <[email protected]>
Signed-off-by Jiang Liu <[email protected]>
Reviewed-by Aneesh Kumar K.V <[email protected]>
Acked-by Michal Hocko <[email protected]>
---
 include/linux/hugetlb_cgroup.h |    7 ++-----
 mm/hugetlb.c                   |   11 +----------
 mm/hugetlb_cgroup.c            |   18 ++++++++++++++++--
 3 files changed, 19 insertions(+), 17 deletions(-)
include/linux/hugetlb_cgroup.h +2 -5
index d73878c..5bb9c28 100644
@@ -62,7 +62,7 @@ extern void hugetlb_cgroup_uncharge_page(int idx, unsigned long nr_pages,
 					 struct page *page);
 extern void hugetlb_cgroup_uncharge_cgroup(int idx, unsigned long nr_pages,
 					   struct hugetlb_cgroup *h_cg);
-extern int hugetlb_cgroup_file_init(int idx) __init;
+extern void hugetlb_cgroup_file_init(void) __init;
 extern void hugetlb_cgroup_migrate(struct page *oldhpage,
 				   struct page *newhpage);
 

@@ -111,10 +111,7 @@ hugetlb_cgroup_uncharge_cgroup(int idx, unsigned long nr_pages,
 	return;
 }
 
-static inline int __init hugetlb_cgroup_file_init(int idx)
-{
-	return 0;
-}
+static inline void __init hugetlb_cgroup_file_init() {}
 
 static inline void hugetlb_cgroup_migrate(struct page *oldhpage,
 					  struct page *newhpage)
mm/hugetlb.c +1 -10
index 1ef2cd4..a30da48 100644
@@ -1906,14 +1906,12 @@ static int __init hugetlb_init(void)
 		default_hstate.max_huge_pages = default_hstate_max_huge_pages;
 
 	hugetlb_init_hstates();
-
 	gather_bootmem_prealloc();
-
 	report_hugepages();
 
 	hugetlb_sysfs_init();
-
 	hugetlb_register_all_nodes();
+	hugetlb_cgroup_file_init();
 
 	return 0;
 }

@@ -1943,13 +1941,6 @@ void __init hugetlb_add_hstate(unsigned order)
 	h->next_nid_to_free = first_node(node_states[N_HIGH_MEMORY]);
 	snprintf(h->name, HSTATE_NAME_LEN, "hugepages-%lukB",
 					huge_page_size(h)/1024);
-	/*
-	 * Add cgroup control files only if the huge page consists
-	 * of more than two normal pages. This is because we use
-	 * page[2].lru.next for storing cgoup details.
-	 */
-	if (order >= HUGETLB_CGROUP_MIN_ORDER)
-		hugetlb_cgroup_file_init(hugetlb_max_hstate - 1);
 
 	parsed_hstate = h;
 }
mm/hugetlb_cgroup.c +16 -2
index a3f358f..7af7459 100644
@@ -340,7 +340,7 @@ static char *mem_fmt(char *buf, int size, unsigned long hsize)
 	return buf;
 }
 
-int __init hugetlb_cgroup_file_init(int idx)
+static void __init __hugetlb_cgroup_file_init(int idx)
 {
 	char buf[32];
 	struct cftype *cft;

@@ -382,7 +382,21 @@ int __init hugetlb_cgroup_file_init(int idx)
 
 	WARN_ON(cgroup_add_cftypes(&hugetlb_subsys, h->cgroup_files));
 
-	return 0;
+	return;
+}
+
+void __init hugetlb_cgroup_file_init()
+{
+	struct hstate *h;
+
+	for_each_hstate(h)
+		/*
+		 * Add cgroup control files only if the huge page consists
+		 * of more than two normal pages. This is because we use
+		 * page[2].lru.next for storing cgroup details.
+		 */
+		if (huge_page_order(h) >= HUGETLB_CGROUP_MIN_ORDER)
+			__hugetlb_cgroup_file_init(hstate_index(h));
 }
 
 /*
Signature · 1 line
1.7.1
#1 lore raw
Quoted 16 lines · Jianguo Wu

Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, system will boot fail.

This failure is caused by following code path:
setup_hugepagesz
hugetlb_add_hstate
hugetlb_cgroup_file_init
cgroup_add_cftypes
kzalloc <--slab is *not available* yet

For this path, slab is not available yet, so memory allocated will be failed, and cause WARN_ON() in hugetlb_cgroup_file_init().

So I move hugetlb_cgroup_file_init() into hugetlb_init().

Quoted 8 lines

Changelog:
do code refactor as suggesting by Aneesh
add Reviewed-by and Acked-by

Signed-off-by Jianguo Wu <[email protected]>
Signed-off-by Jiang Liu <[email protected]>
Reviewed-by Aneesh Kumar K.V <[email protected]>
Acked-by Michal Hocko <[email protected]>

Any reason to not add Cc: stable as I suggested earlier?

Signature · 2 lines
Michal Hocko
SUSE Labs
author
#2 lore raw
Quoted 21 lines · Michal Hocko
Quoted 20 lines · Jianguo Wu

Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, system will boot fail.

This failure is caused by following code path:
setup_hugepagesz
hugetlb_add_hstate
hugetlb_cgroup_file_init
cgroup_add_cftypes
kzalloc <--slab is *not available* yet

For this path, slab is not available yet, so memory allocated will be failed, and cause WARN_ON() in hugetlb_cgroup_file_init().

So I move hugetlb_cgroup_file_init() into hugetlb_init().

Changelog:
do code refactor as suggesting by Aneesh
add Reviewed-by and Acked-by

Quoted 6 lines
Quoted 4 lines
Signed-off-by Jianguo Wu <[email protected]>
Signed-off-by Jiang Liu <[email protected]>
Reviewed-by Aneesh Kumar K.V <[email protected]>
Acked-by Michal Hocko <[email protected]>

Any reason to not add Cc: stable as I suggested earlier?

Hi Michal,

Sorry for forgot that.
Andrew has added Cc: stable when added to -mm tree.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 21 lines · Michal Hocko
Quoted 20 lines · Jianguo Wu

Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, system will boot fail.

This failure is caused by following code path:
setup_hugepagesz
hugetlb_add_hstate
hugetlb_cgroup_file_init
cgroup_add_cftypes
kzalloc <--slab is *not available* yet

For this path, slab is not available yet, so memory allocated will be failed, and cause WARN_ON() in hugetlb_cgroup_file_init().

So I move hugetlb_cgroup_file_init() into hugetlb_init().

Changelog:
do code refactor as suggesting by Aneesh
add Reviewed-by and Acked-by

Quoted 6 lines
Quoted 4 lines
Signed-off-by Jianguo Wu <[email protected]>
Signed-off-by Jiang Liu <[email protected]>
Reviewed-by Aneesh Kumar K.V <[email protected]>
Acked-by Michal Hocko <[email protected]>

Any reason to not add Cc: stable as I suggested earlier?

Hi Michal,

Sorry for forgot that.
Andrew has added Cc: stable when added to -mm tree.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 16 lines · Jianguo Wu

Build kernel with CONFIG_HUGETLBFS=y,CONFIG_HUGETLB_PAGE=y and CONFIG_CGROUP_HUGETLB=y, then specify hugepagesz=xx boot option, system will boot fail.

This failure is caused by following code path:
setup_hugepagesz
hugetlb_add_hstate
hugetlb_cgroup_file_init
cgroup_add_cftypes
kzalloc <--slab is *not available* yet

For this path, slab is not available yet, so memory allocated will be failed, and cause WARN_ON() in hugetlb_cgroup_file_init().

So I move hugetlb_cgroup_file_init() into hugetlb_init().

Quoted 8 lines

Changelog:
do code refactor as suggesting by Aneesh
add Reviewed-by and Acked-by

Signed-off-by Jianguo Wu <[email protected]>
Signed-off-by Jiang Liu <[email protected]>
Reviewed-by Aneesh Kumar K.V <[email protected]>
Acked-by Michal Hocko <[email protected]>

Any reason to not add Cc: stable as I suggested earlier?

Signature · 2 lines
Michal Hocko
SUSE Labs