Skip to contentSkip to conversation

perl: refactor configure step,

PATCH New Francois Perrad 3 participants 3 messages Dec 7, 2012 – Dec 16, 2012

lore
Share & tools
lore

Francois Perrad

author
#0 lore raw

PATCH 1/1 perl: refactor configure step,

after discussion with Perl-Cross's author (Alex Suykov)

Note: Using -A with variables that aren't option lists makes little sense.

Signed-off-by Francois Perrad <[email protected]>
---
 package/perl/perl.mk |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
package/perl/perl.mk +6 -6
index a86ee2a..da54ef1 100644
@@ -57,12 +57,12 @@ PERL_CONF_OPT = \
 	-Dld="$(TARGET_CC_NOCCACHE)" \
 	-Dccflags="$(TARGET_CFLAGS)" \
 	-Dldflags="$(TARGET_LDFLAGS) -lm" \
-	-A define:mydomain="" \
-	-A define:myhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
-	-A define:myuname="Buildroot $(BR2_VERSION_FULL)" \
-	-A define:osname=linux \
-	-A define:osvers=$(LINUX_VERSION) \
-	-A define:perladmin=root
+	-Dmydomain="" \
+	-Dmyhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
+	-Dmyuname="Buildroot $(BR2_VERSION_FULL)" \
+	-Dosname=linux \
+	-Dosvers=$(LINUX_VERSION) \
+	-Dperladmin=root
 
 ifeq ($(shell expr $(PERL_VERSION_MAJOR) % 2), 1)
     PERL_CONF_OPT += -Dusedevel
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 perl: refactor configure step,

Quoted 1 line · Francois Perrad

after discussion with Perl-Cross's author (Alex Suykov)

This splitting of the commit message looks funny in the oneline log...

Quoted 2 lines

Note: Using -A with variables that aren't option lists makes little sense.

Then I misunderstood the meaning of -A: I thought it was meant to override
whatever has been autodetected, while -D can still be overridden by the autodetection. But the documentation isn't particularly clear about this. And I guess Alex Suykov should know :-)

Quoted 2 lines
Signed-off-by Francois Perrad<[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Tested-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>

(build-test on a minimal internal toolchain)

Regards,
Arnout

Quoted 27 lines
---
  package/perl/perl.mk |   12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
package/perl/perl.mk +6 -6
index a86ee2a..da54ef1 100644
@@ -57,12 +57,12 @@ PERL_CONF_OPT = \
  	-Dld="$(TARGET_CC_NOCCACHE)" \
  	-Dccflags="$(TARGET_CFLAGS)" \
  	-Dldflags="$(TARGET_LDFLAGS) -lm" \
-	-A define:mydomain="" \
-	-A define:myhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
-	-A define:myuname="Buildroot $(BR2_VERSION_FULL)" \
-	-A define:osname=linux \
-	-A define:osvers=$(LINUX_VERSION) \
-	-A define:perladmin=root
+	-Dmydomain="" \
+	-Dmyhostname="$(BR2_TARGET_GENERIC_HOSTNAME)" \
+	-Dmyuname="Buildroot $(BR2_VERSION_FULL)" \
+	-Dosname=linux \
+	-Dosvers=$(LINUX_VERSION) \
+	-Dperladmin=root
 
  ifeq ($(shell expr $(PERL_VERSION_MAJOR) % 2), 1)
      PERL_CONF_OPT += -Dusedevel
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 perl: refactor configure step,

In reply to Francois Perrad
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Francois" == Francois Perrad <[email protected]> writes:

Francois> after discussion with Perl-Cross's author (Alex Suykov)

Francois> Note: Using -A with variables that aren't option lists makes Francois> little sense.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard