spi/arm-pl022: Add support for ARM PL022 spi controller

PATCH Superseded Vipin Kumar 4 participants 4 messages Dec 13, 2012 – Jun 2, 2013 SPI

lore

Share & tools

lore

Vipin Kumar

author

2012-12-13 11:41 UTC #0 lore raw

PATCH v3 1/1 spi/arm-pl022: Add support for ARM PL022 spi controller

From: Armando Visconti <[email protected]>

This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO.

Signed-off-by Armando Visconti <[email protected]>

Signed-off-by Vipin Kumar <[email protected]>

---
Changes in v3
Added void to spi_init arguments
Used readl/writel in place of u16 accessors
Fix: Provided address of register in place of value to readl/writel IO
accessors

Tested with spear1340-evb

Stefan, I have not added your Acked-by because the patch has changed after you acked it.

 drivers/spi/Makefile    |   1 +
 drivers/spi/pl022_spi.c | 310 ++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 311 insertions(+)
 create mode 100644 drivers/spi/pl022_spi.c

drivers/spi/Makefile +1 -0

index 824d357..3a4e4b0 100644
@@ -42,6 +42,7 @@ COBJS-$(CONFIG_MXC_SPI) += mxc_spi.o
 COBJS-$(CONFIG_MXS_SPI) += mxs_spi.o
 COBJS-$(CONFIG_OC_TINY_SPI) += oc_tiny_spi.o
 COBJS-$(CONFIG_OMAP3_SPI) += omap3_spi.o
+COBJS-$(CONFIG_PL022_SPI) += pl022_spi.o
 COBJS-$(CONFIG_SOFT_SPI) += soft_spi.o
 COBJS-$(CONFIG_SH_SPI) += sh_spi.o
 COBJS-$(CONFIG_FSL_ESPI) += fsl_espi.o

drivers/spi/pl022_spi.c new file +310 -0

310 lines not on this page · raw message

Signature · 1 line

1.8.0

Stefan Roese

2012-12-13 11:48 UTC #1 lore raw

PATCH v3 1/1 spi/arm-pl022: Add support for ARM PL022 spi controller

Quoted 14 lines · Vipin Kumar

From: Armando Visconti <[email protected]>
This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO.
Signed-off-by Armando Visconti <[email protected]>
Signed-off-by Vipin Kumar <[email protected]>
---
Changes in v3
Added void to spi_init arguments
Used readl/writel in place of u16 accessors
Fix: Provided address of register in place of value to readl/writel IO
accessors

Quoted 4 lines

Tested with spear1340-evb
Stefan, I have not added your Acked-by because the patch has changed after you acked it.

Okay.

Looks still good, so:

Acked-by Stefan Roese <[email protected]>

Thanks,
Stefan

Armando Visconti

2012-12-13 14:01 UTC #2 lore raw

PATCH v3 1/1 spi/arm-pl022: Add support for ARM PL022 spi controller

In reply to Vipin Kumar

Quoted 7 lines · Vipin KUMAR

From: Armando Visconti<[email protected]>
This patch adds the support for the ARM PL022 SPI controller for the standard variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO.
Signed-off-by Armando Visconti<[email protected]>
Signed-off-by Vipin Kumar<[email protected]>

Quoted 9 lines

---
Changes in v3
Added void to spi_init arguments
Used readl/writel in place of u16 accessors
Fix: Provided address of register in place of value to readl/writel IO
accessors
Tested with spear1340-evb

I recall now that SPI variant is same also on the new SoC (I2C cell is different).

So no need to test over it.
SPEAr1340 is enough.

Ciao,
Arm

Jagan Teki

2013-06-02 19:13 UTC #3 lore raw

PATCH v3 1/1 spi/arm-pl022: Add support for ARM PL022 spi controller

Hi,

Does this tested on hw, please re-base the tree and send the next version patch. Let me know if it ok to review under current tree.

--
Thanks,
Jagan.

Quoted 34 lines · Armando Visconti

Quoted 10 lines · Vipin KUMAR
From: Armando Visconti<[email protected]>
This patch adds the support for the ARM PL022 SPI controller for the standard
variant (0x00041022), which has a 16bit wide and 8 locations deep TX/RX FIFO.
Signed-off-by Armando Visconti<[email protected]>
Signed-off-by Vipin Kumar<[email protected]>
Quoted 9 lines
---
Changes in v3
Added void to spi_init arguments
Used readl/writel in place of u16 accessors
Fix: Provided address of register in place of value to readl/writel IO
accessors
Tested with spear1340-evb
I recall now that SPI variant is same also on the new SoC (I2C cell is different).
So no need to test over it.
SPEAr1340 is enough.
Ciao,
Arm
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot