ipv6: Fix Makefile offload objects
Subsystems (2)
PATCH 1/1 ipv6: Fix Makefile offload objects
The following commit breaks IPv6 TCP transmission for me:
Commit 75fe83c32248d99e6d5fe64155e519b78bb90481 Author: Vlad Yasevich <[email protected]> Date: Fri Nov 16 09:41:21 2012 +0000 ipv6: Preserve ipv6 functionality needed by NET
This patch fixes the typo "ipv6_offload" which should be "ipv6-offload".
I don't know why not including the offload modules should break TCP. Disabling all offload options on the NIC didn't help. Outgoing pulseaudio traffic kept stalling.
--- net/ipv6/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
net/ipv6/Makefile +1 -1
@@ -41,6 +41,6 @@ obj-$(CONFIG_IPV6_TUNNEL) += ip6_tunnel.o obj-$(CONFIG_IPV6_GRE) += ip6_gre.o obj-y += addrconf_core.o exthdrs_core.o -obj-$(CONFIG_INET) += output_core.o protocol.o $(ipv6_offload) +obj-$(CONFIG_INET) += output_core.o protocol.o $(ipv6-offload) obj-$(subst m,y,$(CONFIG_IPV6)) += inet6_hashtables.o
Signature · 4 lines
1.7.8.rc3 -- Simon Arlott
Quoted 6 lines · Simon Arlott
The following commit breaks IPv6 TCP transmission for me:
Commit 75fe83c32248d99e6d5fe64155e519b78bb90481 Author: Vlad Yasevich <[email protected]> Date: Fri Nov 16 09:41:21 2012 +0000 ipv6: Preserve ipv6 functionality needed by NET
Quoted 6 lines
This patch fixes the typo "
ipv6_offload" which should be "ipv6-offload".I don't know why not including the offload modules should break TCP. Disabling all offload options on the NIC didn't help. Outgoing pulseaudio traffic kept stalling.
Attached packet capture (on the affected host).
Signature · 1 line
Simon Arlott
From: Simon Arlott <[email protected]>
Date: Sun, 16 Dec 2012 16:47:50 +0000
Quoted 6 lines
The following commit breaks IPv6 TCP transmission for me:
Commit 75fe83c32248d99e6d5fe64155e519b78bb90481 Author: Vlad Yasevich <[email protected]> Date: Fri Nov 16 09:41:21 2012 +0000 ipv6: Preserve ipv6 functionality needed by NET
Quoted 8 lines
This patch fixes the typo "
ipv6_offload" which should be "ipv6-offload".I don't know why not including the offload modules should break TCP. Disabling all offload options on the NIC didn't help. Outgoing pulseaudio traffic kept stalling.
Signed-off-by Simon Arlott <[email protected]>
Applied, since the fix is so obvious.
I'll let Vlad explain why it has such an unexpected effect.
Thanks.
Quoted 6 lines · Simon Arlott
The following commit breaks IPv6 TCP transmission for me:
Commit 75fe83c32248d99e6d5fe64155e519b78bb90481 Author: Vlad Yasevich <[email protected]> Date: Fri Nov 16 09:41:21 2012 +0000 ipv6: Preserve ipv6 functionality needed by NET
Quoted 6 lines
This patch fixes the typo "
ipv6_offload" which should be "ipv6-offload".I don't know why not including the offload modules should break TCP. Disabling all offload options on the NIC didn't help. Outgoing pulseaudio traffic kept stalling.
Did you restart your application to restart the socket?\
The trouble is that whe GSO is turned on, we try to perform it on output. If the output path can't find the gso handler for the protocol (in your case tcp over IPv6), it drops the packet. This causes tcp to retransmit eventually withough GSO.
If you were in a VM, GSO is always used even though you might disable it on the interface with ethtool. The only way I've been able to disable it when using virtio driver is by passing gso=0 parameter to the module.
-vlad
Quoted 19 lines
Signed-off-by Simon Arlott <[email protected]>--- net/ipv6/Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)net/ipv6/Makefile +1
-1@@ -41,6 +41,6 @@ obj-$(CONFIG_IPV6_TUNNEL) += ip6_tunnel.o obj-$(CONFIG_IPV6_GRE) += ip6_gre.o obj-y += addrconf_core.o exthdrs_core.o -obj-$(CONFIG_INET) += output_core.o protocol.o $(ipv6_offload) +obj-$(CONFIG_INET) += output_core.o protocol.o $(ipv6-offload) obj-$(subst m,y,$(CONFIG_IPV6)) += inet6_hashtables.o