Skip to contentSkip to conversation

Added new package ncdu

PATCH New Bogdan Radulescu 3 participants 3 messages Dec 17, 2012 – Jan 14, 2013

lore
Share & tools
lore

Bogdan Radulescu

author
#0 lore raw

PATCH 1/1 Added new package ncdu

Signed-off-by Bogdan Radulescu <[email protected]>

---

?package/Config.in????? |? 1 +
?package/ncdu/Config.in |? 7 +++++++
?package/ncdu/ncdu.mk?? | 13 +++++++++++++

?3 files changed, 21 insertions(+)
?create mode 100644 package/ncdu/Config.in
?create mode 100644 package/ncdu/ncdu.mk

package/Config.in +0 -0
index 171db8f..2d12cdc 100644
@@ -732,6 +732,7 @@ if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS

?source "package/module-init-tools/Config.in"
?endif
?source "package/monit/Config.in"
+source "package/ncdu/Config.in"
?if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
?source "package/procps/Config.in"
?source "package/psmisc/Config.in"

package/ncdu/Config.in new file +7 -0
new file mode 100644
index 0000000..d8b4db4
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_NCDU
+?????? bool "ncdu"
+?????? select BR2_PACKAGE_NCURSES
+?????? help
+???????? ncdu is a disk usage analyzer with an ncurses interface
+
+???????? http://dev.yorhel.nl/ncdu
package/ncdu/ncdu.mk new file +13 -0
new file mode 100644
index 0000000..26f3b5e
@@ -0,0 +1,13 @@
+#############################################################
+#
+# ncdu
+#
+#############################################################
+NCDU_VERSION=1.9
+NCDU_SITE=http://dev.yorhel.nl/download/
+NCDU_INSTALL_STAGING_OPT = instroot=$(STAGING_DIR) install
+NCDU_INSTALL_TARGET_OPT = instroot=$(TARGET_DIR) install
+
+NCDU_DEPENDENCIES = ncurses
+
+$(eval $(autotools-package))
Signature · 8 lines
1.7.12.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ncdu.diff
Type: application/octet-stream
Size: 1812 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20121217/42140369/attachment.obj>
#1 lore raw

PATCH 1/1 Added new package ncdu

Dear Bogdan,

Thanks for your patch.

We prefer generally prefer patches to be sent in-line with the correct
spacing - using git send-email is the easiest way to send a patch.

Some additional comments below.

Quoted 2 lines · Bogdan Radulescu
Signed-off-by Bogdan Radulescu<[email protected]>

[snip]

package/ncdu/Config.in line 2

Quoted 8 lines
package/ncdu/Config.in new file +2 -0
new file mode 100644
index 0000000..d8b4db4
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_NCDU
+       bool "ncdu"

Indentation in Config.in should be a single TAB.

package/ncdu/Config.in line 5

Quoted 3 lines
package/ncdu/Config.in new file +3 -0
+       select BR2_PACKAGE_NCURSES
+       help
+         ncdu is a disk usage analyzer with an ncurses interface

... except for help which should be one TAB + 2 spaces.

Quoted 8 lines
package/ncdu/Config.in new file +2 -0
+
+         http://dev.yorhel.nl/ncdu
package/ncdu/ncdu.mk new file +0 -0
new file mode 100644
index 0000000..26f3b5e

package/ncdu/ncdu.mk line 6

Quoted 6 lines
package/ncdu/ncdu.mk new file +6 -0
@@ -0,0 +1,13 @@
+#############################################################
+#
+# ncdu
+#
+#############################################################
+NCDU_VERSION=1.9

We prefer spaces around the =

NCDU_VERSION = 1.9

package/ncdu/ncdu.mk line 8

Quoted 2 lines
package/ncdu/ncdu.mk new file +2 -0
+NCDU_SITE=http://dev.yorhel.nl/download/
+NCDU_INSTALL_STAGING_OPT = instroot=$(STAGING_DIR) install

Since you don't install to staging, this is redundant.

package/ncdu/ncdu.mk line 9

Quoted 1 line
package/ncdu/ncdu.mk new file +1 -0
+NCDU_INSTALL_TARGET_OPT = instroot=$(TARGET_DIR) install

I don't understand where this comes from... It looks like it should be
DESTDIR=$(TARGET_DIR), which is the default, so this line is redundant as well.

It would be nice to also add the licensing:

NCDU_LICENSE = MIT
NCDU_LICENSE_FILES = COPYING

(test with 'make legal-info')

Regards,
Arnout

Quoted 4 lines
package/ncdu/ncdu.mk new file +4 -0
+
+NCDU_DEPENDENCIES = ncurses
+
+$(eval $(autotools-package))
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 Added new package ncdu

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Arnout" == Arnout Vandecappelle <[email protected]> writes:

Hi Bogdan,

Arnout> We prefer generally prefer patches to be sent in-line with the Arnout> correct spacing - using git send-email is the easiest way to send a Arnout> patch.

Arnout> Some additional comments below.

Could you please send an updated patch taking Arnout's comment into consideration?

Signature · 1 line
Bye, Peter Korsgaard