Skip to contentSkip to conversation

ARM: realview: fix private peripheral memory base for EB rev. B boards

PATCH New Will Deacon 2 participants 7 messages Dec 17, 2012 – Dec 18, 2012

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Will Deacon

author
#0 lore raw

PATCH 1/1 ARM: realview: fix private peripheral memory base for EB rev. B boards

Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards.

This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.

Cc Marc Zyngier <[email protected]>
Tested-by Florian Fainelli <[email protected]>
Signed-off-by Will Deacon <[email protected]>
---
 arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-realview/include/mach/board-eb.h +1 -1
index 124bce6..a301e61 100644
@@ -47,7 +47,7 @@
 #define REALVIEW_EB_USB_BASE		0x4F000000	/* USB */
 
 #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
-#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x1F000000
+#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x10100000
 #define REALVIEW_EB11MP_L220_BASE	0x10102000	/* L220 registers */
 #define REALVIEW_EB11MP_SYS_PLD_CTRL1	0xD8		/* Register offset for MPCore sysctl */
 #else
Signature · 1 line
1.8.0
#1 lore raw

PATCH 1/1 ARM: realview: fix private peripheral memory base for EB rev. B boards

Quoted 10 lines · Will Deacon

Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards.

This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.

Cc Marc Zyngier <[email protected]>
Tested-by Florian Fainelli <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Marc Zyngier <[email protected]>
Quoted 18 lines
---
 arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-realview/include/mach/board-eb.h +1 -1
index 124bce6..a301e61 100644
@@ -47,7 +47,7 @@
 #define REALVIEW_EB_USB_BASE		0x4F000000	/* USB */
 
 #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
-#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x1F000000
+#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x10100000
 #define REALVIEW_EB11MP_L220_BASE	0x10102000	/* L220 registers */
 #define REALVIEW_EB11MP_SYS_PLD_CTRL1	0xD8		/* Register offset for MPCore sysctl */
 #else
Signature · 1 line
Jazz is not dead. It just smells funny...
#2 lore raw

PATCH 1/1 ARM: realview: fix private peripheral memory base for EB rev. B boards

In reply to Will Deacon
Quoted 10 lines · Will Deacon

Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards.

This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.

Cc Marc Zyngier <[email protected]>
Tested-by Florian Fainelli <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Marc Zyngier <[email protected]>
Quoted 18 lines
---
 arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-realview/include/mach/board-eb.h +1 -1
index 124bce6..a301e61 100644
@@ -47,7 +47,7 @@
 #define REALVIEW_EB_USB_BASE		0x4F000000	/* USB */
 
 #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
-#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x1F000000
+#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x10100000
 #define REALVIEW_EB11MP_L220_BASE	0x10102000	/* L220 registers */
 #define REALVIEW_EB11MP_SYS_PLD_CTRL1	0xD8		/* Register offset for MPCore sysctl */
 #else
Signature · 1 line
Jazz is not dead. It just smells funny...
#3 lore raw

PATCH 1/1 ARM: realview: fix private peripheral memory base for EB rev. B boards

In reply to Will Deacon
Quoted 10 lines · Will Deacon

Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards.

This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.

Cc Marc Zyngier <[email protected]>
Tested-by Florian Fainelli <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Marc Zyngier <[email protected]>
Quoted 18 lines
---
 arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-realview/include/mach/board-eb.h +1 -1
index 124bce6..a301e61 100644
@@ -47,7 +47,7 @@
 #define REALVIEW_EB_USB_BASE		0x4F000000	/* USB */
 
 #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
-#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x1F000000
+#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x10100000
 #define REALVIEW_EB11MP_L220_BASE	0x10102000	/* L220 registers */
 #define REALVIEW_EB11MP_SYS_PLD_CTRL1	0xD8		/* Register offset for MPCore sysctl */
 #else
Signature · 1 line
Jazz is not dead. It just smells funny...
#4 lore raw

PATCH 1/1 ARM: realview: fix private peripheral memory base for EB rev. B boards

In reply to Will Deacon
Quoted 10 lines · Will Deacon

Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards.

This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.

Cc Marc Zyngier <[email protected]>
Tested-by Florian Fainelli <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Marc Zyngier <[email protected]>
Quoted 18 lines
---
 arch/arm/mach-realview/include/mach/board-eb.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mach-realview/include/mach/board-eb.h +1 -1
index 124bce6..a301e61 100644
@@ -47,7 +47,7 @@
 #define REALVIEW_EB_USB_BASE		0x4F000000	/* USB */
 
 #ifdef CONFIG_REALVIEW_EB_ARM11MP_REVB
-#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x1F000000
+#define REALVIEW_EB11MP_PRIV_MEM_BASE	0x10100000
 #define REALVIEW_EB11MP_L220_BASE	0x10102000	/* L220 registers */
 #define REALVIEW_EB11MP_SYS_PLD_CTRL1	0xD8		/* Register offset for MPCore sysctl */
 #else
Signature · 1 line
Jazz is not dead. It just smells funny...
#5 lore raw

PATCH 1/1 ARM: realview: fix private peripheral memory base for EB rev. B boards

Quoted 6 lines · Marc Zyngier
Quoted 5 lines · Will Deacon

Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards.

Quoted 7 lines
Quoted 5 lines

This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.

Cc Marc Zyngier <[email protected]>
Tested-by Florian Fainelli <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Marc Zyngier <[email protected]>

The ARM email server seems to be acting up. Sorry for the noise.

        M.
Signature · 1 line
Fast, cheap, reliable. Pick two.
author
#6 lore raw

PATCH 1/1 ARM: realview: fix private peripheral memory base for EB rev. B boards

Quoted 10 lines · Marc Zyngier
Quoted 8 lines · Marc Zyngier
Quoted 7 lines · Will Deacon

Commit 34ae6c96a6a7 ("ARM: 7298/1: realview: fix mapping of MPCore private memory region") accidentally broke the definition for the base address of the private peripheral region on revision B Realview-EB boards.

This patch uses the correct address for REALVIEW_EB11MP_PRIV_MEM_BASE.

Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Cc Marc Zyngier <[email protected]>
Tested-by Florian Fainelli <[email protected]>
Signed-off-by Will Deacon <[email protected]>
Acked-by Marc Zyngier <[email protected]>

The ARM email server seems to be acting up. Sorry for the noise.

Damn, I just thought you were really into the patch.

Will