Skip to contentSkip to conversation

Fix clang --analyze warning.

PATCH New Sitsofe Wheeler 2 participants 2 messages Dec 17, 2012 – Dec 18, 2012

lore
Share & tools
lore

Sitsofe Wheeler

author
#0 lore raw

PATCH 1/1 Fix clang --analyze warning.

- Return before a possible NULL pointer dereference.

---
 gfs2/libgfs2/fs_bits.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
gfs2/libgfs2/fs_bits.c +2 -0
index 94a612b..e4b5505 100644
@@ -149,6 +149,8 @@ int gfs2_set_bitmap(struct gfs2_sbd *sdp, uint64_t blkno, int state)
 			break;
 	}
 
+	if (bits == NULL)
+		return -1;
 	byte = (unsigned char *)(rgd->bh[buf]->b_data + bits->bi_offset) +
 		(rgrp_block/GFS2_NBBY - bits->bi_start);
 	bit = (rgrp_block % GFS2_NBBY) * GFS2_BIT_SIZE;
Signature · 1 line
1.7.2.5
#1 lore raw

PATCH 1/1 Fix clang --analyze warning.

Hi Sits

Quoted 1 line · Sitsofe Wheeler

- Return before a possible NULL pointer dereference.

This is now in gfs2-utils.git master.

Thanks,

Andy

Quoted 18 lines
---
  gfs2/libgfs2/fs_bits.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
gfs2/libgfs2/fs_bits.c +2 -0
index 94a612b..e4b5505 100644
@@ -149,6 +149,8 @@ int gfs2_set_bitmap(struct gfs2_sbd *sdp, uint64_t blkno, int state)
  			break;
  	}
 
+	if (bits == NULL)
+		return -1;
  	byte = (unsigned char *)(rgd->bh[buf]->b_data + bits->bi_offset) +
  		(rgrp_block/GFS2_NBBY - bits->bi_start);
  	bit = (rgrp_block % GFS2_NBBY) * GFS2_BIT_SIZE;