Skip to contentSkip to conversation

package/uboot-tools: Add mkenvimage for host.

PATCH New Arnaud Rébillout 2 participants 4 messages Dec 19, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/uboot-tools: Add mkenvimage for host.

Hello there,

I need to use mkenvimage. And it seems that the easiest way is to automatically install it in the HOST_UBOOT_TOOLS_INSTALL_CMDS target. The tool mkenvimage appeared v2011.12 of uboot, so it's present in all the versions that buildroot supports.
The patch is a simple line, if anyone is interested.

Regards

---

(quoted diff) +0 -0

b/package/uboot-tools/uboot-tools.mk
index 7628b77..57c59bb 100644

package/uboot-tools/uboot-tools.mk +1 -0
@@ -49,6 +49,7 @@ endef
 
  define HOST_UBOOT_TOOLS_INSTALL_CMDS
      $(INSTALL) -m 0755 -D $(@D)/tools/mkimage $(HOST_DIR)/usr/bin/mkimage
+    $(INSTALL) -m 0755 -D $(@D)/tools/mkenvimage 

$(HOST_DIR)/usr/bin/mkenvimage
endef

  $(eval $(generic-package))

---

#1 lore raw

PATCH 1/1 package/uboot-tools: Add mkenvimage for host.

Dear Arnaud R?billout,

Quoted 5 lines · Arnaud R?billout

I need to use mkenvimage. And it seems that the easiest way is to automatically install it in the HOST_UBOOT_TOOLS_INSTALL_CMDS target. The tool mkenvimage appeared v2011.12 of uboot, so it's present in all the versions that buildroot supports.
The patch is a simple line, if anyone is interested.

Indeed, mkenvimage is useful.

However:

*) Could you send a proper git patch, with a description, Signed-off-by line, and sent using git send-email so that it doesn't get line-wrapped by your mail client.

*) I would like to see an option being added in the U-Boot configuration options to pass a txt file containing an environment definition, which would be passed through mkenvimage to generate an image environment, and then installed in $(BINARIES_DIR). Could you cook such a patch, or do you prefer if someone else does it?

Thanks,

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 package/uboot-tools: Add mkenvimage for host.

Hi Mr. Petazzoni,

Quoted 3 lines

*) Could you send a proper git patch, with a description, Signed-off-by line, and sent using git send-email so that it doesn't get line-wrapped by your mail client.

Ok I will look at that and do my best.

Quoted 5 lines

*) I would like to see an option being added in the U-Boot configuration options to pass a txt file containing an environment definition, which would be passed through mkenvimage to generate an image environment, and then installed in $(BINARIES_DIR). Could you cook such a patch, or do you prefer if someone else does it?

Sounds good to me, I will send you a new patch. Hopefully before the end of the week.

Thanks,

Quoted 26 lines · Thomas Petazzoni

Dear Arnaud R?billout,

Quoted 5 lines · Arnaud R?billout

I need to use mkenvimage. And it seems that the easiest way is to automatically install it in the HOST_UBOOT_TOOLS_INSTALL_CMDS target. The tool mkenvimage appeared v2011.12 of uboot, so it's present in all the versions that buildroot supports.
The patch is a simple line, if anyone is interested.

Indeed, mkenvimage is useful.

However:

*) Could you send a proper git patch, with a description, Signed-off-by line, and sent using git send-email so that it doesn't get line-wrapped by your mail client.

*) I would like to see an option being added in the U-Boot configuration options to pass a txt file containing an environment definition, which would be passed through mkenvimage to generate an image environment, and then installed in $(BINARIES_DIR). Could you cook such a patch, or do you prefer if someone else does it?

Thanks,

Thomas

Signature · 6 lines
Arnaud R?billout
SYSCOM Instruments SA
rue de l'industrie 21
CH-1450 Sainte-Croix
Switzerland
Tel: +41 (0)24 455 44 11
#3 lore raw

PATCH 1/1 package/uboot-tools: Add mkenvimage for host.

Dear Arnaud R?billout,

Quoted 4 lines · Arnaud R?billout
Quoted 3 lines

*) Could you send a proper git patch, with a description, Signed-off-by line, and sent using git send-email so that it doesn't get line-wrapped by your mail client.

Ok I will look at that and do my best.

No problem. If you need help, don't hesitate to ask. Basically, your mail should look like:

==================================================================
u-boot: add support for mkenvimage installation and usage

U-Boot has an utility called mkenvimage that allows blablabla. This commit installs this utility and provides configuration options for blablabla.

---
<the patch goes here>
==================================================================

This gets done automatically by Git as long as you provide the text above as the commit log.

Quoted 7 lines
Quoted 5 lines

*) I would like to see an option being added in the U-Boot configuration options to pass a txt file containing an environment definition, which would be passed through mkenvimage to generate an image environment, and then installed in $(BINARIES_DIR). Could you cook such a patch, or do you prefer if someone else does it?

Sounds good to me, I will send you a new patch. Hopefully before the end of the week.

Excellent, thanks!

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com