Skip to contentSkip to conversation

ARM: EXYNOS: fix GIC using for EXYNOS5440

PATCH New Kukjin Kim 2 participants 4 messages Dec 10, 2012 – Dec 20, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm Samsung Exynos
lore
Share & tools
lore

Kukjin Kim

author
#0 lore raw

PATCH 1/1 ARM: EXYNOS: fix GIC using for EXYNOS5440

Signed-off-by Kukjin Kim <[email protected]>
---
 arch/arm/mach-exynos/common.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-exynos/common.c +2 -1
index 0eb3b9a..9ecda37 100644
@@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
 	 * Theses parameters should be NULL and 0 because EXYNOS4
 	 * uses GIC instead of VIC.
 	 */
-	s5p_init_irq(NULL, 0);
+	if (!of_machine_is_compatible("samsung,exynos5440"))
+		s5p_init_irq(NULL, 0);
 
 	gic_arch_extn.irq_set_wake = s3c_irq_wake;
 }
Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 ARM: EXYNOS: fix GIC using for EXYNOS5440

Hi,

Quoted 10 lines · Kukjin Kim
Signed-off-by Kukjin Kim <[email protected]>
---
  arch/arm/mach-exynos/common.c |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach-exynos/common.c +0 -0
index 0eb3b9a..9ecda37 100644

arch/arm/mach-exynos/common.c void __init exynos5_init_irq(void) · line 688

Quoted 6 lines
arch/arm/mach-exynos/common.c +2 -1
@@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
  	 * Theses parameters should be NULL and 0 because EXYNOS4
  	 * uses GIC instead of VIC.
  	 */
-	s5p_init_irq(NULL, 0);
+	if (!of_machine_is_compatible("samsung,exynos5440"))
+		s5p_init_irq(NULL, 0);

How about remove to call s5p_init_irq() here because All exynos SoCs use GIC instead of VIC?

Quoted 3 lines
arch/arm/mach-exynos/common.c +0 -0
  	gic_arch_extn.irq_set_wake = s3c_irq_wake;
  }
author
#2 lore raw

PATCH 1/1 ARM: EXYNOS: fix GIC using for EXYNOS5440

Quoted 11 lines · Joonyoung Shim

Hi,

arch/arm/mach-

Quoted 6 lines · Kukjin Kim
Signed-off-by Kukjin Kim <[email protected]>
---
  arch/arm/mach-exynos/common.c |    3 ++-
  1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-exynos/common.c +0 -0

exynos/common.c

Quoted 14 lines

arch/arm/mach-exynos/common.c void __init exynos5_init_irq(void) · line 688

Quoted 10 lines

index 0eb3b9a..9ecda37 100644

arch/arm/mach-exynos/common.c +2 -1
@@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
  	 * Theses parameters should be NULL and 0 because EXYNOS4
  	 * uses GIC instead of VIC.
  	 */
-	s5p_init_irq(NULL, 0);
+	if (!of_machine_is_compatible("samsung,exynos5440"))
+		s5p_init_irq(NULL, 0);

How about remove to call s5p_init_irq() here because All exynos SoCs use GIC instead of VIC?

NO, the current s5p_init_irq() is not only for VIC but also Timer which is used on EXYNOS SoCs, I know the name is strange...

Quoted 2 lines
Quoted 2 lines
arch/arm/mach-exynos/common.c +0 -0
  	gic_arch_extn.irq_set_wake = s3c_irq_wake;
  }
#3 lore raw

PATCH 1/1 ARM: EXYNOS: fix GIC using for EXYNOS5440

Quoted 24 lines · Kukjin Kim
Quoted 10 lines · Joonyoung Shim

Hi,

arch/arm/mach-

Quoted 6 lines · Kukjin Kim
Signed-off-by Kukjin Kim <[email protected]>
---
   arch/arm/mach-exynos/common.c |    3 ++-
   1 files changed, 2 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-exynos/common.c +0 -0

exynos/common.c

Quoted 13 lines

arch/arm/mach-exynos/common.c void __init exynos5_init_irq(void) · line 688

Quoted 10 lines

index 0eb3b9a..9ecda37 100644

arch/arm/mach-exynos/common.c +2 -1
@@ -684,7 +684,8 @@ void __init exynos5_init_irq(void)
   	 * Theses parameters should be NULL and 0 because EXYNOS4
   	 * uses GIC instead of VIC.
   	 */
-	s5p_init_irq(NULL, 0);
+	if (!of_machine_is_compatible("samsung,exynos5440"))
+		s5p_init_irq(NULL, 0);

How about remove to call s5p_init_irq() here because All exynos SoCs use GIC instead of VIC?

Quoted 2 lines

NO, the current s5p_init_irq() is not only for VIC but also Timer which is used on EXYNOS SoCs, I know the name is strange...

I think timer can be selective by MCT on Exynos SoCs.

The patch(ARM: EXYNOS: remove static mapping of PWM memory) is for it.

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
arch/arm/mach-exynos/common.c +0 -0
   	gic_arch_extn.irq_set_wake = s3c_irq_wake;
   }