Makefile: add toolchain target
v2 cover Makefile: add toolchain target
Hi all,
this patch set is to add a toolchain target to be able to build only the toolchain right after a defconfig or a clean.
Best regards
Fabio Porcedda (2):
Makefile: rename cross target -> toolchain
Makefile: use toolchain target in the world target
Makefile | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
Signature · 1 line
1.8.0
PATCH v2 1/2 Makefile: rename cross target -> toolchain
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target right after the configuration.
- Move to a better position.
- Documentation it in the help target.
--- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
Makefile +4 -3
@@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config prepare: $(BUILD_DIR)/buildroot-config/auto.conf +toolchain: prepare dirs dependencies $(BASE_TARGETS) + world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) -.PHONY: all world dirs clean distclean source outputmakefile \ +.PHONY: all world toolchain dirs clean distclean source outputmakefile \ legal-info legal-info-prepare legal-info-clean \ $(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \ $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \
@@ -697,8 +699,6 @@ ifeq ($(O),output) endif rm -rf $(CONFIG_DIR)/.config $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/.auto.deps -cross: $(BASE_TARGETS) - help: @echo 'Cleaning:' @echo ' clean - delete all files created by build'
@@ -706,6 +706,7 @@ help: @echo @echo 'Build:' @echo ' all - make world' + @echo ' toolchain - build toolchain' @echo ' <package>-rebuild - force recompile <package>' @echo ' <package>-reconfigure - force reconfigure <package>' @echo
Signature · 1 line
1.8.0
PATCH v2 1/2 Makefile: rename cross target -> toolchain
Quoted 48 lines · Fabio Porcedda
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target right after the configuration.
- Move to a better position.
- Documentation it in the help target.Signed-off-by Fabio Porcedda <[email protected]>--- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)Makefile +4
-4@@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config prepare: $(BUILD_DIR)/buildroot-config/auto.conf +toolchain: prepare dirs dependencies $(BASE_TARGETS) + world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) -.PHONY: all world dirs clean distclean source outputmakefile \ +.PHONY: all world toolchain dirs clean distclean source outputmakefile \ legal-info legal-info-prepare legal-info-clean \ $(BASE_TARGETS) $(TARGETS) $(TARGETS_ALL) \ $(TARGETS_CLEAN) $(TARGETS_DIRCLEAN) $(TARGETS_SOURCE) $(TARGETS_LEGAL_INFO) \@@ -697,8 +699,6 @@ ifeq ($(O),output) endif rm -rf $(CONFIG_DIR)/.config $(CONFIG_DIR)/.config.old $(CONFIG_DIR)/.auto.deps -cross: $(BASE_TARGETS) - help: @echo 'Cleaning:' @echo ' clean - delete all files created by build'@@ -706,6 +706,7 @@ help: @echo @echo 'Build:' @echo ' all - make world' + @echo ' toolchain - build toolchain' @echo ' <package>-rebuild - force recompile <package>' @echo ' <package>-reconfigure - force reconfigure <package>' @echo --1.8.0
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
This one looks good to me as well
Signature · 2 lines
Regards, Markos
PATCH v2 1/2 Makefile: rename cross target -> toolchain
In reply to Fabio PorceddaQuoted 7 lines · Fabio Porcedda
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target right after the configuration.
- Move to a better position.
- Documentation it in the help target.Signed-off-by Fabio Porcedda<[email protected]>
(not tested but it's trivial enough)
Some additional suggestions (for additional patches):
- Document it in the manual.
- Add toolchain as a dependency to $(1)-configure for target-packages; this makes it possible to remove it from the dependencies of 'world' and brings us a step closer to top-level parallel build.
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
PATCH v2 1/2 Makefile: rename cross target -> toolchain
Quoted 14 lines · Arnout Vandecappelle
Quoted 8 lines · Fabio Porcedda
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target right after the configuration.
- Move to a better position.
- Documentation it in the help target.Signed-off-by Fabio Porcedda<[email protected]>(not tested but it's trivial enough)
Quoted 7 lines
Some additional suggestions (for additional patches):
- Document it in the manual.
- Add toolchain as a dependency to $(1)-configure for target-packages; this makes it possible to remove it from the dependencies of 'world' and brings us a step closer to top-level parallel build.
Thank for the review.
I like your suggestions.
I will work on that for additional patches.
Best regards
--
Fabio Porcedda
PATCH v2 1/2 Makefile: rename cross target -> toolchain
In reply to Fabio PorceddaHi Fabio,
2012/12/21 Fabio Porcedda <[email protected]>:
Quoted 16 lines
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target right after the configuration.
- Move to a better position.
- Documentation it in the help target.Signed-off-by Fabio Porcedda <[email protected]>--- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)Makefile +0
-0
Makefile $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config · line 382
Quoted 6 lines
Makefile +2
-0@@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config prepare: $(BUILD_DIR)/buildroot-config/auto.conf +toolchain: prepare dirs dependencies $(BASE_TARGETS) + world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)
Any reason to not make the world target depend on the toolchain and $(TARGETS_ALL) targets?
IOW:
world: toolchain $(TARGETS_ALL)
Otherwise, it looks good to me with few words in the manual as already mentioned by Arnout.
Regards,
Signature · 1 line
Sam
PATCH v2 1/2 Makefile: rename cross target -> toolchain
Quoted 22 lines · Samuel Martin
Hi Fabio,
2012/12/21 Fabio Porcedda <[email protected]>:
Quoted 19 lines
- Use a more descriptive name, the same of the "toolchain" directory.
- Add missing dependencies to be able to successfully use the target right after the configuration.
- Move to a better position.
- Documentation it in the help target.Signed-off-by Fabio Porcedda <[email protected]>--- Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)Makefile +0
-0@@ -377,9 +377,11 @@ $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config prepare: $(BUILD_DIR)/buildroot-config/auto.conf
Quoted 7 lines
Makefile $(BUILD_DIR)/buildroot-config/auto.conf: $(CONFIG_DIR)/.config · line 382
Quoted 3 lines
Makefile +2
-0+toolchain: prepare dirs dependencies $(BASE_TARGETS) + world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL)Any reason to not make the world target depend on the toolchain and $(TARGETS_ALL) targets?
IOW:
world: toolchain $(TARGETS_ALL)
I've done exactly that in the following patch 2/2
Quoted 2 lines
Otherwise, it looks good to me with few words in the manual as already mentioned by Arnout.
Thanks for the review
Best regards
--
Fabio Porcedda
PATCH v2 2/2 Makefile: use toolchain target in the world target
In reply to Fabio PorceddaThis is to remove redundancy and simplify the rule.
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
@@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf toolchain: prepare dirs dependencies $(BASE_TARGETS) -world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) +world: toolchain $(TARGETS_ALL) .PHONY: all world toolchain dirs clean distclean source outputmakefile \ legal-info legal-info-prepare legal-info-clean \
Signature · 1 line
1.8.0
PATCH v2 2/2 Makefile: use toolchain target in the world target
Quoted 23 lines · Fabio Porcedda
This is to remove redundancy and simplify the rule.
Signed-off-by Fabio Porcedda <[email protected]>--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-2@@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf toolchain: prepare dirs dependencies $(BASE_TARGETS) -world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) +world: toolchain $(TARGETS_ALL) .PHONY: all world toolchain dirs clean distclean source outputmakefile \ legal-info legal-info-prepare legal-info-clean \ --1.8.0
Quoted 4 lines
_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Looks good to me
Signature · 2 lines
Regards, Markos
PATCH v2 2/2 Makefile: use toolchain target in the world target
In reply to Fabio PorceddaQuoted 3 lines · Fabio Porcedda
This is to remove redundancy and simplify the rule.
Signed-off-by Fabio Porcedda<[email protected]>
(untested but trivial enough)
Regards,
Arnout
Quoted 17 lines
--- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Makefile +1
-1@@ -379,7 +379,7 @@ prepare: $(BUILD_DIR)/buildroot-config/auto.conf toolchain: prepare dirs dependencies $(BASE_TARGETS) -world: prepare dirs dependencies $(BASE_TARGETS) $(TARGETS_ALL) +world: toolchain $(TARGETS_ALL) .PHONY: all world toolchain dirs clean distclean source outputmakefile \ legal-info legal-info-prepare legal-info-clean \
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286540 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
v2 cover Makefile: add toolchain target
In reply to Fabio PorceddaQuoted 10 lines · Fabio Porcedda
Hi all,
this patch set is to add a toolchain target to be able to build only the toolchain right after a defconfig or a clean.Best regards
Fabio Porcedda (2):
Makefile: rename cross target -> toolchain
Makefile: use toolchain target in the world target
Quoted 6 lines
Makefile | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)--
1.8.0
ping
--
Fabio Porcedda
v2 cover Makefile: add toolchain target
Hi Fabio, all,
2013/1/7 Fabio Porcedda <[email protected]>:
Quoted 6 lines
Quoted 4 lines · Fabio Porcedda
Hi all,
this patch set is to add a toolchain target to be able to build only the toolchain right after a defconfig or a clean.
Quoted 6 lines
Quoted 6 lines
Best regards
Fabio Porcedda (2):
Makefile: rename cross target -> toolchain
Makefile: use toolchain target in the world target
Though it makes sense to me to squash these 2 patches into a single one, you have my ack for the whole serie:
Regards,
Signature · 1 line
Samuel
v2 cover Makefile: add toolchain target
Quoted 1 line · Samuel Martin
Hi Fabio, all,
Hi Samuel,
Quoted 9 lines
2013/1/7 Fabio Porcedda <[email protected]>:
Quoted 8 lines
Quoted 6 lines · Fabio Porcedda
Hi all,
this patch set is to add a toolchain target to be able to build only the toolchain right after a defconfig or a clean.Best regards
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
Fabio Porcedda (2):
Makefile: rename cross target -> toolchain
Makefile: use toolchain target in the world targetThough it makes sense to me to squash these 2 patches into a single one, you have my ack for the whole serie:
Acked-by Samuel Martin <[email protected]>
Thanks for reviewing the patch set.
Now i think too that is better to squash them.
I will send a updated patch.
Best regards
--
Fabio Porcedda