Skip to contentSkip to conversation

mmc: fsl_esdhc: Use calloc()

PATCH New Fabio Estevam 2 participants 2 messages Dec 27, 2012 MMC, SD and SDIO

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH v2 1/1 mmc: fsl_esdhc: Use calloc()

From: Fabio Estevam <[email protected]>

A malloc() followed by memset() can be simply replaced by calloc().

Signed-off-by Fabio Estevam <[email protected]>

---
Change since v1:
- Fix commit log

 drivers/mmc/fsl_esdhc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +1 -2
index e93e38a..5fc1c36 100644
@@ -595,8 +595,7 @@ int fsl_esdhc_mmc_init(bd_t *bis)
 {
 	struct fsl_esdhc_cfg *cfg;
 
-	cfg = malloc(sizeof(struct fsl_esdhc_cfg));
-	memset(cfg, 0, sizeof(struct fsl_esdhc_cfg));
+	cfg = calloc(sizeof(struct fsl_esdhc_cfg), 1);
 	cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;
 	cfg->sdhc_clk = gd->sdhc_clk;
 	return fsl_esdhc_initialize(bis, cfg);
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/1 mmc: fsl_esdhc: Use calloc()

Quoted 16 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

A malloc() followed by memset() can be simply replaced by calloc().

Signed-off-by Fabio Estevam <[email protected]>

---
Change since v1:
- Fix commit log

  drivers/mmc/fsl_esdhc.c |    3 +--
  1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mmc/fsl_esdhc.c +0 -0
index e93e38a..5fc1c36 100644

drivers/mmc/fsl_esdhc.c int fsl_esdhc_mmc_init(bd_t *bis) · line 601

Quoted 9 lines
drivers/mmc/fsl_esdhc.c +1 -2
@@ -595,8 +595,7 @@ int fsl_esdhc_mmc_init(bd_t *bis)
  {
  	struct fsl_esdhc_cfg *cfg;
 
-	cfg = malloc(sizeof(struct fsl_esdhc_cfg));
-	memset(cfg, 0, sizeof(struct fsl_esdhc_cfg));
+	cfg = calloc(sizeof(struct fsl_esdhc_cfg), 1);
  	cfg->esdhc_base = CONFIG_SYS_FSL_ESDHC_ADDR;
  	cfg->sdhc_clk = gd->sdhc_clk;
  	return fsl_esdhc_initialize(bis, cfg);

nitpicking: if you're cleaning up, why not swap the arguments to calloc ;)

Regards,
Jeroen