Skip to contentSkip to conversation

Fix prelink build with automake-1.13

PATCH New Marko Lindqvist 2 participants 4 messages Jan 3, 2013

lore
Share & tools
lore
#0 lore raw

[PATCH] fix build with automake-1.13.

Long obsolete AM_CONFIG_HEADER is completely removed from automake-1.13, which errors out upon seeing it.
configure.in -> configure.ac rename is not strictly necessary yet, use of deprecated name still gives only warning.

Problem in dropping obsolete constructs is that support for autotools versions so ancient that now-obsolete way is the only way to do things. configure.in seems to have AC_PREREQ(2.13), but with these changes (if not earlier) such an ancient autoconf will not do.

- ML

#1 lore raw

PATCH 1/1 fix build with automake-1.13.

Rename autoconf input file from deprecated name configure.in to configure.ac
Replace AM_CONFIG_HEADER obsoleted in automake-1.13 with AC_CONFIG_HEADERS.

---
 trunk/{configure.in => configure.ac} |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 rename trunk/{configure.in => configure.ac} (98%)
trunk/configure.ac renamed from trunk/configure.in +1 -1
similarity index 98%
rename from trunk/configure.in
rename to trunk/configure.ac
index 396f3ac..a90cfb2 100644
@@ -1,6 +1,6 @@
 dnl Process this file with autoconf to produce a configure script. -*-m4-*-
 AC_INIT(src/prelink.c)
-AM_CONFIG_HEADER(config.h)
+AC_CONFIG_HEADERS(config.h)
 AC_PREREQ(2.13)			dnl Minimum Autoconf version required.
 AC_CANONICAL_HOST
 
Signature · 1 line
1.7.10.4
#2 lore raw
In reply to Marko Lindqvist
Quoted 7 lines · Marko Lindqvist

[PATCH] fix build with automake-1.13.

Long obsolete AM_CONFIG_HEADER is completely removed from automake-1.13, which errors out upon seeing it.
configure.in -> configure.ac rename is not strictly necessary yet, use of deprecated name still gives only warning.

Quoted 5 lines

Problem in dropping obsolete constructs is that support for autotools versions so ancient that now-obsolete way is the only way to do things. configure.in seems to have AC_PREREQ(2.13), but with these changes (if not earlier) such an ancient autoconf will not do.

Do you know if the change to AC_CONFIG_HEADER (from AM_CONFIG_HEADER) is supported in autoconf 2.13? Assuming it likely is, I'll get this merged. Otherwise we should expect to bump the AC_PREREQ.

BTW I'll check and see if this patch is specific to the cross-prelinker or applicable to the upstream prelink as well. Seems like if it's applicable there they may want it as well..

--Mark

Quoted 2 lines

- ML

#3 lore raw
Quoted 14 lines · Mark Hatle
Quoted 7 lines · Marko Lindqvist

[PATCH] fix build with automake-1.13.

Long obsolete AM_CONFIG_HEADER is completely removed from automake-1.13, which errors out upon seeing it.
configure.in -> configure.ac rename is not strictly necessary yet, use of deprecated name still gives only warning.

Quoted 5 lines

Problem in dropping obsolete constructs is that support for autotools versions so ancient that now-obsolete way is the only way to do things. configure.in seems to have AC_PREREQ(2.13), but with these changes (if not earlier) such an ancient autoconf will not do.

Quoted 7 lines

Do you know if the change to AC_CONFIG_HEADER (from AM_CONFIG_HEADER) is supported in autoconf 2.13? Assuming it likely is, I'll get this merged. Otherwise we should expect to bump the AC_PREREQ.

BTW I'll check and see if this patch is specific to the cross-prelinker or applicable to the upstream prelink as well. Seems like if it's applicable there they may want it as well..

Responding to my own query. I just checked and the cross-prelinker is already setup for AC_PREREQ(2.50):

http://git.yoctoproject.org/cgit/cgit.cgi/prelink-cross/tree/trunk/configure.in?h=cross_prelink

(The unmodified upstream -- master branch -- is still using AC_PREREQ(2.13). But we don't use that in OE/Yocto Project work.)

The -- cross_prelink branch -- does still have the AM_CONFIG_HEADER. I'll get that updated. I will also rename the configure.in to configure.ac and adjust anything else that references that.

--Mark

Quoted 5 lines

--Mark

Quoted 2 lines

- ML