gnuplot : new package

PATCH New Anthony Viallard 3 participants 8 messages Jan 4, 2013

lore

Share & tools

lore

Anthony Viallard

author

2013-01-04 14:53 UTC #0 lore raw

PATCH 1/1 gnuplot : new package

Signed-off-by Anthony Viallard <[email protected]>

---
 package/Config.in             |    1 +
 package/gnuplot/Config.in     |    7 +++++++
 package/gnuplot/gnuplot.mk    |   13 +++++++++++++
 package/gnuplot/gnuplot.patch |   26 ++++++++++++++++++++++++++
 4 files changed, 57 insertions(+), 0 deletion(-)
 create mode 100644 package/gnuplot/Config.in
 create mode 100644 package/gnuplot/gnuplot.mk
 create mode 100644 package/gnuplot/gnuplot.patch

package/Config.in +1 -0

@@ -70,6 +70,7 @@ endif
 source "toolchain/gcc/Config.in.2"
 source "package/gettext/Config.in"
 source "package/gmp/Config.in"
+source "package/gnuplot/Config.in"
 source "package/gperf/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/grep/Config.in"

package/gnuplot/Config.in new file +7 -0

new file mode 100644
index 0000000..281bb65
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_GNUPLOT
+	bool "gnuplot"
+	help
+	  A portable command-line driven graphing utility.
+
+	  http://www.gnuplot.info/
+

package/gnuplot/gnuplot.mk new file +24 -0

new file mode 100644
index 0000000..2f05624
@@ -0,0 +1,24 @@
+#############################################################
+#
+# gnuplot
+#
+#############################################################
+GNUPLOT_VERSION = 4.6.0
+GNUPLOT_SOURCE = gnuplot-$(GNUPLOT_VERSION).tar.gz
+GNUPLOT_SITE = http://superb-dca2.dl.sourceforge.net/project/gnuplot/gnuplot/$(GNUPLOT_VERSION)
+GNUPLOT_INSTALL_STAGING = YES
+GNUPLOT_INSTALL_TARGET = YES
+GNUPLOT_CONF_OPT = --without-x \
+		--disable-raise-console \
+		--disable-mouse \
+	        --without-tutorial \
+		--without-demo --disable-demo \
+	        --without-row-help \
+		--disable-history-file \
+	        --without-lisp-files \
+	        --disable-wxwidgets \
+	        --without-lua \
+		--without-latex \
+	        --without-cairo
+
+$(eval $(autotools-package))

package/gnuplot/gnuplot.patch new file +26 -0

new file mode 100644
index 0000000..7053a46
@@ -0,0 +1,26 @@
+diff --git a/Makefile.am b/Makefile.am
+index bc0f2b2..5c00fe5 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,7 +1,7 @@
+ ## Process this file with automake to produce Makefile.in -*-Makefile-*-
+ AUTOMAKE_OPTIONS = foreign 1.2h
+ 
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share
+ 
+ EXTRA_DIST = BUGS CodeStyle Copyright FAQ.pdf GNUmakefile INSTALL INSTALL.gnu \
+ Makefile.maint PATCHLEVEL PGPKEYS PORTING README README.1ST \
+diff --git a/Makefile.in b/Makefile.in
+index 71118bc..86df133 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -250,7 +250,7 @@ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+ AUTOMAKE_OPTIONS = foreign 1.2h
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share
+ EXTRA_DIST = BUGS CodeStyle Copyright FAQ.pdf GNUmakefile INSTALL INSTALL.gnu \
+ Makefile.maint PATCHLEVEL PGPKEYS PORTING README README.1ST \
+ VERSION configure.vms pm3d win

Signature · 1 line

1.7.10.4

Thomas Petazzoni

2013-01-04 15:15 UTC #1 lore raw

PATCH 1/1 gnuplot : new package

Dear Anthony Viallard,

Thanks for submitting this package. It looks almost good.

Quoted 15 lines · Anthony Viallard

Signed-off-by Anthony Viallard <[email protected]>

---
 package/Config.in             |    1 +
 package/gnuplot/Config.in     |    7 +++++++
 package/gnuplot/gnuplot.mk    |   13 +++++++++++++
 package/gnuplot/gnuplot.patch |   26 ++++++++++++++++++++++++++
 4 files changed, 57 insertions(+), 0 deletion(-)
 create mode 100644 package/gnuplot/Config.in
 create mode 100644 package/gnuplot/gnuplot.mk
 create mode 100644 package/gnuplot/gnuplot.patch

package/Config.in endif · line 73

Quoted 4 lines

package/Config.in +1 -0

@@ -70,6 +70,7 @@ endif
 source "toolchain/gcc/Config.in.2"
 source "package/gettext/Config.in"
 source "package/gmp/Config.in"
+source "package/gnuplot/Config.in"

Hum, why in "Development tools" ? Maybe Graphic libraries and applications would make more sense here ?

package/Config.in endif

Quoted 5 lines

package/Config.in +5 -0

+GNUPLOT_VERSION = 4.6.0
+GNUPLOT_SOURCE = gnuplot-$(GNUPLOT_VERSION).tar.gz
+GNUPLOT_SITE = http://superb-dca2.dl.sourceforge.net/project/gnuplot/gnuplot/$(GNUPLOT_VERSION)
+GNUPLOT_INSTALL_STAGING = YES
+GNUPLOT_INSTALL_TARGET = YES

This line is not needed.

Please also add the GNUPLOT_LICENSE and GNUPLOT_LICENSE_FILES variables.

package/gnuplot/gnuplot.patch

Quoted 20 lines

package/Config.in +14 -0

+GNUPLOT_CONF_OPT = --without-x \
+		--disable-raise-console \
+		--disable-mouse \
+	        --without-tutorial \
+		--without-demo --disable-demo \
+	        --without-row-help \
+		--disable-history-file \
+	        --without-lisp-files \
+	        --disable-wxwidgets \
+	        --without-lua \
+		--without-latex \
+	        --without-cairo
+
+$(eval $(autotools-package))

package/gnuplot/gnuplot.patch new file +0 -0

new file mode 100644
index 0000000..7053a46
@@ -0,0 +1,26 @@

All patches in Buildroot should have a description and a Signed-off-by line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.

package/gnuplot/gnuplot.patch line 10

Quoted 10 lines

package/gnuplot/gnuplot.patch new file +10 -0

+diff --git a/Makefile.am b/Makefile.am
+index bc0f2b2..5c00fe5 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,7 +1,7 @@
+ ## Process this file with automake to produce Makefile.in -*-Makefile-*-
+ AUTOMAKE_OPTIONS = foreign 1.2h
+ 
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share

Could you cook a patch for upstream gnuplot that adds a --{enable,disable}-demo to enable/disable the build of the demos, so that ultimately we can drop your patch? This is not mandatory to get your package in Buildroot, but would be nice to have.

Thanks,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Viallard Anthony

author

2013-01-04 15:38 UTC #2 lore raw

PATCH 1/1 gnuplot : new package

Quoted 2 lines · Thomas Petazzoni

Hum, why in "Development tools" ? Maybe Graphic libraries and applications would make more sense here ?

Doh ! Yes, indeed. Under "Graphic application", it's better.

Quoted 8 lines

package/gnuplot/gnuplot.mk line 10
Quoted 5 lines
package/gnuplot/gnuplot.mk new file +5 -0
+GNUPLOT_VERSION = 4.6.0
+GNUPLOT_SOURCE = gnuplot-$(GNUPLOT_VERSION).tar.gz
+GNUPLOT_SITE = http://superb-dca2.dl.sourceforge.net/project/gnuplot/gnuplot/$(GNUPLOT_VERSION)
+GNUPLOT_INSTALL_STAGING = YES
+GNUPLOT_INSTALL_TARGET = YES
This line is not needed.
Please also add the GNUPLOT_LICENSE and GNUPLOT_LICENSE_FILES variables.

Ok.

Quoted 16 lines

package/gnuplot/gnuplot.mk new file +14 -0

+GNUPLOT_CONF_OPT = --without-x \
+		--disable-raise-console \
+		--disable-mouse \
+	        --without-tutorial \
+		--without-demo --disable-demo \
+	        --without-row-help \
+		--disable-history-file \
+	        --without-lisp-files \
+	        --disable-wxwidgets \
+	        --without-lua \
+		--without-latex \
+	        --without-cairo
+
+$(eval $(autotools-package))

package/gnuplot/gnuplot.patch +0 -0

Quoted 9 lines

package/gnuplot/gnuplot.patch
Quoted 5 lines
new file mode 100644
index 0000000..7053a46
package/gnuplot/gnuplot.patch new file +0 -0
@@ -0,0 +1,26 @@
All patches in Buildroot should have a description and a Signed-off-by line. See
http://buildroot.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.

Doh. I forgot the description. I use dvorak keyboard for few days now. I'm looking for laziness.

Quoted 6 lines

package/gnuplot/gnuplot.patch new file +6 -0

+diff --git a/Makefile.am b/Makefile.am
+index bc0f2b2..5c00fe5 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,7 +1,7 @@
+ ## Process this file with automake to produce Makefile.in -*-Makefile-*-

Quoted 8 lines

package/gnuplot/gnuplot.patch line 10
Quoted 4 lines
package/gnuplot/gnuplot.patch new file +4 -0
+ AUTOMAKE_OPTIONS = foreign 1.2h
+
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share
Could you cook a patch for upstream gnuplot that adds a --{enable,disable}-demo to enable/disable the build of the demos, so that ultimately we can drop your patch? This is not mandatory to get your package in Buildroot, but would be nice to have.

Ok, i do that.

Thanks,

avd.

Stephan Hoffmann

2013-01-04 15:32 UTC #3 lore raw

PATCH 1/1 gnuplot : new package

In reply to Anthony Viallard

Hello Anthony,

Am 04.01.2013 15:53, schrieb Anthony Viallard:

Quoted 41 lines

Signed-off-by Anthony Viallard <[email protected]>

---
 package/Config.in             |    1 +
 package/gnuplot/Config.in     |    7 +++++++
 package/gnuplot/gnuplot.mk    |   13 +++++++++++++
 package/gnuplot/gnuplot.patch |   26 ++++++++++++++++++++++++++
 4 files changed, 57 insertions(+), 0 deletion(-)
 create mode 100644 package/gnuplot/Config.in
 create mode 100644 package/gnuplot/gnuplot.mk
 create mode 100644 package/gnuplot/gnuplot.patch

package/Config.in +1 -0

@@ -70,6 +70,7 @@ endif
 source "toolchain/gcc/Config.in.2"
 source "package/gettext/Config.in"
 source "package/gmp/Config.in"
+source "package/gnuplot/Config.in"
 source "package/gperf/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/grep/Config.in"

package/gnuplot/Config.in new file +7 -0

new file mode 100644
index 0000000..281bb65
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_GNUPLOT
+	bool "gnuplot"
+	help
+	  A portable command-line driven graphing utility.
+
+	  http://www.gnuplot.info/
+

package/gnuplot/gnuplot.mk new file +1 -0

new file mode 100644
index 0000000..2f05624
@@ -0,0 +1,24 @@
+#############################################################

package/gnuplot/gnuplot.mk line 11

Quoted 10 lines

package/gnuplot/gnuplot.mk new file +10 -0

+#
+# gnuplot
+#
+#############################################################
+GNUPLOT_VERSION = 4.6.0
+GNUPLOT_SOURCE = gnuplot-$(GNUPLOT_VERSION).tar.gz
+GNUPLOT_SITE = http://superb-dca2.dl.sourceforge.net/project/gnuplot/gnuplot/$(GNUPLOT_VERSION)
+GNUPLOT_INSTALL_STAGING = YES
+GNUPLOT_INSTALL_TARGET = YES
+GNUPLOT_CONF_OPT = --without-x \

is there a special reason for this? Why not build with x, when X11 is configured in buildroot?

Kind regards

Stephan

Quoted 45 lines

package/gnuplot/gnuplot.mk new file +13 -0

+		--disable-raise-console \
+		--disable-mouse \
+	        --without-tutorial \
+		--without-demo --disable-demo \
+	        --without-row-help \
+		--disable-history-file \
+	        --without-lisp-files \
+	        --disable-wxwidgets \
+	        --without-lua \
+		--without-latex \
+	        --without-cairo
+
+$(eval $(autotools-package))

package/gnuplot/gnuplot.patch new file +26 -0

new file mode 100644
index 0000000..7053a46
@@ -0,0 +1,26 @@
+diff --git a/Makefile.am b/Makefile.am
+index bc0f2b2..5c00fe5 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,7 +1,7 @@
+ ## Process this file with automake to produce Makefile.in -*-Makefile-*-
+ AUTOMAKE_OPTIONS = foreign 1.2h
+ 
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share
+ 
+ EXTRA_DIST = BUGS CodeStyle Copyright FAQ.pdf GNUmakefile INSTALL INSTALL.gnu \
+ Makefile.maint PATCHLEVEL PGPKEYS PORTING README README.1ST \
+diff --git a/Makefile.in b/Makefile.in
+index 71118bc..86df133 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -250,7 +250,7 @@ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+ AUTOMAKE_OPTIONS = foreign 1.2h
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share
+ EXTRA_DIST = BUGS CodeStyle Copyright FAQ.pdf GNUmakefile INSTALL INSTALL.gnu \
+ Makefile.maint PATCHLEVEL PGPKEYS PORTING README README.1ST \
+ VERSION configure.vms pm3d win

Signature · 4 lines

reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de

Thomas Petazzoni

2013-01-04 16:26 UTC #4 lore raw

PATCH 1/1 gnuplot : new package

Dear Stephan Hoffmann,

Quoted 3 lines · Stephan Hoffmann

Quoted 1 line
+GNUPLOT_CONF_OPT = --without-x \
is there a special reason for this? Why not build with x, when X11 is configured in buildroot?

I guess because Anthony didn't need X support. It is not because a given software component can potentially support feature Y or Z that we require the package submitter to support all those features Y or Z. It would put way too much load on the initial package submitter.

Instead, we prefer having small packages that only support the features that have been tested by the submitter, and that carefully disables all the unsupported features. And then, as features are needed by other people, they can submit additional patches to make those additional features work.

Anthony: a gnuplot patch without the X support is perfectly acceptable.

Best regards,

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Stephan Hoffmann

2013-01-04 17:44 UTC #5 lore raw

PATCH 1/1 gnuplot : new package

Am 04.01.2013 17:26, schrieb Thomas Petazzoni:

Quoted 11 lines

Dear Stephan Hoffmann,
Quoted 3 lines · Stephan Hoffmann
Quoted 1 line
+GNUPLOT_CONF_OPT = --without-x \
is there a special reason for this? Why not build with x, when X11 is configured in buildroot?
I guess because Anthony didn't need X support. It is not because a given software component can potentially support feature Y or Z that we require the package submitter to support all those features Y or Z. It would put way too much load on the initial package submitter.

Hello Thomas,

maybe my question was not clear enough. I just wanted to know if this option is really required.

Quoted 5 lines

Instead, we prefer having small packages that only support the features that have been tested by the submitter, and that carefully disables all the unsupported features. And then, as features are needed by other people, they can submit additional patches to make those additional features work.

O.K., I didn't realize that even when configure finds out that no X11 is present --without-x is needed for this reason.

For the records: I made a quick test without X11 and it fails to compile without this option.

Quoted 1 line

Anthony: a gnuplot patch without the X support is perfectly acceptable.

Of course, this is my opinion, too! I really like seeing it included!

Kind regards

Stephan

Quoted 4 lines

Best regards,
Thomas

Signature · 4 lines

reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de

Thomas Petazzoni

2013-01-04 18:02 UTC #6 lore raw

PATCH 1/1 gnuplot : new package

Dear Stephan Hoffmann,

Quoted 7 lines · Stephan Hoffmann

maybe my question was not clear enough. I just wanted to know if this option is really required.
Quoted 5 lines
Instead, we prefer having small packages that only support the features that have been tested by the submitter, and that carefully disables all the unsupported features. And then, as features are needed by other people, they can submit additional patches to make those additional features work.

Quoted 5 lines

O.K., I didn't realize that even when configure finds out that no X11 is present --without-x is needed for this reason.
For the records: I made a quick test without X11 and it fails to compile without this option.

Generally, it's quite good to have explicit --disable-<feature> or --without-<feature>. It avoids the configure script from potentially mis-detecting host libraries. Like gnuplot configure script could say "hey, your build machine has X, let's build X support". Passing --without-x avoids that.

Thomas

Signature · 4 lines

Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Stephan Hoffmann

2013-01-04 18:01 UTC #7 lore raw

PATCH 1/1 gnuplot : new package

In reply to Anthony Viallard

Am 04.01.2013 15:53, schrieb Anthony Viallard:

Quoted 1 line

Signed-off-by Anthony Viallard <[email protected]>

Tested-by Stephan Hoffmann <[email protected]>

Quoted 1 line

---

Built and made simple functional test on beaglebone

Quoted 94 lines

 package/Config.in             |    1 +
 package/gnuplot/Config.in     |    7 +++++++
 package/gnuplot/gnuplot.mk    |   13 +++++++++++++
 package/gnuplot/gnuplot.patch |   26 ++++++++++++++++++++++++++
 4 files changed, 57 insertions(+), 0 deletion(-)
 create mode 100644 package/gnuplot/Config.in
 create mode 100644 package/gnuplot/gnuplot.mk
 create mode 100644 package/gnuplot/gnuplot.patch

package/Config.in +1 -0

@@ -70,6 +70,7 @@ endif
 source "toolchain/gcc/Config.in.2"
 source "package/gettext/Config.in"
 source "package/gmp/Config.in"
+source "package/gnuplot/Config.in"
 source "package/gperf/Config.in"
 if BR2_PACKAGE_BUSYBOX_SHOW_OTHERS
 source "package/grep/Config.in"

package/gnuplot/Config.in new file +7 -0

new file mode 100644
index 0000000..281bb65
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_GNUPLOT
+	bool "gnuplot"
+	help
+	  A portable command-line driven graphing utility.
+
+	  http://www.gnuplot.info/
+

package/gnuplot/gnuplot.mk new file +24 -0

new file mode 100644
index 0000000..2f05624
@@ -0,0 +1,24 @@
+#############################################################
+#
+# gnuplot
+#
+#############################################################
+GNUPLOT_VERSION = 4.6.0
+GNUPLOT_SOURCE = gnuplot-$(GNUPLOT_VERSION).tar.gz
+GNUPLOT_SITE = http://superb-dca2.dl.sourceforge.net/project/gnuplot/gnuplot/$(GNUPLOT_VERSION)
+GNUPLOT_INSTALL_STAGING = YES
+GNUPLOT_INSTALL_TARGET = YES
+GNUPLOT_CONF_OPT = --without-x \
+		--disable-raise-console \
+		--disable-mouse \
+	        --without-tutorial \
+		--without-demo --disable-demo \
+	        --without-row-help \
+		--disable-history-file \
+	        --without-lisp-files \
+	        --disable-wxwidgets \
+	        --without-lua \
+		--without-latex \
+	        --without-cairo
+
+$(eval $(autotools-package))

package/gnuplot/gnuplot.patch new file +26 -0

new file mode 100644
index 0000000..7053a46
@@ -0,0 +1,26 @@
+diff --git a/Makefile.am b/Makefile.am
+index bc0f2b2..5c00fe5 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -1,7 +1,7 @@
+ ## Process this file with automake to produce Makefile.in -*-Makefile-*-
+ AUTOMAKE_OPTIONS = foreign 1.2h
+ 
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share
+ 
+ EXTRA_DIST = BUGS CodeStyle Copyright FAQ.pdf GNUmakefile INSTALL INSTALL.gnu \
+ Makefile.maint PATCHLEVEL PGPKEYS PORTING README README.1ST \
+diff --git a/Makefile.in b/Makefile.in
+index 71118bc..86df133 100644
+--- a/Makefile.in
++++ b/Makefile.in
+@@ -250,7 +250,7 @@ top_build_prefix = @top_build_prefix@
+ top_builddir = @top_builddir@
+ top_srcdir = @top_srcdir@
+ AUTOMAKE_OPTIONS = foreign 1.2h
+-SUBDIRS = config m4 term src docs $(LISPDIR) man demo tutorial share
++SUBDIRS = config m4 term src $(LISPDIR) man tutorial share
+ EXTRA_DIST = BUGS CodeStyle Copyright FAQ.pdf GNUmakefile INSTALL INSTALL.gnu \
+ Makefile.maint PATCHLEVEL PGPKEYS PORTING README README.1ST \
+ VERSION configure.vms pm3d win

Signature · 4 lines

reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de