alsaconf and bash
Hi all,
in alsa-utils_1.0.25.bb, I see this comment:
# We omit alsaconf, because
# a) this is a bash script
# b) it creates config files not suitable for OE-based distros
Trying out on master, I get a do_rootfs error because bash is not a rundep of alsa-utils, and there is nothing in the alsa-utils recipe that actually does the above mentioned removal of the alsaconf script. Looking in the git log, I only see that the comment has suddenly appeared in an older alsa-utils recipe and has been carried along since with every update to the recipe, and not left over there as an artifact of some older commit as I expected. Can anyone shed some light on this?
Thanks,
Florin
Quoted 6 lines · Florin Sarbu
in alsa-utils_1.0.25.bb, I see this comment:
# We omit alsaconf, because
# a) this is a bash script
# b) it creates config files not suitable for OE-based distros
Quoted 9 lines
Trying out on master, I get a
do_rootfserror because bash is not a rundep of alsa-utils, and there is nothing in the alsa-utils recipe that actually does the above mentioned removal of the alsaconf script. Looking in the git log, I only see that the comment has suddenly appeared in an older alsa-utils recipe and has been carried along since with every update to the recipe, and not left over there as an artifact of some older commit as I expected.
Can anyone shed some light on this?
From some quick git log -S commands in the old openembedded classic repository, it seems to have originated
with 7653e980f66b4bd147df308f9b04d6b197382d6a from 2005, and the line below the comment was 'FILES_${PN} = ""', so presumably that was what left it out — none of the files patterns matched it.
Signature · 1 line
Christopher Larson
Quoted 20 lines · Chris Larson
On Mon, Jan 7, 2013 at 2:36 PM, Florin Sarbu <[email protected] <mailto:[email protected]>> wrote:
in alsa-utils_1.0.25.bb <http://alsa-utils_1.0.25.bb>, I see this comment:
# We omit alsaconf, because
# a) this is a bash script
# b) it creates config files not suitable for OE-based distrosTrying out on master, I get a
do_rootfserror because bash is not a rundep of alsa-utils, and there is nothing in the alsa-utils recipe that actually does the above mentioned removal of the alsaconf script. Looking in the git log, I only see that the comment has suddenly appeared in an older alsa-utils recipe and has been carried along since with every update to the recipe, and not left over there as an artifact of some older commit as I expected. Can anyone shed some light on this?
Quoted 1 line
From some quick git log -S commands in the old openembedded classic repository, it seems to have originated with
7653e980f66b4bd147df308f9b04d6b197382d6afrom 2005, and the line below the comment was 'FILES_${PN} = ""', so presumably that was what left it out — none of the files patterns matched it.
Okay, so it seems that the comment actually said at that time that the alsa-utils generated rpm won't contain alsaconf. And bellow, this bash script gets into the alsa-utils-alsaconf rpm. Unfortunately, even though there is this separation, the alsa-utils rpm depends on the alsa-utils-alsaconf rpm so it's pretty much the same thing as do_rootfs is concerned. (missing bash dependency). How would you guys see this resolved upstream? Add bash as a dep, remove alsa-utils-alsaconf as a dep or alsa-utils (as the comment says the script is not suitable for OE-based distros) or check the alsaconf script for bashisms and fix if any and make alsa-utils rely on a busybox shell interpreter if possible (with the modification of the !/bin/bash shabang from the alsaconf script to /bin/sh)?
Florin
Quoted 2 lines
Signature · 1 line
Christopher Larson
Would you guys suggest we add bash as a dependency for alsa-utils?
Quoted 36 lines · Florin Sarbu
Quoted 21 lines · Chris Larson
On Mon, Jan 7, 2013 at 2:36 PM, Florin Sarbu <[email protected] <mailto:[email protected]>> wrote:
in alsa-utils_1.0.25.bb <http://alsa-utils_1.0.25.bb>, I see this comment:
# We omit alsaconf, because
# a) this is a bash script
# b) it creates config files not suitable for OE-based distrosTrying out on master, I get a
do_rootfserror because bash is not a rundep of alsa-utils, and there is nothing in the alsa-utils recipe that actually does the above mentioned removal of the alsaconf script. Looking in the git log, I only see that the comment has suddenly appeared in an older alsa-utils recipe and has been carried along since with every update to the recipe, and not left over there as an artifact of some older commit as I expected.
Can anyone shed some light on this?Quoted 1 line
From some quick git log -S commands in the old openembedded classic repository, it seems to have originated with
7653e980f66b4bd147df308f9b04d6b197382d6afrom 2005, and the line below the comment was 'FILES_${PN} = ""', so presumably that was what left it out --- none of the files patterns matched it.Okay, so it seems that the comment actually said at that time that the alsa-utils generated rpm won't contain alsaconf. And bellow, this bash script gets into the alsa-utils-alsaconf rpm. Unfortunately, even though there is this separation, the alsa-utils rpm depends on the alsa-utils-alsaconf rpm so it's pretty much the same thing as
do_rootfsis concerned. (missing bash dependency). How would you guys see this resolved upstream? Add bash as a dep, remove alsa-utils-alsaconf as a dep or alsa-utils (as the comment says the script is not suitable for OE-based distros) or check the alsaconf script for bashisms and fix if any and make alsa-utils rely on a busybox shell interpreter if possible (with the modification of the !/bin/bash shabang from the alsaconf script to/bin/sh)?Florin
Quoted 2 lines
Signature · 1 line
Christopher Larson_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
Quoted 2 lines · Florin Sarbu
Would you guys suggest we add bash as a dependency for alsa-utils?
Alsaconf is a bash script - obviously add a RDEPENDS to bash.
ag
But on the other hand, if the comment says the script is not suited for OE-core, then why have the alsa-utils rpm depend on the alsaconf rpm?
Florin
Quoted 8 lines · Andrei Gherzan
On Tue, Jan 8, 2013 at 4:15 PM, Florin Sarbu <[email protected] <mailto:[email protected]>> wrote:
Would you guys suggest we add bash as a dependency for alsa-utils?
Alsaconf is a bash script - obviously add a RDEPENDS to bash.
ag