meta-fsl-ppc master: inherit image_types_uboot

PATCH In review Bob Cochran 3 participants 6 messages Jan 7, 2013 – Jan 9, 2013

Share & tools

McClintock Matthew-B29882

2013-01-07 20:18 UTC #1 lore raw

Quoted 5 lines · Bob Cochran

Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a non existent file (u-boot rootfs isn't actually built).
As commented by Matthew McClintock on 1/2/13, this had been handled previously using a setup script.

You can remove this bit, or place it below the --- line

images/fsl-image-minimal.bb

Quoted 7 lines

Signed-off-by Robert Cochran <[email protected]>
---
images/fsl-image-minimal.bb +0 -0
index 1732585..64fa096 100644

$ git ls-tree --name-only -r HEAD | grep fsl-image
images/fsl-image-lsb-sdk.bb
images/fsl-image-minimal.bb

I think the other image needs this too.

-M

Quoted 15 lines

images/fsl-image-minimal.bb +1 -2
@@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
 
 LICENSE = "MIT"
 
-inherit core-image
+inherit core-image image_types_uboot
 
 IMAGE_ROOTFS_SIZE = "8192"
 
--
1.7.9.5
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

Bob Cochran

author

2013-01-08 13:37 UTC #2 lore raw

Quoted 8 lines · On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:

Quoted 5 lines · Bob Cochran
Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a non existent file (u-boot rootfs isn't actually built).
As commented by Matthew McClintock on 1/2/13, this had been handled previously using a setup script.
You can remove this bit, or place it below the --- line

Matthew,

I'll resubmit this patch & the one Otavio commented on (image_types_uboot). I also want to send up a patch to do a rename: recipes-append/libxml/libxml2_2.8.0.bbappend -> recipes-append/libxml/libxml2_2.9.0.bbappend

Should I just send up a new patch set today with the three patches included, or do you want me to address each individually?

Thanks,

Bob

Quoted 33 lines

images/fsl-image-minimal.bb
Quoted 8 lines
Signed-off-by Robert Cochran <[email protected]>
---
images/fsl-image-minimal.bb +0 -0
index 1732585..64fa096 100644
$ git ls-tree --name-only -r HEAD | grep fsl-image
images/fsl-image-lsb-sdk.bb
images/fsl-image-minimal.bb
I think the other image needs this too.
-M
Quoted 15 lines
images/fsl-image-minimal.bb +1 -2
@@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
 
  LICENSE = "MIT"
 
-inherit core-image
+inherit core-image image_types_uboot
 
  IMAGE_ROOTFS_SIZE = "8192"
 
--
1.7.9.5
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

McClintock Matthew-B29882

2013-01-08 17:28 UTC #3 lore raw

Quoted 16 lines · Bob Cochran

Quoted 11 lines · On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:
Quoted 6 lines · Bob Cochran
Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a non existent file (u-boot rootfs isn't actually built).
As commented by Matthew McClintock on 1/2/13, this had been handled previously using a setup script.
You can remove this bit, or place it below the --- line
Matthew,

Quoted 7 lines

I'll resubmit this patch & the one Otavio commented on (image_types_uboot). I also want to send up a patch to do a rename:
recipes-append/libxml/libxml2_2.8.0.bbappend -> recipes-append/libxml/libxml2_2.9.0.bbappend
Should I just send up a new patch set today with the three patches included, or do you want me to address each individually?

libxml fix is already in master-next
(http://git.yoctoproject.org/cgit/cgit.cgi/meta-fsl-ppc/commit/?h=master-next&id=3f4e3e1d8f8ed719fc59be3cf0aadefb19f934bb)

Just base your patch off master-next. Feel free to bring up / fix any issues you find on that branch.

-M

Quoted 45 lines

Thanks,
Bob
Quoted 35 lines
images/fsl-image-minimal.bb
Quoted 8 lines
Signed-off-by Robert Cochran <[email protected]>
---
images/fsl-image-minimal.bb +0 -0
index 1732585..64fa096 100644
$ git ls-tree --name-only -r HEAD | grep fsl-image
images/fsl-image-lsb-sdk.bb
images/fsl-image-minimal.bb
I think the other image needs this too.
-M
Quoted 15 lines
images/fsl-image-minimal.bb +1 -2
@@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
 
  LICENSE = "MIT"
 
-inherit core-image
+inherit core-image image_types_uboot
 
  IMAGE_ROOTFS_SIZE = "8192"
 
--
1.7.9.5
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

Luo Zhenhua-B19537

2013-01-09 03:47 UTC #4 lore raw

In reply to Bob Cochran

Bob,

"libxml2_<PV>.bbappend is not needed anymore, the change has been merged into poky.

http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=b7a7e6eebac711642944295ad62c996d6a75891c

Best Regards,

Zhenhua

Quoted 73 lines

-----Original Message-----
From: [email protected] [mailto:meta-freescale- [email protected]] On Behalf Of Bob Cochran
Sent: Tuesday, January 08, 2013 9:37 PM
To: McClintock Matthew-B29882
Cc: [email protected]
Subject: Re: [meta-freescale] [PATCH] meta-fsl-ppc master: inherit image_types_uboot
Quoted 1 line · On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:
On Mon, Jan 7, 2013 at 8:45 AM, Bob Cochran <[email protected]>
Quoted 7 lines · wrote:
Quoted 5 lines
Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a non existent file (u-boot rootfs isn't actually built).
As commented by Matthew McClintock on 1/2/13, this had been handled previously using a setup script.
You can remove this bit, or place it below the --- line
Matthew,
I'll resubmit this patch & the one Otavio commented on (image_types_uboot). I also want to send up a patch to do a rename:
recipes-append/libxml/libxml2_2.8.0.bbappend -> recipes- append/libxml/libxml2_2.9.0.bbappend
Should I just send up a new patch set today with the three patches included, or do you want me to address each individually?
Thanks,
Bob
Quoted 23 lines
images/fsl-image-minimal.bb
Quoted 8 lines
Signed-off-by Robert Cochran <[email protected]>
---
(quoted diff) +0 -0
b/images/fsl-image-minimal.bb index 1732585..64fa096 100644
images/fsl-image-minimal.bb +0 -0
$ git ls-tree --name-only -r HEAD | grep fsl-image
images/fsl-image-lsb-sdk.bb images/fsl-image-minimal.bb
I think the other image needs this too.
-M
Quoted 7 lines
images/fsl-image-minimal.bb +1 -1
@@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
 
  LICENSE = "MIT"
 
-inherit core-image
+inherit core-image image_types_uboot
 
Quoted 9 lines
Quoted 8 lines
images/fsl-image-minimal.bb +0 -1
  IMAGE_ROOTFS_SIZE = "8192"
 
--
1.7.9.5
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale

McClintock Matthew-B29882

2013-01-09 04:10 UTC #5 lore raw

Quoted 5 lines · On Tue, Jan 8, 2013 at 9:47 PM, Luo Zhenhua-B19537 <[email protected]> wrote:

Bob,
"libxml2_<PV>.bbappend is not needed anymore, the change has been merged into poky.
http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=b7a7e6eebac711642944295ad62c996d6a75891c

Then we need a patch to drop the bbappends entirely.

-M

Quoted 81 lines

Best Regards,
Zhenhua
Quoted 73 lines
-----Original Message-----
From: [email protected] [mailto:meta-freescale- [email protected]] On Behalf Of Bob Cochran
Sent: Tuesday, January 08, 2013 9:37 PM
To: McClintock Matthew-B29882
Cc: [email protected]
Subject: Re: [meta-freescale] [PATCH] meta-fsl-ppc master: inherit image_types_uboot
Quoted 1 line · On 01/07/2013 03:17 PM, McClintock Matthew-B29882 wrote:
On Mon, Jan 7, 2013 at 8:45 AM, Bob Cochran <[email protected]>
Quoted 7 lines · wrote:
Quoted 5 lines
Without this patch, fsl-image-minimal-<machine>.ext2.gz.u-boot links to a non existent file (u-boot rootfs isn't actually built).
As commented by Matthew McClintock on 1/2/13, this had been handled previously using a setup script.
You can remove this bit, or place it below the --- line
Matthew,
I'll resubmit this patch & the one Otavio commented on (image_types_uboot). I also want to send up a patch to do a rename:
recipes-append/libxml/libxml2_2.8.0.bbappend -> recipes- append/libxml/libxml2_2.9.0.bbappend
Should I just send up a new patch set today with the three patches included, or do you want me to address each individually?
Thanks,
Bob
Quoted 23 lines
images/fsl-image-minimal.bb
Quoted 8 lines
Signed-off-by Robert Cochran <[email protected]>
---
(quoted diff) +0 -0
b/images/fsl-image-minimal.bb index 1732585..64fa096 100644
images/fsl-image-minimal.bb +0 -0
$ git ls-tree --name-only -r HEAD | grep fsl-image
images/fsl-image-lsb-sdk.bb images/fsl-image-minimal.bb
I think the other image needs this too.
-M
Quoted 7 lines
images/fsl-image-minimal.bb +1 -1
@@ -6,7 +6,7 @@ IMAGE_LINGUAS = " "
 
  LICENSE = "MIT"
 
-inherit core-image
+inherit core-image image_types_uboot
 
Quoted 9 lines
Quoted 8 lines
images/fsl-image-minimal.bb +0 -1
  IMAGE_ROOTFS_SIZE = "8192"
 
--
1.7.9.5
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale