Skip to contentSkip to conversation

video:cache:fix: Enable dcache flush at LCD subsystem for Exynos based boards

PATCH Superseded Lukasz Majewski 2 participants 4 messages Jan 8, 2013 – Jan 9, 2013

Subsystems (2)
Framebuffer layer Arm Samsung Exynos
lore
Share & tools
lore

Lukasz Majewski

author
#0 lore raw

PATCH 1/1 video:cache:fix: Enable dcache flush at LCD subsystem for Exynos based boards

lcd_set_flush_dcache(1) function is called from exynos_fb.c (exynos_lcd_init()) file to enable lcd_sync() function.

Tested-at: TRATS (Exynos 4210)

Tested-by Lukasz Majewski <[email protected]>
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Minkyu Kang <[email protected]>
---
 drivers/video/exynos_fb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/video/exynos_fb.c +2 -0
index d9a3f9a..17e1069 100644
@@ -63,6 +63,8 @@ static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 static void exynos_lcd_init(vidinfo_t *vid)
 {
 	exynos_fimd_lcd_init(vid);
+	/* Enable flushing after LCD writes if requested */
+	lcd_set_flush_dcache(1);
 }
 
 static void draw_logo(void)
Signature · 1 line
1.7.2.3
#1 lore raw

PATCH 1/1 video:cache:fix: Enable dcache flush at LCD subsystem for Exynos based boards

Quoted 17 lines · Lukasz Majewski

lcd_set_flush_dcache(1) function is called from exynos_fb.c (exynos_lcd_init()) file to enable lcd_sync() function.

Tested-at: TRATS (Exynos 4210)

Tested-by Lukasz Majewski <[email protected]>
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Minkyu Kang <[email protected]>
---
 drivers/video/exynos_fb.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/video/exynos_fb.c +0 -0
index d9a3f9a..17e1069 100644

drivers/video/exynos_fb.c static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid) · line 65

Quoted 3 lines
drivers/video/exynos_fb.c +0 -0
@@ -63,6 +63,8 @@ static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 static void exynos_lcd_init(vidinfo_t *vid)
 {
 	exynos_fimd_lcd_init(vid);

please add blank line here.

drivers/video/exynos_fb.c static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid) · line 70

Quoted 6 lines
drivers/video/exynos_fb.c +2 -0
+	/* Enable flushing after LCD writes if requested */
+	lcd_set_flush_dcache(1);
 }
 
 static void draw_logo(void)

Thanks.
Minkyu Kang.

author
#2 lore raw

PATCH v2 1/1 video:cache:fix: Enable dcache flush at LCD subsystem for Exynos based boards

lcd_set_flush_dcache(1) function is called from exynos_fb.c configuration file to enable lcd_sync function.

Tested-at: TRATS (Exynos 4210)

Tested-by Lukasz Majewski <[email protected]>
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Minkyu Kang <[email protected]>

---
Changes for v2:
- Blank line added

---
 drivers/video/exynos_fb.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/exynos_fb.c +3 -0
index d9a3f9a..aac74a3 100644
@@ -63,6 +63,9 @@ static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 static void exynos_lcd_init(vidinfo_t *vid)
 {
 	exynos_fimd_lcd_init(vid);
+
+	/* Enable flushing after LCD writes if requested */
+	lcd_set_flush_dcache(1);
 }
 
 static void draw_logo(void)
Signature · 1 line
1.7.2.3
#3 lore raw

PATCH v2 1/1 video:cache:fix: Enable dcache flush at LCD subsystem for Exynos based boards

Quoted 21 lines · Lukasz Majewski

lcd_set_flush_dcache(1) function is called from exynos_fb.c configuration file to enable lcd_sync function.

Tested-at: TRATS (Exynos 4210)

Tested-by Lukasz Majewski <[email protected]>
Signed-off-by Lukasz Majewski <[email protected]>
Signed-off-by Kyungmin Park <[email protected]>
Cc Minkyu Kang <[email protected]>

---
Changes for v2:
- Blank line added

---
 drivers/video/exynos_fb.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
drivers/video/exynos_fb.c +0 -0
index d9a3f9a..aac74a3 100644

drivers/video/exynos_fb.c static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid) · line 71

Quoted 9 lines
drivers/video/exynos_fb.c +3 -0
@@ -63,6 +63,9 @@ static void exynos_lcd_init_mem(void *lcdbase, vidinfo_t *vid)
 static void exynos_lcd_init(vidinfo_t *vid)
 {
 	exynos_fimd_lcd_init(vid);
+
+	/* Enable flushing after LCD writes if requested */
+	lcd_set_flush_dcache(1);
 }
 
 static void draw_logo(void)

applied to u-boot-samsung.

Thanks,
Minkyu Kang.