Skip to contentSkip to conversation

tegra30: cardhu: fix UART2 pinmux settings

PATCH New Allen Martin 2 participants 3 messages Jan 9, 2013

lore
Share & tools
lore

Allen Martin

author
#0 lore raw

PATCH 1/1 tegra30: cardhu: fix UART2 pinmux settings

Use UARTB instead of IRDA synonym for cardhu pinmux settings to match tegra30 pinmux tables.

Signed-off-by Allen Martin <[email protected]>
---
 board/nvidia/cardhu/pinmux-config-cardhu.h |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
board/nvidia/cardhu/pinmux-config-cardhu.h +2 -2
index 3162219..8428bba 100644
@@ -176,8 +176,8 @@ static struct pingroup_config tegra3_pinmux_common[] = {
 	LV_PINMUX(VI_D7, SDMMC2, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
 	LV_PINMUX(VI_D10, RSVD1, NORMAL, NORMAL, INPUT, DISABLE, DISABLE),
 	LV_PINMUX(VI_MCLK, VI, UP, NORMAL, INPUT, DISABLE, DISABLE),
-	DEFAULT_PINMUX(UART2_RXD, IRDA, NORMAL, NORMAL, INPUT),
-	DEFAULT_PINMUX(UART2_TXD, IRDA, NORMAL, NORMAL, OUTPUT),
+	DEFAULT_PINMUX(UART2_RXD, UARTB, NORMAL, NORMAL, INPUT),
+	DEFAULT_PINMUX(UART2_TXD, UARTB, NORMAL, NORMAL, OUTPUT),
 	DEFAULT_PINMUX(UART2_RTS_N, UARTB, NORMAL, NORMAL, OUTPUT),
 	DEFAULT_PINMUX(UART2_CTS_N, UARTB, NORMAL, NORMAL, INPUT),
 	DEFAULT_PINMUX(UART3_TXD, UARTC, NORMAL, NORMAL, OUTPUT),
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 tegra30: cardhu: fix UART2 pinmux settings

Quoted 2 lines · Allen Martin

Use UARTB instead of IRDA synonym for cardhu pinmux settings to match tegra30 pinmux tables.

This seems fine as far as it goes, but I'd suggest deleting the IRDA value from the pinmux driver's enum too, so nobody can use it any more.

author
#2 lore raw

PATCH 1/1 tegra30: cardhu: fix UART2 pinmux settings

Quoted 6 lines · Stephen Warren
Quoted 2 lines · Allen Martin

Use UARTB instead of IRDA synonym for cardhu pinmux settings to match tegra30 pinmux tables.

This seems fine as far as it goes, but I'd suggest deleting the IRDA value from the pinmux driver's enum too, so nobody can use it any more.

Good idea, will do.

-Allen

Signature · 1 line
nvpublic