Skip to contentSkip to conversation

powerpc/mpc8xxxx: FSL DDR debugger auto run of stored commands

PATCH New James.Yang at freescale.com 2 participants 3 messages Jan 8, 2013 – Jan 9, 2013 PowerPC

lore
Share & tools
lore

James.Yang at freescale.com

author
#0 lore raw

PATCH v4 1/1 powerpc/mpc8xxxx: FSL DDR debugger auto run of stored commands

From: James Yang <[email protected]>

This patch adds the ability for the FSL DDR interactive debugger to automatically run the sequence of commands stored in the ddr_interactive environment variable. Commands are separated using ';'.

ddr_interactive=compute; edit c0 d0 dimmparms caslat_X 0x3FC0; go

Signed-off-by James Yang <[email protected]>
---
 arch/powerpc/cpu/mpc8xxx/ddr/ddr.h         |    3 +-
 arch/powerpc/cpu/mpc8xxx/ddr/interactive.c |   47 ++++++++++++++++++++++++---
 arch/powerpc/cpu/mpc8xxx/ddr/main.c        |    8 ++--
 3 files changed, 47 insertions(+), 11 deletions(-)
arch/powerpc/cpu/mpc8xxx/ddr/ddr.h +2 -1
index c8b0f91..4dd55fc 100644
@@ -86,7 +86,8 @@ void fsl_ddr_set_lawbar(
 		unsigned int memctl_interleaved,
 		unsigned int ctrl_num);
 
-unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo);
+int fsl_ddr_interactive_env_var_exists(void);
+unsigned long long fsl_ddr_interactive(fsl_ddr_info_t *pinfo, int var_is_set);
 void fsl_ddr_get_spd(generic_spd_eeprom_t *ctrl_dimms_spd,
 			   unsigned int ctrl_num);
arch/powerpc/cpu/mpc8xxx/ddr/interactive.c +41 -6

68 lines not on this page · raw message

arch/powerpc/cpu/mpc8xxx/ddr/main.c +4 -4
index 276894c..7a8636d 100644
@@ -537,10 +537,10 @@ phys_size_t fsl_ddr_sdram(void)
 
 	/* Compute it once normally. */
 #ifdef CONFIG_FSL_DDR_INTERACTIVE
-	if (getenv("ddr_interactive")) {
-		total_memory = fsl_ddr_interactive(&info);
-	} else if (tstc() && (getc() == 'd')) {	/* we got a key press of 'd' */
-		total_memory = fsl_ddr_interactive(&info);
+	if (tstc() && (getc() == 'd')) {	/* we got a key press of 'd' */
+		total_memory = fsl_ddr_interactive(&info, 0);
+	} else if (fsl_ddr_interactive_env_var_exists()) {
+		total_memory = fsl_ddr_interactive(&info, 1);
 	} else
 #endif
 		total_memory = fsl_ddr_compute(&info, STEP_GET_SPD, 0);
Signature · 1 line
1.7.0.4
Applied
#1 lore raw

PATCH v4 1/1 powerpc/mpc8xxxx: FSL DDR debugger auto run of stored commands

Quoted 10 lines · James.Yang at freescale.com

From: James Yang <[email protected]>

This patch adds the ability for the FSL DDR interactive debugger to automatically run the sequence of commands stored in the ddr_interactive environment variable. Commands are separated using ';'.

ddr_interactive=compute; edit c0 d0 dimmparms caslat_X 0x3FC0; go

Signed-off-by James Yang <[email protected]>

---

Applied to master branch, replaced early commit.

York

#2 lore raw

PATCH v4 1/1 powerpc/mpc8xxxx: FSL DDR debugger auto run of stored commands

Quoted 7 lines · York Sun
Quoted 6 lines · James.Yang at freescale.com

From: James Yang <[email protected]>

This patch adds the ability for the FSL DDR interactive debugger to automatically run the sequence of commands stored in the ddr_interactive environment variable. Commands are separated using ';'.

Quoted 8 lines
Quoted 4 lines

ddr_interactive=compute; edit c0 d0 dimmparms caslat_X 0x3FC0; go

Signed-off-by James Yang <[email protected]>

---

Applied to master branch, replaced early commit.

Oops, sorry. Posted to wrong list. I meant to post to an internal list.

York