EXYNOS5: Make all display related code dependent on CONFIG_LCD
PATCH v2 1/2 EXYNOS5: Make all display related code dependent on CONFIG_LCD
u-boot compilation fails for smdk5250 when we deselect CONFIG_LCD from the main config file.
Following error was observed:drivers/video/libvideo.o: In function `exynos_lcd_init':/home/ajay/u-boot-samsung/drivers/video/exynos_fb.c:68: undefined reference to `lcd_set_flush_dcache'
This is because exynos video drivers have dependency on CONFIG_LCD.
---
Changes in V2: Add compilation error message to commit log.
board/samsung/smdk5250/smdk5250.c | 2 ++ include/configs/exynos5250-dt.h | 2 ++ 2 files changed, 4 insertions(+)
board/samsung/smdk5250/smdk5250.c +2 -0
@@ -281,6 +281,7 @@ int board_early_init_f(void) }#endif +#ifdef CONFIG_LCD void cfg_lcd_gpio (void ) { struct exynos5_gpio_part1 *gpio1 =
@@ -374,3 +375,4 @@ void init_panel_info(vidinfo_t *vid) exynos_set_dp_platform_data(&dp_platform_data); } +#endif
include/configs/exynos5250-dt.h +2 -0
@@ -299,10 +299,12 @@/* Display */ #define CONFIG_LCD +#ifdef CONFIG_LCD #define CONFIG_EXYNOS_FB #define CONFIG_EXYNOS_DP #define LCD_XRES 2560#define LCD_YRES 1600#define LCD_BPP LCD_COLOR16 +#endif #endif /* __CONFIG_H */
Signature · 1 line
1.8.0
PATCH v2 2/2 EXYNOS5: Enable console multiplexing in u-boot
We enable console multiplexing and use both serial and LCD for stdout/stderr. Initially, u-boot output console is observed via serial port.
If you also have a DP panel connected onto your SMDK5250 board, you can switch to LCD console by typing "setenv stdout lcd".
You can always switch back to serial using "setenv stdout serial". You can switch error console(stderr) as well, using similar commands.
---
Changes in V2: We use CONFIG_CONSOLE_MUX always. In V1, CONFIG_CONSOLE_MUX
was enabled only when CONFIG_LCD is selected.
include/configs/exynos5250-dt.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
include/configs/exynos5250-dt.h +11 -0
@@ -77,6 +77,17 @@#define CONFIG_BAUDRATE 115200#define EXYNOS5_DEFAULT_UART_OFFSET 0x010000 +/* Console configuration */ +#define CONFIG_CONSOLE_MUX +#define CONFIG_SYS_CONSOLE_IS_IN_ENV +#define EXYNOS_DEVICE_SETTINGS \ + "stdin=serial\0" \ + "stdout=serial,lcd\0" \ + "stderr=serial,lcd\0" + +#define CONFIG_EXTRA_ENV_SETTINGS \ + EXYNOS_DEVICE_SETTINGS +#define TZPC_BASE_OFFSET 0x10000/* SD/MMC configuration */
Signature · 1 line
1.8.0
PATCH v2 2/2 EXYNOS5: Enable console multiplexing in u-boot
Quoted 7 lines · Ajay Kumar
We enable console multiplexing and use both serial and LCD for stdout/stderr. Initially, u-boot output console is observed via serial port.
If you also have a DP panel connected onto your SMDK5250 board, you can switch to LCD console by typing "setenv stdout lcd".
You can always switch back to serial using "setenv stdout serial". You can switch error console(stderr) as well, using similar commands.
Quoted 9 lines
Signed-off-by Ajay Kumar <[email protected]>Acked-by Simon Glass <[email protected]>---
Changes in V2: We useCONFIG_CONSOLE_MUXalways. In V1,CONFIG_CONSOLE_MUX
was enabled only whenCONFIG_LCDis selected.include/configs/exynos5250-dt.h | 11 +++++++++++ 1 file changed, 11 insertions(+)
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
PATCH v2 1/2 EXYNOS5: Make all display related code dependent on CONFIG_LCD
In reply to Ajay KumarQuoted 11 lines · Ajay Kumar
u-boot compilation fails for smdk5250 when we deselect
CONFIG_LCDfrom the main config file.Following error was observed:
drivers/video/libvideo.o: In function `exynos_lcd_init':/home/ajay/u-boot-samsung/drivers/video/exynos_fb.c:68: undefined reference to `lcd_set_flush_dcache'This is because exynos video drivers have dependency on
CONFIG_LCD.Signed-off-by Ajay Kumar <[email protected]>Acked-by Simon Glass <[email protected]>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.