dac960: return success instead of -ENOTTY

PATCH In review Dan Carpenter 2 participants 2 messages Jan 11, 2013

Subsystems (2)

Block layer Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-01-11 06:52 UTC #0 lore raw

PATCH 1/1 dac960: return success instead of -ENOTTY

There is a missing break statement here. This used to return directly but we re-worked it in 2008 to add locking as part of the BKL push down.

Signed-off-by Dan Carpenter <[email protected]>

drivers/block/DAC960.c +1 -0

index 9a13e88..0d3ffc5 100644
@@ -7054,6 +7054,7 @@ static long DAC960_gam_ioctl(struct file *file, unsigned int Request,
 	else
 		ErrorCode =  0;
       }
+      break;
       default:
 	ErrorCode = -ENOTTY;
     }

Jens Axboe

maintainer

2013-01-11 10:27 UTC #1 lore raw

Quoted 2 lines · Dan Carpenter

There is a missing break statement here. This used to return directly but we re-worked it in 2008 to add locking as part of the BKL push down.

Thanks Dan, applied. Must have a big user base...

Signature · 1 line

Jens Axboe