Skip to contentSkip to conversation

tools/libxl: Improve videoram setting

PATCH Superseded Fabio Fantoni 4 participants 9 messages Jan 11, 2013 – Feb 7, 2013

v3 of 6 Superseded Latest is v6 →

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 tools/libxl: Improve videoram setting

tools/libxl: Improve videoram setting

- If videoram setting is less than 8 mb shows error.
- Added videoram setting for qemu upstream with cirrus (added in qemu 1.3).
- Updated xl.cfg man.

---
 docs/man/xl.cfg.pod.5    |   14 +++++---------
 tools/libxl/libxl_dm.c   |    6 ++++++
 tools/libxl/xl_cmdimpl.c |   10 ++++++++--
 3 files changed, 19 insertions(+), 11 deletions(-)
docs/man/xl.cfg.pod.5 +5 -9
index caba162..9c5cdcd 100644
@@ -974,19 +974,15 @@ in the B<VFB_SPEC_STRING> for configuring virtual frame buffer devices
 
 Sets the amount of RAM which the emulated video card will contain,
 which in turn limits the resolutions and bit depths which will be
-available. This option is only available when using the B<stdvga>
-option (see below).
+available.
 The default amount of video ram for stdvga is 8MB which is sufficient
-for e.g. 1600x1200 at 32bpp.
+for e.g. 1600x1200 at 32bpp and videoram option is currently working
+only when using the qemu-xen-traditional device-model.
 
 When using the emulated Cirrus graphics card (B<stdvga=0>)
 the amount of video ram is fixed at 4MB which is sufficient
-for 1024x768 at 32 bpp.
-
-videoram option is currently only available when using the
-qemu-xen-traditional device-model. Upstream qemu-xen device-model
-currently does not support changing the amount of video memory for the
-emulated graphics device.
+for 1024x768 at 32 bpp and videoram option is currently working
+only when using the upstream qemu-xen device-model.
 
 =item B<stdvga=BOOLEAN>
 
tools/libxl/libxl_dm.c +6 -0
index c036dc1..d719130 100644
@@ -430,6 +430,12 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
             break;
         case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
             flexarray_vappend(dm_args, "-vga", "cirrus", NULL);
+            if (b_info->video_memkb) {
+                flexarray_vappend(dm_args, "-global",
+                libxl__sprintf(gc, "vga.vram_size_mb=%d",
+                libxl__sizekb_to_mb(b_info->video_memkb)),
+                NULL);
+            }
             break;
         }
 
tools/libxl/xl_cmdimpl.c +8 -2
index e964bf1..6e11c8d 100644
@@ -831,8 +831,14 @@ static void parse_config_data(const char *config_source,
 
     xlu_cfg_get_defbool(config, "localtime", &b_info->localtime, 0);
 
-    if (!xlu_cfg_get_long (config, "videoram", &l, 0))
-        b_info->video_memkb = l * 1024;
+    if (!xlu_cfg_get_long (config, "videoram", &l, 0)){
+        if ( l < 8 ){
+            fprintf(stderr, "ERROR: videoram must be at least 8 mb\n");
+            exit (1);
+        } else {
+            b_info->video_memkb = l * 1024;
+        }
+    }
 
     switch(b_info->type) {
     case LIBXL_DOMAIN_TYPE_HVM:
Signature · 1 line
1.7.9.5

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#1 lore raw
Quoted 50 lines · Fabio Fantoni

tools/libxl: Improve videoram setting

- If videoram setting is less than 8 mb shows error.
- Added videoram setting for qemu upstream with cirrus (added in qemu 1.3).
- Updated xl.cfg man.

---
 docs/man/xl.cfg.pod.5    |   14 +++++---------
 tools/libxl/libxl_dm.c   |    6 ++++++
 tools/libxl/xl_cmdimpl.c |   10 ++++++++--
 3 files changed, 19 insertions(+), 11 deletions(-)
docs/man/xl.cfg.pod.5 +0 -0
index caba162..9c5cdcd 100644
@@ -974,19 +974,15 @@ in the B<VFB_SPEC_STRING> for configuring virtual frame

buffer devices

Sets the amount of RAM which the emulated video card will contain, which in turn limits the resolutions and bit depths which will be

docs/man/xl.cfg.pod.5 +5 -9
-available. This option is only available when using the B<stdvga>
-option (see below).
+available.
 The default amount of video ram for stdvga is 8MB which is sufficient
-for e.g. 1600x1200 at 32bpp.
+for e.g. 1600x1200 at 32bpp and videoram option is currently working
+only when using the qemu-xen-traditional device-model.
 
 When using the emulated Cirrus graphics card (B<stdvga=0>)
 the amount of video ram is fixed at 4MB which is sufficient
-for 1024x768 at 32 bpp.
-
-videoram option is currently only available when using the
-qemu-xen-traditional device-model. Upstream qemu-xen device-model
-currently does not support changing the amount of video memory for the
-emulated graphics device.
+for 1024x768 at 32 bpp and videoram option is currently working
+only when using the upstream qemu-xen device-model.
 
 =item B<stdvga=BOOLEAN>
tools/libxl/libxl_dm.c +0 -0
index c036dc1..d719130 100644
@@ -430,6 +430,12 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
             break;

tools/libxl/libxl_dm.c static char ** · line 441

Quoted 10 lines
tools/libxl/libxl_dm.c +6 -0
         case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
             flexarray_vappend(dm_args, "-vga", "cirrus", NULL);
+            if (b_info->video_memkb) {
+                flexarray_vappend(dm_args, "-global",
+                libxl__sprintf(gc, "vga.vram_size_mb=%d",
+                libxl__sizekb_to_mb(b_info->video_memkb)),
+                NULL);
+            }
             break;
         }

Looking at the QEMU code, it seems to be that there another variable with the same name to define the videoram size in vga-pci.c:

static Property vga_pci_properties[] = {
    DEFINE_PROP_UINT32("vgamem_mb", PCIVGAState, vga.vram_size_mb, 16),

Is it possible that this code works even for std-vga out of the box?

Quoted 8 lines
tools/libxl/xl_cmdimpl.c +0 -0
index e964bf1..6e11c8d 100644
@@ -831,8 +831,14 @@ static void parse_config_data(const char *config_source,
 
     xlu_cfg_get_defbool(config, "localtime", &b_info->localtime, 0);
 

tools/libxl/xl_cmdimpl.c static void parse_config_data(const char *config_source, · line 841

Quoted 10 lines
tools/libxl/xl_cmdimpl.c +8 -2
-    if (!xlu_cfg_get_long (config, "videoram", &l, 0))
-        b_info->video_memkb = l * 1024;
+    if (!xlu_cfg_get_long (config, "videoram", &l, 0)){
+        if ( l < 8 ){
+            fprintf(stderr, "ERROR: videoram must be at least 8 mb\n");
+            exit (1);
+        } else {
+            b_info->video_memkb = l * 1024;
+        }
+    }

As Ian pointed out, it would be better if you moved the error check in libxl, probably somewhere towards the beginning of initiate_domain_create.

#2 lore raw

Il 14/01/2013 13:49, Stefano Stabellini ha scritto:

Quoted 93 lines · Fabio Fantoni
Quoted 50 lines

tools/libxl: Improve videoram setting

- If videoram setting is less than 8 mb shows error.
- Added videoram setting for qemu upstream with cirrus (added in qemu 1.3).
- Updated xl.cfg man.

---
  docs/man/xl.cfg.pod.5    |   14 +++++---------
  tools/libxl/libxl_dm.c   |    6 ++++++
  tools/libxl/xl_cmdimpl.c |   10 ++++++++--
  3 files changed, 19 insertions(+), 11 deletions(-)
docs/man/xl.cfg.pod.5 +0 -0
index caba162..9c5cdcd 100644
@@ -974,19 +974,15 @@ in the B<VFB_SPEC_STRING> for configuring virtual frame

buffer devices

Sets the amount of RAM which the emulated video card will contain, which in turn limits the resolutions and bit depths which will be

docs/man/xl.cfg.pod.5 +5 -9
-available. This option is only available when using the B<stdvga>
-option (see below).
+available.
  The default amount of video ram for stdvga is 8MB which is sufficient
-for e.g. 1600x1200 at 32bpp.
+for e.g. 1600x1200 at 32bpp and videoram option is currently working
+only when using the qemu-xen-traditional device-model.
 
  When using the emulated Cirrus graphics card (B<stdvga=0>)
  the amount of video ram is fixed at 4MB which is sufficient
-for 1024x768 at 32 bpp.
-
-videoram option is currently only available when using the
-qemu-xen-traditional device-model. Upstream qemu-xen device-model
-currently does not support changing the amount of video memory for the
-emulated graphics device.
+for 1024x768 at 32 bpp and videoram option is currently working
+only when using the upstream qemu-xen device-model.
 
  =item B<stdvga=BOOLEAN>
tools/libxl/libxl_dm.c +0 -0
index c036dc1..d719130 100644
@@ -430,6 +430,12 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
              break;

tools/libxl/libxl_dm.c static char ** · line 441

Quoted 10 lines
tools/libxl/libxl_dm.c +6 -0
          case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
              flexarray_vappend(dm_args, "-vga", "cirrus", NULL);
+            if (b_info->video_memkb) {
+                flexarray_vappend(dm_args, "-global",
+                libxl__sprintf(gc, "vga.vram_size_mb=%d",
+                libxl__sizekb_to_mb(b_info->video_memkb)),
+                NULL);
+            }
              break;
          }

Looking at the QEMU code, it seems to be that there another variable with the same name to define the videoram size in vga-pci.c:

static Property vga_pci_properties[] = {
     DEFINE_PROP_UINT32("vgamem_mb", PCIVGAState, vga.vram_size_mb, 16),

Is it possible that this code works even for std-vga out of the box?

Quoted 8 lines
tools/libxl/xl_cmdimpl.c +0 -0
index e964bf1..6e11c8d 100644
@@ -831,8 +831,14 @@ static void parse_config_data(const char *config_source,
 
      xlu_cfg_get_defbool(config, "localtime", &b_info->localtime, 0);
 

tools/libxl/xl_cmdimpl.c static void parse_config_data(const char *config_source, · line 841

Quoted 10 lines
tools/libxl/xl_cmdimpl.c +8 -2
-    if (!xlu_cfg_get_long (config, "videoram", &l, 0))
-        b_info->video_memkb = l * 1024;
+    if (!xlu_cfg_get_long (config, "videoram", &l, 0)){
+        if ( l < 8 ){
+            fprintf(stderr, "ERROR: videoram must be at least 8 mb\n");
+            exit (1);
+        } else {
+            b_info->video_memkb = l * 1024;
+        }
+    }

As Ian pointed out, it would be better if you moved the error check in libxl, probably somewhere towards the beginning of initiate_domain_create.

Quoted 6 lines

-----
Nessun virus nel messaggio.
Controllato da AVG - www.avg.com
Versione: 2013.0.2890 / Database dei virus: 2638/6030 - Data di rilascio: 13/01/2013

About std-vga videoram it seems defined at fixed value and I found only the cirrus and qxl being custimisable. For example this is the commit that make cirrus custimisable:
http://xenbits.xen.org/gitweb/?p=staging/qemu-upstream-unstable.git;a=commit;h=19403a68fb8eaefb2e1245b6a8384d3a3ffa7ca0

About error check I added it only in this last version of patch. Why wouldn't check it near other domU configuration parameters? This seems more a sanity check to do before initiate starting domU.

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#3 lore raw
Quoted 104 lines · Fabio Fantoni

Il 14/01/2013 13:49, Stefano Stabellini ha scritto:

Quoted 96 lines · Fabio Fantoni
Quoted 52 lines

tools/libxl: Improve videoram setting

- If videoram setting is less than 8 mb shows error.
- Added videoram setting for qemu upstream with cirrus (added in qemu 1.3).
- Updated xl.cfg man.

---
  docs/man/xl.cfg.pod.5    |   14 +++++---------
  tools/libxl/libxl_dm.c   |    6 ++++++
  tools/libxl/xl_cmdimpl.c |   10 ++++++++--
  3 files changed, 19 insertions(+), 11 deletions(-)
docs/man/xl.cfg.pod.5 +0 -0
index caba162..9c5cdcd 100644
@@ -974,19 +974,15 @@ in the B<VFB_SPEC_STRING> for configuring virtual

frame
buffer devices

Sets the amount of RAM which the emulated video card will contain, which in turn limits the resolutions and bit depths which will be

docs/man/xl.cfg.pod.5 +5 -9
-available. This option is only available when using the B<stdvga>
-option (see below).
+available.
  The default amount of video ram for stdvga is 8MB which is sufficient
-for e.g. 1600x1200 at 32bpp.
+for e.g. 1600x1200 at 32bpp and videoram option is currently working
+only when using the qemu-xen-traditional device-model.
 
  When using the emulated Cirrus graphics card (B<stdvga=0>)
  the amount of video ram is fixed at 4MB which is sufficient
-for 1024x768 at 32 bpp.
-
-videoram option is currently only available when using the
-qemu-xen-traditional device-model. Upstream qemu-xen device-model
-currently does not support changing the amount of video memory for the
-emulated graphics device.
+for 1024x768 at 32 bpp and videoram option is currently working
+only when using the upstream qemu-xen device-model.
 
  =item B<stdvga=BOOLEAN>
tools/libxl/libxl_dm.c +0 -0
index c036dc1..d719130 100644
@@ -430,6 +430,12 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
              break;

tools/libxl/libxl_dm.c static char ** · line 441

Quoted 10 lines
tools/libxl/libxl_dm.c +6 -0
          case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
              flexarray_vappend(dm_args, "-vga", "cirrus", NULL);
+            if (b_info->video_memkb) {
+                flexarray_vappend(dm_args, "-global",
+                libxl__sprintf(gc, "vga.vram_size_mb=%d",
+                libxl__sizekb_to_mb(b_info->video_memkb)),
+                NULL);
+            }
              break;
          }

Looking at the QEMU code, it seems to be that there another variable with the same name to define the videoram size in vga-pci.c:

static Property vga_pci_properties[] = {
     DEFINE_PROP_UINT32("vgamem_mb", PCIVGAState, vga.vram_size_mb, 16),

Is it possible that this code works even for std-vga out of the box?

Quoted 9 lines
tools/libxl/xl_cmdimpl.c +0 -0
index e964bf1..6e11c8d 100644
@@ -831,8 +831,14 @@ static void parse_config_data(const char
 *config_source,
 
      xlu_cfg_get_defbool(config, "localtime", &b_info->localtime, 0);
 

tools/libxl/xl_cmdimpl.c static void parse_config_data(const char · line 842

Quoted 10 lines
tools/libxl/xl_cmdimpl.c +8 -2
-    if (!xlu_cfg_get_long (config, "videoram", &l, 0))
-        b_info->video_memkb = l * 1024;
+    if (!xlu_cfg_get_long (config, "videoram", &l, 0)){
+        if ( l < 8 ){
+            fprintf(stderr, "ERROR: videoram must be at least 8 mb\n");
+            exit (1);
+        } else {
+            b_info->video_memkb = l * 1024;
+        }
+    }

As Ian pointed out, it would be better if you moved the error check in libxl, probably somewhere towards the beginning of initiate_domain_create.

Quoted 7 lines

-----
Nessun virus nel messaggio.
Controllato da AVG - www.avg.com
Versione: 2013.0.2890 / Database dei virus: 2638/6030 - Data di rilascio:
13/01/2013

Quoted 4 lines

About std-vga videoram it seems defined at fixed value and I found only the cirrus and qxl being custimisable.
For example this is the commit that make cirrus custimisable:
http://xenbits.xen.org/gitweb/?p=staging/qemu-upstream-unstable.git;a=commit;h=19403a68fb8eaefb2e1245b6a8384d3a3ffa7ca0

I did a quick test and it seems that it should be possible to change the amount of videoram for stdvga too using the same command line option, however at the moment it just errors out.
Therefore I am OK with this patch only taking care of Cirrus for the moment.

Quoted 3 lines

About error check I added it only in this last version of patch. Why wouldn't check it near other domU configuration parameters? This seems more a sanity check to do before initiate starting domU.

I know that it might seem counterintuitive but we try to keep all the significant informations about the platform within libxl. So if 8MB is an important limit of the platform that libxl should know about it, while xl should stay as dumb as possible.

#4 lore raw

Il 14/01/2013 19:21, Stefano Stabellini ha scritto:

Quoted 115 lines · Fabio Fantoni
Quoted 104 lines

Il 14/01/2013 13:49, Stefano Stabellini ha scritto:

Quoted 96 lines · Fabio Fantoni
Quoted 52 lines

tools/libxl: Improve videoram setting

- If videoram setting is less than 8 mb shows error.
- Added videoram setting for qemu upstream with cirrus (added in qemu 1.3).
- Updated xl.cfg man.

---
   docs/man/xl.cfg.pod.5    |   14 +++++---------
   tools/libxl/libxl_dm.c   |    6 ++++++
   tools/libxl/xl_cmdimpl.c |   10 ++++++++--
   3 files changed, 19 insertions(+), 11 deletions(-)
docs/man/xl.cfg.pod.5 +0 -0
index caba162..9c5cdcd 100644
@@ -974,19 +974,15 @@ in the B<VFB_SPEC_STRING> for configuring virtual

frame
buffer devices

Sets the amount of RAM which the emulated video card will contain, which in turn limits the resolutions and bit depths which will be

docs/man/xl.cfg.pod.5 +5 -9
-available. This option is only available when using the B<stdvga>
-option (see below).
+available.
   The default amount of video ram for stdvga is 8MB which is sufficient
-for e.g. 1600x1200 at 32bpp.
+for e.g. 1600x1200 at 32bpp and videoram option is currently working
+only when using the qemu-xen-traditional device-model.
 
   When using the emulated Cirrus graphics card (B<stdvga=0>)
   the amount of video ram is fixed at 4MB which is sufficient
-for 1024x768 at 32 bpp.
-
-videoram option is currently only available when using the
-qemu-xen-traditional device-model. Upstream qemu-xen device-model
-currently does not support changing the amount of video memory for the
-emulated graphics device.
+for 1024x768 at 32 bpp and videoram option is currently working
+only when using the upstream qemu-xen device-model.
 
   =item B<stdvga=BOOLEAN>
tools/libxl/libxl_dm.c +0 -0
index c036dc1..d719130 100644
@@ -430,6 +430,12 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
               break;

tools/libxl/libxl_dm.c static char ** · line 441

Quoted 10 lines
tools/libxl/libxl_dm.c +6 -0
           case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
               flexarray_vappend(dm_args, "-vga", "cirrus", NULL);
+            if (b_info->video_memkb) {
+                flexarray_vappend(dm_args, "-global",
+                libxl__sprintf(gc, "vga.vram_size_mb=%d",
+                libxl__sizekb_to_mb(b_info->video_memkb)),
+                NULL);
+            }
               break;
           }

Looking at the QEMU code, it seems to be that there another variable with the same name to define the videoram size in vga-pci.c:

static Property vga_pci_properties[] = {
      DEFINE_PROP_UINT32("vgamem_mb", PCIVGAState, vga.vram_size_mb, 16),

Is it possible that this code works even for std-vga out of the box?

Quoted 9 lines
tools/libxl/xl_cmdimpl.c +0 -0
index e964bf1..6e11c8d 100644
@@ -831,8 +831,14 @@ static void parse_config_data(const char
 *config_source,
 
       xlu_cfg_get_defbool(config, "localtime", &b_info->localtime, 0);
 

tools/libxl/xl_cmdimpl.c static void parse_config_data(const char · line 842

Quoted 10 lines
tools/libxl/xl_cmdimpl.c +8 -2
-    if (!xlu_cfg_get_long (config, "videoram", &l, 0))
-        b_info->video_memkb = l * 1024;
+    if (!xlu_cfg_get_long (config, "videoram", &l, 0)){
+        if ( l < 8 ){
+            fprintf(stderr, "ERROR: videoram must be at least 8 mb\n");
+            exit (1);
+        } else {
+            b_info->video_memkb = l * 1024;
+        }
+    }

As Ian pointed out, it would be better if you moved the error check in libxl, probably somewhere towards the beginning of initiate_domain_create.

Quoted 7 lines

-----
Nessun virus nel messaggio.
Controllato da AVG - www.avg.com
Versione: 2013.0.2890 / Database dei virus: 2638/6030 - Data di rilascio:
13/01/2013

Quoted 4 lines

About std-vga videoram it seems defined at fixed value and I found only the cirrus and qxl being custimisable.
For example this is the commit that make cirrus custimisable:
http://xenbits.xen.org/gitweb/?p=staging/qemu-upstream-unstable.git;a=commit;h=19403a68fb8eaefb2e1245b6a8384d3a3ffa7ca0

I did a quick test and it seems that it should be possible to change the amount of videoram for stdvga too using the same command line option, however at the moment it just errors out.
Therefore I am OK with this patch only taking care of Cirrus for the moment.

Quoted 9 lines
Quoted 3 lines

About error check I added it only in this last version of patch. Why wouldn't check it near other domU configuration parameters? This seems more a sanity check to do before initiate starting domU.

I know that it might seem counterintuitive but we try to keep all the significant informations about the platform within libxl. So if 8MB is an important limit of the platform that libxl should know about it, while xl should stay as dumb as possible.

I tried to move the check within libxl_create.c, at the point where it sets video_memkb default value, but I couldn't make it exit in case of failure. Also I'm not sure if the check should go there. Can you help me to do it please?

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

#5 lore raw
Quoted 133 lines · Fabio Fantoni

Il 14/01/2013 19:21, Stefano Stabellini ha scritto:

Quoted 123 lines · Fabio Fantoni
Quoted 111 lines

Il 14/01/2013 13:49, Stefano Stabellini ha scritto:

Quoted 102 lines · Fabio Fantoni
Quoted 55 lines

tools/libxl: Improve videoram setting

- If videoram setting is less than 8 mb shows error.
- Added videoram setting for qemu upstream with cirrus (added in qemu 1.3).
- Updated xl.cfg man.

---
   docs/man/xl.cfg.pod.5    |   14 +++++---------
   tools/libxl/libxl_dm.c   |    6 ++++++
   tools/libxl/xl_cmdimpl.c |   10 ++++++++--
   3 files changed, 19 insertions(+), 11 deletions(-)
docs/man/xl.cfg.pod.5 +0 -0
index caba162..9c5cdcd 100644
@@ -974,19 +974,15 @@ in the B<VFB_SPEC_STRING> for configuring

virtual
frame
buffer devices

Sets the amount of RAM which the emulated video card will contain, which in turn limits the resolutions and bit depths which will be

docs/man/xl.cfg.pod.5 +1 -2
-available. This option is only available when using the B<stdvga>
-option (see below).
+available.
   The default amount of video ram for stdvga is 8MB which is

sufficient

docs/man/xl.cfg.pod.5 +2 -6
-for e.g. 1600x1200 at 32bpp.
+for e.g. 1600x1200 at 32bpp and videoram option is currently working
+only when using the qemu-xen-traditional device-model.
 
   When using the emulated Cirrus graphics card (B<stdvga=0>)
   the amount of video ram is fixed at 4MB which is sufficient
-for 1024x768 at 32 bpp.
-
-videoram option is currently only available when using the
-qemu-xen-traditional device-model. Upstream qemu-xen device-model
-currently does not support changing the amount of video memory for

the

docs/man/xl.cfg.pod.5 +2 -1
-emulated graphics device.
+for 1024x768 at 32 bpp and videoram option is currently working
+only when using the upstream qemu-xen device-model.
 
   =item B<stdvga=BOOLEAN>
tools/libxl/libxl_dm.c +0 -0
index c036dc1..d719130 100644
@@ -430,6 +430,12 @@ static char **
 libxl__build_device_model_args_new(libxl__gc *gc,
               break;

tools/libxl/libxl_dm.c static char ** · line 441

Quoted 10 lines
tools/libxl/libxl_dm.c +6 -0
           case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
               flexarray_vappend(dm_args, "-vga", "cirrus", NULL);
+            if (b_info->video_memkb) {
+                flexarray_vappend(dm_args, "-global",
+                libxl__sprintf(gc, "vga.vram_size_mb=%d",
+                libxl__sizekb_to_mb(b_info->video_memkb)),
+                NULL);
+            }
               break;
           }

Looking at the QEMU code, it seems to be that there another variable with the same name to define the videoram size in vga-pci.c:

static Property vga_pci_properties[] = {
DEFINE_PROP_UINT32("vgamem_mb", PCIVGAState, vga.vram_size_mb,
16),

Is it possible that this code works even for std-vga out of the box?

Quoted 11 lines
tools/libxl/xl_cmdimpl.c +0 -1
index e964bf1..6e11c8d 100644
@@ -831,8 +831,14 @@ static void parse_config_data(const char
 *config_source,
 
       xlu_cfg_get_defbool(config, "localtime", &b_info->localtime,
 0);
 
-    if (!xlu_cfg_get_long (config, "videoram", &l, 0))

tools/libxl/xl_cmdimpl.c static void parse_config_data(const char · line 844

Quoted 10 lines
tools/libxl/xl_cmdimpl.c +8 -1
-        b_info->video_memkb = l * 1024;
+    if (!xlu_cfg_get_long (config, "videoram", &l, 0)){
+        if ( l < 8 ){
+            fprintf(stderr, "ERROR: videoram must be at least 8
 mb\n");
+            exit (1);
+        } else {
+            b_info->video_memkb = l * 1024;
+        }
+    }

As Ian pointed out, it would be better if you moved the error check in libxl, probably somewhere towards the beginning of initiate_domain_create.

Quoted 8 lines

-----
Nessun virus nel messaggio.
Controllato da AVG - www.avg.com
Versione: 2013.0.2890 / Database dei virus: 2638/6030 - Data di rilascio:
13/01/2013

Quoted 5 lines

About std-vga videoram it seems defined at fixed value and I found only the
cirrus and qxl being custimisable.
For example this is the commit that make cirrus custimisable:
http://xenbits.xen.org/gitweb/?p=staging/qemu-upstream-unstable.git;a=commit;h=19403a68fb8eaefb2e1245b6a8384d3a3ffa7ca0

I did a quick test and it seems that it should be possible to change the amount of videoram for stdvga too using the same command line option, however at the moment it just errors out.
Therefore I am OK with this patch only taking care of Cirrus for the moment.

Quoted 8 lines
Quoted 3 lines

About error check I added it only in this last version of patch. Why wouldn't check it near other domU configuration parameters? This seems more a sanity check to do before initiate starting domU.

I know that it might seem counterintuitive but we try to keep all the
significant informations about the platform within libxl. So if 8MB is an important limit of the platform that libxl should know about it, while xl should stay as dumb as possible.

Quoted 4 lines

I tried to move the check within libxl_create.c, at the point where it sets video_memkb default value, but I couldn't make it exit in case of failure. Also I'm not sure if the check should go there. Can you help me to do it please?

Sure.
I was thinking something like this:

tools/libxl/libxl_create.c +7 -0
index c6daec9..3bf8026e 100644
@@ -628,6 +628,13 @@ static void initiate_domain_create(libxl__egc *egc,
         goto error_out;
     }
 
+    if (d_config->b_info.type == LIBXL_DOMAIN_TYPE_HVM &&
+        d_config->b_info.video_memkb < 8192) {
+        LOG(ERROR, "videoram must be at least 8MB");
+        ret = ERROR_INVAL;
+        goto error_out;
+    }
+
     for (i = 0; i < d_config->num_disks; i++) {
         ret = libxl__device_disk_setdefault(gc, &d_config->disks[i]);
         if (ret) goto error_out;
#6 lore raw

tools/libxl/libxl_create.c static void initiate_domain_create(libxl__egc *egc,

Quoted 19 lines
Quoted 10 lines
Quoted 5 lines

I know that it might seem counterintuitive but we try to keep all the
significant informations about the platform within libxl. So if 8MB is an important limit of the platform that libxl should know about it, while xl should stay as dumb as possible.

I tried to move the check within libxl_create.c, at the point where it sets video_memkb default value, but I couldn't make it exit in case of failure. Also I'm not sure if the check should go there. Can you help me to do it please?

Sure.
I was thinking something like this:

tools/libxl/libxl_create.c +0 -0
index c6daec9..3bf8026e 100644
@@ -628,6 +628,13 @@ static void initiate_domain_create(libxl__egc *egc,

A better place for this check is libxl__domain_build_info_setdefault, which is more like "set defaults and validate what is already there" than the name would suggest.

tools/libxl/libxl_create.c static void initiate_domain_create(libxl__egc *egc, · line 637

Quoted 10 lines
tools/libxl/libxl_create.c +7 -0
         goto error_out;
     }
 
+    if (d_config->b_info.type == LIBXL_DOMAIN_TYPE_HVM &&
+        d_config->b_info.video_memkb < 8192) {
+        LOG(ERROR, "videoram must be at least 8MB");
+        ret = ERROR_INVAL;
+        goto error_out;
+    }
+

Ian.

#7 lore raw
In reply to Stefano Stabellini

Il 14/01/2013 19:21, Stefano Stabellini ha scritto:

Quoted 1 line

I did a quick test and it seems that it should be possible to change the amount of videoram for stdvga too using the same command line option, however at the moment it just errors out. Therefore I am OK with this patch only taking care of Cirrus for the moment.

I found details about stdvga on qemu upstream:
http://xenbits.xen.org/gitweb/?p=staging/qemu-upstream-unstable.git;a=blob_plain;f=docs/specs/standard-vga.txt;hb=HEAD

It seems that stdvga memory by default is 16 mb, while xen reserves only 8 mb by default and doen't logs any error.
For cirrus, increasing memory seems to be correct and without error with my patch.
WIth both cirrus and stdvga under qemu upstream with xen the performance are really poor even if I increase video memory, respect to qemu-only and qemu-kvm (without xen). Qxl is definitely not working under xen and conversely is ok on qemu-kvm and qemu-only.

It seem that xen need change and/or fix to have full working emulated vga on qemu upstream. At the moment all emulated vgas have problems with xen that aren't present without xen.

The performance differences are noticeable (in some case very big) with xen and without xen using resolution > 1024x768.

Probably the first link explain the change/fix necessary in xen about vga (probably in hvmloader). I tried to do that more times failing but unfortunately I do not have sufficient knowledge about this. Can someone help me please?

I think this is important, years ago the minimal resolution used on desktop was 1024x768, and no problem with actual vga setting but now minimal resolution seems increased to up 1366x768 and many people are using even higher resolutions.
http://www.screenresolution.org/year-2013/

#8 lore raw

Just as a quick note, when I originally added the variable vram option in "traditional" qemu-xen, it required patches to the vga BIOS as well as to qemu. I'm not sure that those patches ever made it into upstream vgabios, though I did post the patches to qemu-devel at one point.

/Trolle

Quoted 42 lines · Fabio Fantoni

Il 14/01/2013 19:21, Stefano Stabellini ha scritto:

Quoted 5 lines

I did a quick test and it seems that it should be possible to change the amount of videoram for stdvga too using the same command line option, however at the moment it just errors out. Therefore I am OK with this patch only taking care of Cirrus for the moment.

I found details about stdvga on qemu upstream:
http://xenbits.xen.org/gitweb/**?p=staging/qemu-upstream-**
unstable.git;a=blob_plain;f=**docs/specs/standard-vga.txt;**hb=HEAD<http://xenbits.xen.org/gitweb/?p=staging/qemu-upstream-unstable.git;a=blob_plain;f=docs/specs/standard-vga.txt;hb=HEAD>

It seems that stdvga memory by default is 16 mb, while xen reserves only 8 mb by default and doen't logs any error.
For cirrus, increasing memory seems to be correct and without error with my patch.
WIth both cirrus and stdvga under qemu upstream with xen the performance are really poor even if I increase video memory, respect to qemu-only and qemu-kvm (without xen).
Qxl is definitely not working under xen and conversely is ok on qemu-kvm and qemu-only.

It seem that xen need change and/or fix to have full working emulated vga on qemu upstream.
At the moment all emulated vgas have problems with xen that aren't present without xen.

The performance differences are noticeable (in some case very big) with xen and without xen using resolution > 1024x768.

Probably the first link explain the change/fix necessary in xen about vga (probably in hvmloader).
I tried to do that more times failing but unfortunately I do not have sufficient knowledge about this.
Can someone help me please?

I think this is important, years ago the minimal resolution used on desktop was 1024x768, and no problem with actual vga setting but now minimal resolution seems increased to up 1366x768 and many people are using even higher resolutions.
http://www.screenresolution.**org/year-2013/<http://www.screenresolution.org/year-2013/>

Quoted 6 lines

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xen.org/xen-devel