Skip to contentSkip to conversation

ARM: tegra: Add cpu node in device tree

PATCH New Hiroshi Doyu 3 participants 6 messages Jan 11, 2013

Subsystems (2)
Device tree bindings Tegra architecture support
lore
Share & tools
lore

Hiroshi Doyu

author
#0 lore raw

cover ARM: tegra: Add cpu node in device tree

Hi,

Quoted 1 line

From the discussion(*1) of CPU core# detection, DT cpu node will be

the only way to do it right. So we need to add cpu nodes on the existing Tegra SoCs(T20/T30) first in order to remove the existing A9 SCU detection later, where DT cpu# detection fails, we would consider a single cpu core avalable.

Tested only with T30.

Hiroshi Doyu (2):
ARM: tegra20: Add cpu node
ARM: tegra30: Add cpu node

 arch/arm/boot/dts/tegra20.dtsi |   29 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/tegra30.dtsi |   29 +++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)

*1:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-January/140209.html

Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/2 ARM: tegra20: Add cpu node

Add cpu node for tegra20.

Signed-off-by Hiroshi Doyu <[email protected]>
---
 arch/arm/boot/dts/tegra20.dtsi |   29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
arch/arm/boot/dts/tegra20.dtsi +29 -0
index 6e13d13..434360b 100644
@@ -430,6 +430,35 @@
 		status = "disabled";
 	};
 
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <0>;
+		};
+
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <1>;
+		};
+
+		cpu at 2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <2>;
+		};
+
+		cpu at 3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <3>;
+		};
+	};
+
 	pmu {
 		compatible = "arm,cortex-a9-pmu";
 		interrupts = <0 56 0x04
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 1/1 ARM: tegra20: Add cpu node

Add cpu node for tegra20.

Signed-off-by Hiroshi Doyu <[email protected]>

---
Update: To be honest, T20 doesn't have four cores but two:)

---
 arch/arm/boot/dts/tegra20.dtsi |   17 +++++++++++++++++
 1 file changed, 17 insertions(+)
arch/arm/boot/dts/tegra20.dtsi +17 -0
index 6e13d13..10dfb83 100644
@@ -430,6 +430,23 @@
 		status = "disabled";
 	};
 
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <0>;
+		};
+
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <1>;
+		};
+	};
+
 	pmu {
 		compatible = "arm,cortex-a9-pmu";
 		interrupts = <0 56 0x04
Signature · 1 line
1.7.9.5
Applied
#3 lore raw

PATCH 1/1 ARM: tegra20: Add cpu node

Quoted 1 line · Hiroshi Doyu

Add cpu node for tegra20.

Applied the series to Tegra's for-3.9/soc branch, in anticipation of the Tegra114 changes being applied to that branch, which depend on these DT changes.

I made some minor changes to capitalization of the commit messages.

author
#4 lore raw

PATCH 2/2 ARM: tegra30: Add cpu node

In reply to Hiroshi Doyu

Add cpu node for tegra30.

Signed-off-by Hiroshi Doyu <[email protected]>
---
 arch/arm/boot/dts/tegra30.dtsi |   29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
arch/arm/boot/dts/tegra30.dtsi +29 -0
index 5b02ff0..df3214f 100644
@@ -467,6 +467,35 @@
 		status = "disabled";
 	};
 
+	cpus {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		cpu at 0 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <0>;
+		};
+
+		cpu at 1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <1>;
+		};
+
+		cpu at 2 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <2>;
+		};
+
+		cpu at 3 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a9";
+			reg = <3>;
+		};
+	};
+
 	pmu {
 		compatible = "arm,cortex-a9-pmu";
 		interrupts = <0 144 0x04
Signature · 1 line
1.7.9.5
#5 lore raw

cover ARM: tegra: Add cpu node in device tree

In reply to Hiroshi Doyu
Quoted 14 lines · Hiroshi Doyu

Hi,

From the discussion(*1) of CPU core# detection, DT cpu node will be the only way to do it right. So we need to add cpu nodes on the existing Tegra SoCs(T20/T30) first in order to remove the existing A9 SCU detection later, where DT cpu# detection fails, we would consider a single cpu core avalable.

Tested only with T30.

Hiroshi Doyu (2):
ARM: tegra20: Add cpu node
ARM: tegra30: Add cpu node

Quoted 6 lines
 arch/arm/boot/dts/tegra20.dtsi |   29 +++++++++++++++++++++++++++++
 arch/arm/boot/dts/tegra30.dtsi |   29 +++++++++++++++++++++++++++++
 2 files changed, 58 insertions(+)

*1:
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-January/140209.html

Looks ok, but you should copy devicetree-discuss at lists.ozlabs.org for any set DT related.

FWIW on the series:

Reviewed-by Lorenzo Pieralisi <[email protected]>