rbd: fix type of snap_id in rbd_dev_v2_snap_info()

PATCH In review Alex Elder 2 participants 2 messages Jan 12, 2013 – Jan 17, 2013

Subsystems (2)

Block layer RADOS block device (RBD)

lore

Share & tools

lore

Alex Elder

author

2013-01-12 03:17 UTC #0 lore raw

PATCH 1/1 rbd: fix type of snap_id in rbd_dev_v2_snap_info()

The type of the snap_id local variable is defined with the wrong byte order. Fix that.

Signed-off-by Alex Elder <[email protected]>

---
 drivers/block/rbd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/block/rbd.c +1 -1

index 02002b1..47443eb 100644
@@ -2800,7 +2800,7 @@ out:
 static char *rbd_dev_v2_snap_info(struct rbd_device *rbd_dev, u32 which,
 		u64 *snap_size, u64 *snap_features)
 {
-	__le64 snap_id;
+	u64 snap_id;
 	u8 order;
 	int ret;

Signature · 1 line

1.7.9.5

Josh Durgin

Reviewed-by on v1 1/1

2013-01-17 17:41 UTC #1 lore raw

Quoted 5 lines · Alex Elder

The type of the snap_id local variable is defined with the wrong byte order. Fix that.
Signed-off-by Alex Elder <[email protected]>
---

Oops, I missed that too.

Reviewed-by Josh Durgin <[email protected]>

Quoted 16 lines

  drivers/block/rbd.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

drivers/block/rbd.c +1 -1

index 02002b1..47443eb 100644
@@ -2800,7 +2800,7 @@ out:
  static char *rbd_dev_v2_snap_info(struct rbd_device *rbd_dev, u32 which,
  		u64 *snap_size, u64 *snap_features)
  {
-	__le64 snap_id;
+	u64 snap_id;
  	u8 order;
  	int ret;