Skip to contentSkip to conversation

ndisc: Move ndisc_opt_addr_space() to include/net/ndisc.h.

RFC PATCH In review YOSHIFUJI Hideaki 1 participant 1 message Jan 12, 2013

Subsystems (3)
Networking Network drivers IPv4/IPv6
lore
Share & tools
lore

YOSHIFUJI Hideaki

author
#0 lore raw

RFC PATCH 1/6 ndisc: Move ndisc_opt_addr_space() to include/net/ndisc.h.

ndisc_opt_addr_data() should use ndisc_opt_addr_space() and centralizes calcuation of address space.

Signed-off-by YOSHIFUJI Hideaki <[email protected]>
---
 include/net/ndisc.h |    8 +++++++-
 net/ipv6/ndisc.c    |    5 -----
 2 files changed, 7 insertions(+), 6 deletions(-)
include/net/ndisc.h +7 -1
index 23b3a7c..3c53257 100644
@@ -127,13 +127,19 @@ static int ndisc_addr_option_pad(unsigned short type)
 	}
 }
 
+static inline int ndisc_opt_addr_space(struct net_device *dev)
+{
+	return NDISC_OPT_SPACE(dev->addr_len +
+			       ndisc_addr_option_pad(dev->type));
+}
+
 static inline u8 *ndisc_opt_addr_data(struct nd_opt_hdr *p,
 				      struct net_device *dev)
 {
 	u8 *lladdr = (u8 *)(p + 1);
 	int lladdrlen = p->nd_opt_len << 3;
 	int prepad = ndisc_addr_option_pad(dev->type);
-	if (lladdrlen != NDISC_OPT_SPACE(dev->addr_len + prepad))
+	if (lladdrlen != ndisc_opt_addr_space(dev))
 		return NULL;
 	return lladdr + prepad;
 }
net/ipv6/ndisc.c +0 -5
index 5733cd2..80c077c 100644
@@ -143,11 +143,6 @@ struct neigh_table nd_tbl = {
 	.gc_thresh3 =	1024,
 };
 
-static inline int ndisc_opt_addr_space(struct net_device *dev)
-{
-	return NDISC_OPT_SPACE(dev->addr_len + ndisc_addr_option_pad(dev->type));
-}
-
 static u8 *ndisc_fill_addr_option(u8 *opt, int type, void *data, int data_len,
 				  unsigned short addr_type)
 {
Signature · 1 line
1.7.9.5