configure: try pkg-config for curses

PATCH Superseded Vadim Evard 2 participants 4 messages Dec 31, 2012 – Jan 15, 2013

lore

Share & tools

lore

Vadim Evard

author

2012-12-31 16:31 UTC #0 lore raw

PATCH 1/1 configure: try pkg-config for curses

configure: try pkg-config for curses

Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance.

Signed-off-by Vadim Evard <[email protected]>

---
 configure |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

configure +3 -1

index b0c7e54..16280e2 100755
@@ -2030,7 +2030,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses -lcurses"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
 fi
 
 if test "$curses" != "no" ; then

@@ -2043,7 +2043,9 @@ int main(void) {
   return s != 0;
 }
 EOF
+  IFS=:
   for curses_lib in $curses_list; do
+    unset IFS
     if compile_prog "" "$curses_lib" ; then
       curses_found=yes
       libs_softmmu="$curses_lib $libs_softmmu"

Signature · 1 line

1.7.10.4

Vadim Evard

author

2013-01-11 12:51 UTC #1 lore raw

ping

Пнд 31 Дек 2012 20:30:59, Vadim Evard писал:

Quoted 34 lines

configure: try pkg-config for curses
Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance.
Signed-off-by Vadim Evard <[email protected]>
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
configure +0 -0
index b0c7e54..16280e2 100755
@@ -2030,7 +2030,7 @@ fi
if test "$mingw32" = "yes" ; then curses_list="-lpdcurses"
else
- curses_list="-lncurses -lcurses"
+ curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)" fi
if test "$curses" != "no" ; then
configure +0 -0
@@ -2043,7 +2043,9 @@ int main(void) {
 return s != 0;
 }
EOF
+ IFS=:
for curses_lib in $curses_list; do
+ unset IFS
if compile_prog "" "$curses_lib" ; then
curses_found=yes
libs_softmmu="$curses_lib $libs_softmmu"

Stefan Hajnoczi

2013-01-15 09:49 UTC #2 lore raw

Quoted 26 lines · Vadim Evard

ping
Пнд 31 Дек 2012 20:30:59, Vadim Evard писал:
Quoted 23 lines
configure: try pkg-config for curses
Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance.
Signed-off-by Vadim Evard <[email protected]>
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
configure +0 -0
index b0c7e54..16280e2 100755
@@ -2030,7 +2030,7 @@ fi
if test "$mingw32" = "yes" ; then curses_list="-lpdcurses"
else
- curses_list="-lncurses -lcurses"
+ curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)" fi

Quoted 11 lines

Quoted 11 lines
if test "$curses" != "no" ; then
configure +0 -0
@@ -2043,7 +2043,9 @@ int main(void) {
 return s != 0;
 }
EOF
+ IFS=:
for curses_lib in $curses_list; do
+ unset IFS
if compile_prog "" "$curses_lib" ; then
curses_found=yes
libs_softmmu="$curses_lib $libs_softmmu"

Please also unset IFS after the loop so there will never be a problem if curses_list="".

Stefan

Vadim Evard

author

2013-01-15 12:17 UTC #3 lore raw

PATCH v2 1/1 configure: try pkg-config for curses

Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance.

Fixes #1094786 for me.

Signed-off-by Vadim Evard <[email protected]>

---
 configure |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

configure +4 -1

index c908f66..40473a9 100755
@@ -2039,7 +2039,7 @@ fi
 if test "$mingw32" = "yes" ; then
     curses_list="-lpdcurses"
 else
-    curses_list="-lncurses -lcurses"
+    curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)"
 fi
 
 if test "$curses" != "no" ; then

@@ -2052,13 +2052,16 @@ int main(void) {
   return s != 0;
 }
 EOF
+  IFS=:
   for curses_lib in $curses_list; do
+    unset IFS
     if compile_prog "" "$curses_lib" ; then
       curses_found=yes
       libs_softmmu="$curses_lib $libs_softmmu"
       break
     fi
   done
+  unset IFS
   if test "$curses_found" = "yes" ; then
     curses=yes
   else

Signature · 1 line

1.7.10.4

Quoted 43 lines · Stefan Hajnoczi

Quoted 26 lines · Vadim Evard
ping
Пнд 31 Дек 2012 20:30:59, Vadim Evard писал:
Quoted 23 lines
configure: try pkg-config for curses
Static linkikng against ncurses may require explicit -ltinfo. In case -lcurses and -lncurses both didn't work give pkg-config a chance.
Signed-off-by Vadim Evard<[email protected]>
---
configure | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
configure +0 -0
index b0c7e54..16280e2 100755
@@ -2030,7 +2030,7 @@ fi
if test "$mingw32" = "yes" ; then curses_list="-lpdcurses"
else
- curses_list="-lncurses -lcurses"
+ curses_list="-lncurses:-lcurses:$($pkg_config --libs ncurses)" fi
Quoted 11 lines
Quoted 11 lines
if test "$curses" != "no" ; then
configure +0 -0
@@ -2043,7 +2043,9 @@ int main(void) {
 return s != 0;
 }
EOF
+ IFS=:
for curses_lib in $curses_list; do
+ unset IFS
if compile_prog "" "$curses_lib" ; then
curses_found=yes
libs_softmmu="$curses_lib $libs_softmmu"
Please also unset IFS after the loop so there will never be a problem if curses_list="".
Stefan