Skip to contentSkip to conversation

ARM: mm: Fix missing XN flag for for MT_MEMORY_SO

PATCH New Santosh Shilimkar 2 participants 3 messages Jan 16, 2013 – Jan 17, 2013 Arm (32-bit)

lore
Share & tools
lore

Santosh Shilimkar

author
#0 lore raw

PATCH 1/1 ARM: mm: Fix missing XN flag for for MT_MEMORY_SO

Commit 8fb54284ba6a {ARM: mm: Add strongly ordered descriptor support} added XN flag at section level but missed it at PTE level.

Fix it by adding the L_PTE_XN to MT_MEMORY_SO PET descriptor.

Cc Russell King <[email protected]>
Reported-by Richard Woodruff <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>
---
 arch/arm/mm/mmu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/mmu.c +1 -1
index 9f06102..ce328c7 100644
@@ -283,7 +283,7 @@ static struct mem_type mem_types[] = {
 	},
 	[MT_MEMORY_SO] = {
 		.prot_pte  = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
-				L_PTE_MT_UNCACHED,
+				L_PTE_MT_UNCACHED | L_PTE_XN,
 		.prot_l1   = PMD_TYPE_TABLE,
 		.prot_sect = PMD_TYPE_SECT | PMD_SECT_AP_WRITE | PMD_SECT_S |
 				PMD_SECT_UNCACHED | PMD_SECT_XN,
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: mm: Fix missing XN flag for for MT_MEMORY_SO

Quoted 10 lines · Santosh Shilimkar

Commit 8fb54284ba6a {ARM: mm: Add strongly ordered descriptor support} added XN flag at section level but missed it at PTE level.

Fix it by adding the L_PTE_XN to MT_MEMORY_SO PET descriptor.

Cc Russell King <[email protected]>
Reported-by Richard Woodruff <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>

---

Hmm, yes. => patch system please.

Quoted 19 lines
 arch/arm/mm/mmu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/mm/mmu.c +1 -1
index 9f06102..ce328c7 100644
@@ -283,7 +283,7 @@ static struct mem_type mem_types[] = {
 	},
 	[MT_MEMORY_SO] = {
 		.prot_pte  = L_PTE_PRESENT | L_PTE_YOUNG | L_PTE_DIRTY |
-				L_PTE_MT_UNCACHED,
+				L_PTE_MT_UNCACHED | L_PTE_XN,
 		.prot_l1   = PMD_TYPE_TABLE,
 		.prot_sect = PMD_TYPE_SECT | PMD_SECT_AP_WRITE | PMD_SECT_S |
 				PMD_SECT_UNCACHED | PMD_SECT_XN,
Signature · 1 line
1.7.9.5
author
#2 lore raw

PATCH 1/1 ARM: mm: Fix missing XN flag for for MT_MEMORY_SO

Quoted 6 lines · Russell King - ARM Linux
Quoted 5 lines · Santosh Shilimkar

Commit 8fb54284ba6a {ARM: mm: Add strongly ordered descriptor support} added XN flag at section level but missed it at PTE level.

Fix it by adding the L_PTE_XN to MT_MEMORY_SO PET descriptor.

Quoted 8 lines
Quoted 5 lines
Cc Russell King <[email protected]>
Reported-by Richard Woodruff <[email protected]>
Signed-off-by Santosh Shilimkar <[email protected]>

---

Hmm, yes. => patch system please.

7629/1 in patch system.

Regards,
Santosh