ipv6: Do not depend on rt->n in ip6_dst_lookup_tail().

PATCH In review YOSHIFUJI Hideaki 1 participant 1 message Jan 17, 2013

Subsystems (3)

Networking Network drivers IPv4/IPv6

lore

Share & tools

lore

YOSHIFUJI Hideaki

author

2013-01-17 22:53 UTC #0 lore raw

PATCH 9/11 ipv6: Do not depend on rt->n in ip6_dst_lookup_tail().

Signed-off-by YOSHIFUJI Hideaki <[email protected]>

---
 net/ipv6/ip6_output.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

net/ipv6/ip6_output.c +6 -2

index 9250c69..7c00edb 100644
@@ -913,8 +913,12 @@ static int ip6_dst_lookup_tail(struct sock *sk,
 	 * dst entry of the nexthop router
 	 */
 	rt = (struct rt6_info *) *dst;
-	n = rt->n;
-	if (n && !(n->nud_state & NUD_VALID)) {
+	rcu_read_lock_bh();
+	n = __ipv6_neigh_lookup_noref(rt->dst.dev, rt6_nexthop(rt, &fl6->daddr));
+	err = n && !(n->nud_state & NUD_VALID) ? -EINVAL : 0;
+	rcu_read_unlock_bh();
+
+	if (err) {
 		struct inet6_ifaddr *ifp;
 		struct flowi6 fl_gw6;
 		int redirect;

Signature · 1 line

1.7.9.5