ARM: dts: OMAP3+: PWM support for TWL and selected boards

PATCH New Peter Ujfalusi 2 participants 11 messages Jan 18, 2013 – Jan 22, 2013 Device tree bindings

lore

Share & tools

lore

Peter Ujfalusi

author

2013-01-18 14:36 UTC #0 lore raw

cover ARM: dts: OMAP3+: PWM support for TWL and selected boards

Hi,

Add the needed DT sections for twl4030 and twl6030 for the PWM childs. Update the omap4-sdp to have working backlight and keypad/charging LED support. Use the pwm-leds driver on BeagleBoard for the pmu_stat LED instead of the hacky twl403-gpio mapped PWM.

Regards,
Peter
---
Peter Ujfalusi (5):
ARM: dts: twl4030: Add PWM support
ARM: dts: twl6030: Add PWM support
ARM: dts: omap3-beagle-xm: Use pwm-leds for pmu_stat LED
ARM: dts: omap4-sdp: Add support for pwm-leds (keypad and charging LED)
ARM: dts: omap4-sdp: Add support for pwm-backlight

 arch/arm/boot/dts/omap3-beagle-xm.dts | 14 ++++++++++----
 arch/arm/boot/dts/omap4-sdp.dts       | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/twl4030.dtsi        | 10 ++++++++++
 arch/arm/boot/dts/twl6030.dtsi        | 12 ++++++++++++
 4 files changed, 58 insertions(+), 4 deletions(-)

Signature · 1 line

1.8.1

Peter Ujfalusi

author

2013-01-18 14:36 UTC #1 lore raw

PATCH 1/5 ARM: dts: twl4030: Add PWM support

Enable support for the PWMs and LEDs as PWM drivers.

Signed-off-by Peter Ujfalusi <[email protected]>

---
 arch/arm/boot/dts/twl4030.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)

arch/arm/boot/dts/twl4030.dtsi +10 -0

index ed0bc95..d216853 100644
@@ -75,4 +75,14 @@
 		usb3v1-supply = <&vusb3v1>;
 		usb_mode = <1>;
 	};
+
+	twl_pwm: pwm {
+		compatible = "ti,twl4030-pwm";
+		#pwm-cells = <2>;
+	};
+
+	twl_pwmled: pwmled {
+		compatible = "ti,twl4030-pwmled";
+		#pwm-cells = <2>;
+	};
 };

Signature · 1 line

1.8.1

Peter Ujfalusi

author

2013-01-18 14:36 UTC #2 lore raw

PATCH 2/5 ARM: dts: twl6030: Add PWM support

In reply to Peter Ujfalusi

Enable support for the PWMs and LED as PWM drivers.

Signed-off-by Peter Ujfalusi <[email protected]>

---
 arch/arm/boot/dts/twl6030.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

arch/arm/boot/dts/twl6030.dtsi +12 -0

index 9996cfc..d9b8b21 100644
@@ -91,4 +91,16 @@
 		compatible = "ti,twl6030-usb";
 		interrupts = <4>, <10>;
 	};
+
+	twl_pwm: pwm {
+		/* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
+		compatible = "ti,twl6030-pwm";
+		#pwm-cells = <2>;
+	};
+
+	twl_pwmled: pwmled {
+		/* provides one PWM (id 0 for Charing indicator LED) */
+		compatible = "ti,twl6030-pwmled";
+		#pwm-cells = <2>;
+	};
 };

Signature · 1 line

1.8.1

Benoit Cousson

2013-01-22 10:39 UTC #3 lore raw

PATCH 2/5 ARM: dts: twl6030: Add PWM support

Hi Peter,

Just one minor typo here.

Quoted 14 lines · Peter Ujfalusi

Enable support for the PWMs and LED as PWM drivers.
Signed-off-by Peter Ujfalusi <[email protected]>
---
 arch/arm/boot/dts/twl6030.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)
arch/arm/boot/dts/twl6030.dtsi +0 -0
index 9996cfc..d9b8b21 100644
@@ -91,4 +91,16 @@
 		compatible = "ti,twl6030-usb";
 		interrupts = <4>, <10>;

arch/arm/boot/dts/twl6030.dtsi line 102

Quoted 10 lines

arch/arm/boot/dts/twl6030.dtsi +9 -0

 	};
+
+	twl_pwm: pwm {
+		/* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
+		compatible = "ti,twl6030-pwm";
+		#pwm-cells = <2>;
+	};
+
+	twl_pwmled: pwmled {
+		/* provides one PWM (id 0 for Charing indicator LED) */

typo: charging.

Regards,
Benoit

Quoted 5 lines

arch/arm/boot/dts/twl6030.dtsi +3 -0
+		compatible = "ti,twl6030-pwmled";
+		#pwm-cells = <2>;
+	};
 };

Peter Ujfalusi

author

2013-01-22 10:49 UTC #4 lore raw

PATCH 2/5 ARM: dts: twl6030: Add PWM support

HI Benoit,

Quoted 11 lines · Benoit Cousson

arch/arm/boot/dts/twl6030.dtsi line 102

Quoted 9 lines

arch/arm/boot/dts/twl6030.dtsi +9 -0

+
+	twl_pwm: pwm {
+		/* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
+		compatible = "ti,twl6030-pwm";
+		#pwm-cells = <2>;
+	};
+
+	twl_pwmled: pwmled {
+		/* provides one PWM (id 0 for Charing indicator LED) */

typo: charging.

Aargh. Corrected in the branch.

Thanks,
P?ter

Benoit Cousson

2013-01-22 10:54 UTC #5 lore raw

PATCH 2/5 ARM: dts: twl6030: Add PWM support

Quoted 15 lines · Peter Ujfalusi

HI Benoit,
Quoted 11 lines · Benoit Cousson
arch/arm/boot/dts/twl6030.dtsi line 102
Quoted 9 lines
arch/arm/boot/dts/twl6030.dtsi +9 -0
+
+	twl_pwm: pwm {
+		/* provides two PWMs (id 0, 1 for PWM1 and PWM2) */
+		compatible = "ti,twl6030-pwm";
+		#pwm-cells = <2>;
+	};
+
+	twl_pwmled: pwmled {
+		/* provides one PWM (id 0 for Charing indicator LED) */
typo: charging.

Quoted 1 line

Aargh. Corrected in the branch.

Thanks,

Pulled and pushed into git://git.kernel.org/pub/scm/linux/kernel/git/bcousson/linux-omap-dt.git for_3.9/dts

Regards,
Benoit

Peter Ujfalusi

author

2013-01-18 14:36 UTC #6 lore raw

PATCH 3/5 ARM: dts: omap3-beagle-xm: Use pwm-leds for pmu_stat LED

In reply to Peter Ujfalusi

We have proper driver stack to handle the pmu_stat LED which is connected PWMB of twl4030.

Signed-off-by Peter Ujfalusi <[email protected]>

---
 arch/arm/boot/dts/omap3-beagle-xm.dts | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

arch/arm/boot/dts/omap3-beagle-xm.dts +10 -4

index 3705a81..1c85e0f 100644
@@ -20,10 +20,6 @@
 
 	leds {
 		compatible = "gpio-leds";
-		pmu_stat {
-			label = "beagleboard::pmu_stat";
-			gpios = <&twl_gpio 19 0>; /* LEDB */
-		};
 
 		heartbeat {
 			label = "beagleboard::usr0";

@@ -38,6 +34,16 @@
 		};
 	};
 
+	pwmleds {
+		compatible = "pwm-leds";
+
+		pmu_stat {
+			label = "beagleboard::pmu_stat";
+			pwms = <&twl_pwmled 1 7812500>;
+			max-brightness = <127>;
+		};
+	};
+
 	sound {
 		compatible = "ti,omap-twl4030";
 		ti,model = "omap3beagle";

Signature · 1 line

1.8.1

Peter Ujfalusi

author

2013-01-18 14:36 UTC #7 lore raw

PATCH 4/5 ARM: dts: omap4-sdp: Add support for pwm-leds (keypad and charging LED)

In reply to Peter Ujfalusi

Sections to describe the pwm-leds in the system.

Signed-off-by Peter Ujfalusi <[email protected]>

---
 arch/arm/boot/dts/omap4-sdp.dts | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

arch/arm/boot/dts/omap4-sdp.dts +15 -0

index 43e5258..8101a94 100644
@@ -80,6 +80,21 @@
 		};
 	};
 
+	pwmleds {
+		compatible = "pwm-leds";
+		kpad {
+			label = "omap4::keypad";
+			pwms = <&twl_pwm 0 7812500>;
+			max-brightness = <127>;
+		};
+
+		charging {
+			label = "omap4:green:chrg";
+			pwms = <&twl_pwmled 0 7812500>;
+			max-brightness = <255>;
+		};
+	};
+
 	sound {
 		compatible = "ti,abe-twl6040";
 		ti,model = "SDP4430";

Signature · 1 line

1.8.1

Peter Ujfalusi

author

2013-01-18 14:36 UTC #8 lore raw

PATCH 5/5 ARM: dts: omap4-sdp: Add support for pwm-backlight

In reply to Peter Ujfalusi

Section to describe the backlight for the LCD panels.

Signed-off-by Peter Ujfalusi <[email protected]>

---
 arch/arm/boot/dts/omap4-sdp.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

arch/arm/boot/dts/omap4-sdp.dts +11 -0

index 8101a94..c2dee41 100644
@@ -95,6 +95,17 @@
 		};
 	};
 
+	backlight {
+		compatible = "pwm-backlight";
+		pwms = <&twl_pwm 1 7812500>;
+		brightness-levels = <
+				0 10 20 30 40
+				50 60 70 80 90
+				100 110 120 127
+				>;
+		default-brightness-level = <13>;
+	};
+
 	sound {
 		compatible = "ti,abe-twl6040";
 		ti,model = "SDP4430";

Signature · 1 line

1.8.1

Peter Ujfalusi

author

2013-01-22 10:11 UTC #9 lore raw

cover ARM: dts: OMAP3+: PWM support for TWL and selected boards

In reply to Peter Ujfalusi

Hi Benoit,

I have prepared for you a branch from where you can pull this set on top of mainline v3.8-rc4:

Regards,
P?ter

---
The following changes since commit 7d1f9aeff1ee4a20b1aeb377dd0f579fe9647619:

Linux 3.8-rc4 (2013-01-17 19:25:45 -0800)

are available in the git repository at:

git://gitorious.org/omap-audio/linux-audio.git peter/for-benoit

for you to fetch changes up to b6230ae20bc018d042d703d0667ba9e7ac027ccb:

ARM: dts: omap4-sdp: Add support for pwm-backlight (2013-01-22 11:08:37 +0100)

----------------------------------------------------------------
Peter Ujfalusi (5):
ARM: dts: twl4030: Add PWM support
ARM: dts: twl6030: Add PWM support
ARM: dts: omap3-beagle-xm: Use pwm-leds for pmu_stat LED
ARM: dts: omap4-sdp: Add support for pwm-leds (keypad and charging LED)
ARM: dts: omap4-sdp: Add support for pwm-backlight

 arch/arm/boot/dts/omap3-beagle-xm.dts | 14 ++++++++++----
 arch/arm/boot/dts/omap4-sdp.dts       | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/twl4030.dtsi        | 10 ++++++++++
 arch/arm/boot/dts/twl6030.dtsi        | 12 ++++++++++++
 4 files changed, 58 insertions(+), 4 deletions(-)

Quoted 23 lines · Peter Ujfalusi

Hi,
Add the needed DT sections for twl4030 and twl6030 for the PWM childs. Update the omap4-sdp to have working backlight and keypad/charging LED support. Use the pwm-leds driver on BeagleBoard for the pmu_stat LED instead of the hacky twl403-gpio mapped PWM.
Regards,
Peter
---
Peter Ujfalusi (5):
ARM: dts: twl4030: Add PWM support
ARM: dts: twl6030: Add PWM support
ARM: dts: omap3-beagle-xm: Use pwm-leds for pmu_stat LED
ARM: dts: omap4-sdp: Add support for pwm-leds (keypad and charging LED)
ARM: dts: omap4-sdp: Add support for pwm-backlight
 arch/arm/boot/dts/omap3-beagle-xm.dts | 14 ++++++++++----
 arch/arm/boot/dts/omap4-sdp.dts       | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/twl4030.dtsi        | 10 ++++++++++
 arch/arm/boot/dts/twl6030.dtsi        | 12 ++++++++++++
 4 files changed, 58 insertions(+), 4 deletions(-)

Benoit Cousson

2013-01-22 10:23 UTC #10 lore raw

cover ARM: dts: OMAP3+: PWM support for TWL and selected boards

Hi Peter,

Quoted 4 lines · Peter Ujfalusi

Hi Benoit,
I have prepared for you a branch from where you can pull this set on top of mainline v3.8-rc4:

Cool thanks,
I'll merged it in my branch.

Thanks,
Benoit

Quoted 57 lines

Regards,
P?ter
---
The following changes since commit 7d1f9aeff1ee4a20b1aeb377dd0f579fe9647619:
Linux 3.8-rc4 (2013-01-17 19:25:45 -0800)
are available in the git repository at:
git://gitorious.org/omap-audio/linux-audio.git peter/for-benoit
for you to fetch changes up to b6230ae20bc018d042d703d0667ba9e7ac027ccb:
ARM: dts: omap4-sdp: Add support for pwm-backlight (2013-01-22 11:08:37 +0100)
----------------------------------------------------------------
Peter Ujfalusi (5):
ARM: dts: twl4030: Add PWM support
ARM: dts: twl6030: Add PWM support
ARM: dts: omap3-beagle-xm: Use pwm-leds for pmu_stat LED
ARM: dts: omap4-sdp: Add support for pwm-leds (keypad and charging LED)
ARM: dts: omap4-sdp: Add support for pwm-backlight
 arch/arm/boot/dts/omap3-beagle-xm.dts | 14 ++++++++++----
 arch/arm/boot/dts/omap4-sdp.dts       | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/twl4030.dtsi        | 10 ++++++++++
 arch/arm/boot/dts/twl6030.dtsi        | 12 ++++++++++++
 4 files changed, 58 insertions(+), 4 deletions(-)
Quoted 23 lines · Peter Ujfalusi
Hi,
Add the needed DT sections for twl4030 and twl6030 for the PWM childs. Update the omap4-sdp to have working backlight and keypad/charging LED support. Use the pwm-leds driver on BeagleBoard for the pmu_stat LED instead of the hacky twl403-gpio mapped PWM.
Regards,
Peter
---
Peter Ujfalusi (5):
ARM: dts: twl4030: Add PWM support
ARM: dts: twl6030: Add PWM support
ARM: dts: omap3-beagle-xm: Use pwm-leds for pmu_stat LED
ARM: dts: omap4-sdp: Add support for pwm-leds (keypad and charging LED)
ARM: dts: omap4-sdp: Add support for pwm-backlight
 arch/arm/boot/dts/omap3-beagle-xm.dts | 14 ++++++++++----
 arch/arm/boot/dts/omap4-sdp.dts       | 26 ++++++++++++++++++++++++++
 arch/arm/boot/dts/twl4030.dtsi        | 10 ++++++++++
 arch/arm/boot/dts/twl6030.dtsi        | 12 ++++++++++++
 4 files changed, 58 insertions(+), 4 deletions(-)