Btrfs: check the return value of btrfs_start_delalloc_inodes()

PATCH In review Miao Xie 1 participant 1 message Jan 22, 2013 Btrfs file system

lore

Share & tools

lore

Miao Xie

author

2013-01-22 10:48 UTC #0 lore raw

PATCH 2/5 Btrfs: check the return value of btrfs_start_delalloc_inodes()

We forget to check the return value of btrfs_start_delalloc_inodes(), fix it.

Signed-off-by Miao Xie <[email protected]>

---
 fs/btrfs/dev-replace.c |    6 +++++-
 fs/btrfs/transaction.c |    4 +++-
 2 files changed, 8 insertions(+), 2 deletions(-)

fs/btrfs/dev-replace.c +5 -1

index 66dbc8d..7ba7b39 100644
@@ -465,7 +465,11 @@ static int btrfs_dev_replace_finishing(struct btrfs_fs_info *fs_info,
 	 * flush all outstanding I/O and inode extent mappings before the
 	 * copy operation is declared as being finished
 	 */
-	btrfs_start_delalloc_inodes(root, 0);
+	ret = btrfs_start_delalloc_inodes(root, 0);
+	if (ret) {
+		mutex_unlock(&dev_replace->lock_finishing_cancel_unmount);
+		return ret;
+	}
 	btrfs_wait_ordered_extents(root, 0);
 
 	trans = btrfs_start_transaction(root, 0);

fs/btrfs/transaction.c +3 -1

index 87fac9a..34c5b7b 100644
@@ -1417,7 +1417,9 @@ static int btrfs_flush_all_pending_stuffs(struct btrfs_trans_handle *trans,
 	}
 
 	if (flush_on_commit || snap_pending) {
-		btrfs_start_delalloc_inodes(root, 1);
+		ret = btrfs_start_delalloc_inodes(root, 1);
+		if (ret)
+			return ret;
 		btrfs_wait_ordered_extents(root, 1);
 	}

Signature · 1 line

1.6.5.2