Dove: activate GPIO interrupts in DT
PATCH 1/1 Dove: activate GPIO interrupts in DT
In a DT, the interrupts of an interrupt-controller are not usable when #interrupt-cells is missing.
This patch activates the interrupts of the GPIOs 0 and 1 for the Marvell Dove SoC.
arch/arm/boot/dts/dove.dtsi +2 -0
@@ -93,6 +93,7 @@ reg = <0xd0400 0x20>; ngpios = <32>; interrupt-controller; + #interrupt-cells = <1>; interrupts = <12>, <13>, <14>, <60>; };
@@ -103,6 +104,7 @@ reg = <0xd0420 0x20>; ngpios = <32>; interrupt-controller; + #interrupt-cells = <1>; interrupts = <61>; };
Signature · 2 lines
Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/
PATCH 1/1 Dove: activate GPIO interrupts in DT
Quoted 21 lines · Jean-Francois Moine
In a DT, the interrupts of an interrupt-controller are not usable when #interrupt-cells is missing.
This patch activates the interrupts of the GPIOs 0 and 1 for the Marvell Dove SoC.
Signed-off-by Jean-Fran?ois Moine<[email protected]>arch/arm/boot/dts/dove.dtsi +1
-0@@ -93,6 +93,7 @@ reg =<0xd0400 0x20>; ngpios =<32>; interrupt-controller; + #interrupt-cells =<1>; interrupts =<12>,<13>,<14>,<60>; };
arch/arm/boot/dts/dove.dtsi line 110
Quoted 7 lines
arch/arm/boot/dts/dove.dtsi +1
-0@@ -103,6 +104,7 @@ reg =<0xd0420 0x20>; ngpios =<32>; interrupt-controller; + #interrupt-cells =<1>; interrupts =<61>; };
Jean-Francois,
first thanks for sending the patch!
I checked Documentation/devicetree/bindings/gpio/gpio-mvebu.txt and there #interrupt-cells is specified to be set to two. Further, I checked kirkwood.dtsi and it is also missing the #interrupt-cells.
Can you please update your patch to have #interrupt-cells set to two? When you resend v2 of the patch please Cc at least all I added.
I will send another patch fixing kirkwood.dtsi.
Sebastian