Skip to contentSkip to conversation

sched_ext: Collect ext_*.c include headers in build_policy.c

PATCH Applied Tejun Heo 2 participants 3 messages Apr 27 – Apr 28

Subsystems (2)
lore
Share & tools
lore

Tejun Heo

author reviewer
#0 lore raw

PATCH 1/1 sched_ext: Collect ext_*.c include headers in build_policy.c

Move <linux/btf_ids.h> from ext.c and "ext_idle.h" from ext.c (plus its self-include in ext_idle.c) into build_policy.c. Subsequent patches add their headers the same way for consistency.

No functional change.

---
 kernel/sched/build_policy.c | 2 ++
 kernel/sched/ext.c          | 2 --
 kernel/sched/ext_idle.c     | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)
kernel/sched/build_policy.c +2 -0
index 755883faf751..ffb386889218 100644
@@ -58,7 +58,9 @@
 #include "deadline.c"
 
 #ifdef CONFIG_SCHED_CLASS_EXT
+# include <linux/btf_ids.h>
 # include "ext_internal.h"
+# include "ext_idle.h"
 # include "ext.c"
 # include "ext_idle.c"
 #endif
kernel/sched/ext.c +0 -2
index f7b1b16e81a5..11893f00be06 100644
@@ -6,8 +6,6 @@
  * Copyright (c) 2022 Tejun Heo <[email protected]>
  * Copyright (c) 2022 David Vernet <[email protected]>
  */
-#include <linux/btf_ids.h>
-#include "ext_idle.h"
 
 static DEFINE_RAW_SPINLOCK(scx_sched_lock);
 
kernel/sched/ext_idle.c +0 -1
index 7468560a6d80..f0f4d9500997 100644
@@ -9,7 +9,6 @@
  * Copyright (c) 2022 David Vernet <[email protected]>
  * Copyright (c) 2024 Andrea Righi <[email protected]>
  */
-#include "ext_idle.h"
 
 /* Enable/disable built-in idle CPU selection policy */
 static DEFINE_STATIC_KEY_FALSE(scx_builtin_idle_enabled);

--
2.53.0

reviewer Reviewed-by on v1 1/1
#1 lore raw

Hi Tejun,

Quoted 7 lines · Tejun Heo

Move <linux/btf_ids.h> from ext.c and "ext_idle.h" from ext.c (plus its self-include in ext_idle.c) into build_policy.c. Subsequent patches add their headers the same way for consistency.

No functional change.

Looks good.

Thanks,
-Andrea

Quoted 48 lines
---
 kernel/sched/build_policy.c | 2 ++
 kernel/sched/ext.c          | 2 --
 kernel/sched/ext_idle.c     | 1 -
 3 files changed, 2 insertions(+), 3 deletions(-)
kernel/sched/build_policy.c +2 -0
index 755883faf751..ffb386889218 100644
@@ -58,7 +58,9 @@
 #include "deadline.c"
 
 #ifdef CONFIG_SCHED_CLASS_EXT
+# include <linux/btf_ids.h>
 # include "ext_internal.h"
+# include "ext_idle.h"
 # include "ext.c"
 # include "ext_idle.c"
 #endif
kernel/sched/ext.c +0 -2
index f7b1b16e81a5..11893f00be06 100644
@@ -6,8 +6,6 @@
  * Copyright (c) 2022 Tejun Heo <[email protected]>
  * Copyright (c) 2022 David Vernet <[email protected]>
  */
-#include <linux/btf_ids.h>
-#include "ext_idle.h"
 
 static DEFINE_RAW_SPINLOCK(scx_sched_lock);
 
kernel/sched/ext_idle.c +0 -2
index 7468560a6d80..f0f4d9500997 100644
@@ -9,7 +9,6 @@
  * Copyright (c) 2022 David Vernet <[email protected]>
  * Copyright (c) 2024 Andrea Righi <[email protected]>
  */
-#include "ext_idle.h"
 
 /* Enable/disable built-in idle CPU selection policy */
 static DEFINE_STATIC_KEY_FALSE(scx_builtin_idle_enabled);
--

2.53.0

author reviewer Applied
#2 lore raw
In reply to Tejun Heo

Hello,

Quoted 2 lines

Tejun Heo (1):
sched_ext: Collect ext_*.c include headers in build_policy.c

Applied to sched_ext/for-7.2 with Andrea's Reviewed-by tag added.

Thanks.

--
tejun