Skip to contentSkip to conversation

mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

PATCH In review Zhang, YiX X 4 participants 5 messages Jan 8, 2013 – Jan 28, 2013 MMC, SD and SDIO

lore
Share & tools
lore

Zhang, YiX X

author
#0 lore raw

PATCH 1/1 mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

Quoted 1 line

From aaea3405944d844f53679b295d4082584f33d9a3 Mon Sep 17 00:00:00 2001

From: ZhangYi <[email protected]>
Date: Tue, 8 Jan 2013 13:50:09 +0800
Subject: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

The right value is 54 according to eMMC 4.5 specification.

Signed-off-by ZhangYi <[email protected]>
---
 include/linux/mmc/card.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/mmc/card.h +1 -1
index 5c69315..ffde1d3 100644
@@ -83,7 +83,7 @@ struct mmc_ext_csd {
 	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
 	unsigned int		boot_ro_lock;		/* ro lock support */
 	bool			boot_ro_lockable;
-	u8			raw_exception_status;	/* 53 */
+	u8			raw_exception_status;	/* 54 */
 	u8			raw_partition_support;	/* 160 */
 	u8			raw_rpmb_size_mult;	/* 168 */
 	u8			raw_erased_mem_count;	/* 181 */
Signature · 1 line
1.7.0.4
#1 lore raw

May be it is worth to change all this struct comments to be:

u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */

This will reference actual offset value from "include/linux/mmc/mmc.h"

Thanks,

Quoted 26 lines · YiX X

From aaea3405944d844f53679b295d4082584f33d9a3 Mon Sep 17 00:00:00 2001
From: ZhangYi <[email protected]>
Date: Tue, 8 Jan 2013 13:50:09 +0800
Subject: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

The right value is 54 according to eMMC 4.5 specification.

Signed-off-by ZhangYi <[email protected]>
---
  include/linux/mmc/card.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/mmc/card.h +1 -1
index 5c69315..ffde1d3 100644
@@ -83,7 +83,7 @@ struct mmc_ext_csd {
  	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
  	unsigned int		boot_ro_lock;		/* ro lock support */
  	bool			boot_ro_lockable;
-	u8			raw_exception_status;	/* 53 */
+	u8			raw_exception_status;	/* 54 */
  	u8			raw_partition_support;	/* 160 */
  	u8			raw_rpmb_size_mult;	/* 168 */
  	u8			raw_erased_mem_count;	/* 181 */
Signature · 4 lines
Konstantin Dorfman,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center,
Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
author
#2 lore raw

yes, you are right, I will change them later, thanks.

Regards
Zhang,Yi.

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Konstantin Dorfman
Sent: Tuesday, January 08, 2013 4:23 PM
To: Zhang, YiX X
Cc: [email protected]; [email protected]; [email protected]
Subject: Re: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

May be it is worth to change all this struct comments to be:

u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */

This will reference actual offset value from "include/linux/mmc/mmc.h"

Thanks,

Quoted 20 lines · YiX X

From aaea3405944d844f53679b295d4082584f33d9a3 Mon Sep 17 00:00:00
2001
From: ZhangYi <[email protected]>
Date: Tue, 8 Jan 2013 13:50:09 +0800
Subject: [PATCH] mmc: correct the EXCEPTION_EVENTS_STATUS vaule comment

The right value is 54 according to eMMC 4.5 specification.

Signed-off-by ZhangYi <[email protected]>
---
  include/linux/mmc/card.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
include/linux/mmc/card.h index renamed from include/linux/mmc/card.h +0 -0

5c69315..ffde1d3 100644

include/linux/mmc/card.h struct mmc_ext_csd { · line 89

Quoted 8 lines
include/linux/mmc/card.h +1 -1
@@ -83,7 +83,7 @@ struct mmc_ext_csd {
  	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
  	unsigned int		boot_ro_lock;		/* ro lock support */
  	bool			boot_ro_lockable;
-	u8			raw_exception_status;	/* 53 */
+	u8			raw_exception_status;	/* 54 */
  	u8			raw_partition_support;	/* 160 */
  	u8			raw_rpmb_size_mult;	/* 168 */
  	u8			raw_erased_mem_count;	/* 181 */

--
Konstantin Dorfman,
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw

PATCH v2 1/1 mmc: correct one comment error of structure mmc_ext_csd

In reply to Konstantin Dorfman

From: "Zhang, Yi" <[email protected]>

The right value for field raw_exception_status is 54(not 53) according to eMMC 4.5 specification. Also for more readable, replace all number values with macro symboles.

Signed-off-by Zhang, Yi <[email protected]>
---
 include/linux/mmc/card.h |   34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)
include/linux/mmc/card.h +17 -17
index 5c69315..d270392 100644
@@ -83,23 +83,23 @@ struct mmc_ext_csd {
 	unsigned int            data_tag_unit_size;     /* DATA TAG UNIT size */
 	unsigned int		boot_ro_lock;		/* ro lock support */
 	bool			boot_ro_lockable;
-	u8			raw_exception_status;	/* 53 */
-	u8			raw_partition_support;	/* 160 */
-	u8			raw_rpmb_size_mult;	/* 168 */
-	u8			raw_erased_mem_count;	/* 181 */
-	u8			raw_ext_csd_structure;	/* 194 */
-	u8			raw_card_type;		/* 196 */
-	u8			out_of_int_time;	/* 198 */
-	u8			raw_s_a_timeout;		/* 217 */
-	u8			raw_hc_erase_gap_size;	/* 221 */
-	u8			raw_erase_timeout_mult;	/* 223 */
-	u8			raw_hc_erase_grp_size;	/* 224 */
-	u8			raw_sec_trim_mult;	/* 229 */
-	u8			raw_sec_erase_mult;	/* 230 */
-	u8			raw_sec_feature_support;/* 231 */
-	u8			raw_trim_mult;		/* 232 */
-	u8			raw_bkops_status;	/* 246 */
-	u8			raw_sectors[4];		/* 212 - 4 bytes */
+	u8			raw_exception_status;	/* EXT_CSD_EXP_EVENTS_STATUS */
+	u8			raw_partition_support;	/* EXT_CSD_PARTITION_SUPPORT */
+	u8			raw_rpmb_size_mult;	/* EXT_CSD_RPMB_MULT */
+	u8			raw_erased_mem_count;	/* EXT_CSD_ERASED_MEM_CONT */
+	u8			raw_ext_csd_structure;	/* EXT_CSD_STRUCTURE */
+	u8			raw_card_type;		/* EXT_CSD_CARD_TYPE */
+	u8			out_of_int_time;	/* EXT_CSD_OUT_OF_INTERRUPT_TIME */
+	u8			raw_s_a_timeout;	/* EXT_CSD_S_A_TIMEOUT */
+	u8			raw_hc_erase_gap_size;	/* EXT_CSD_HC_WP_GRP_SIZE */
+	u8			raw_erase_timeout_mult;	/* EXT_CSD_ERASE_TIMEOUT_MULT */
+	u8			raw_hc_erase_grp_size;	/* EXT_CSD_HC_ERASE_GRP_SIZE */
+	u8			raw_sec_trim_mult;	/* EXT_CSD_SEC_TRIM_MULT */
+	u8			raw_sec_erase_mult;	/* EXT_CSD_SEC_ERASE_MULT */
+	u8			raw_sec_feature_support;/* EXT_CSD_SEC_FEATURE_SUPPORT */
+	u8			raw_trim_mult;		/* EXT_CSD_TRIM_MULT */
+	u8			raw_bkops_status;	/* EXT_CSD_BKOPS_STATUS */
+	u8			raw_sectors[4];		/* EXT_CSD_SEC_CNT - 4 bytes */
 
 	unsigned int            feature_support;
 #define MMC_DISCARD_FEATURE	BIT(0)                  /* CMD38 feature */
Signature · 1 line
1.7.10.4
#4 lore raw
In reply to Konstantin Dorfman

Hi,

Quoted 5 lines · Konstantin Dorfman

May be it is worth to change all this struct comments to be:

u8 raw_exception_status; /* EXT_CSD_EXP_EVENTS_STATUS */

This will reference actual offset value from "include/linux/mmc/mmc.h"

I think I prefer having the literal numbers accessible, even though it duplicates data, so I've taken Zhang's original patch for now.

Thanks,

- Chris.

Signature · 2 lines
Chris Ball   <[email protected]>   <http://printf.net/>
One Laptop Per Child