Skip to contentSkip to conversation

ARM: DTS: exynos5250-arndale: Add initial board support file

PATCH New Tushar Behera 3 participants 5 messages Jan 24, 2013

Subsystems (3)
Device tree bindings Arm Samsung Exynos Arm and arm64 SoC sub-architectures (common parts)
lore
Share & tools
lore

Tushar Behera

author
#0 lore raw

PATCH 1/1 ARM: DTS: exynos5250-arndale: Add initial board support file

From: Girish K S <[email protected]>

Arndale is a low cost board based on the Samsung Exynos5250 SoC. This patch adds initial device tree support for this board.

Signed-off-by Girish K S <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/boot/dts/Makefile               |    1 +
 arch/arm/boot/dts/exynos5250-arndale.dts |  124 ++++++++++++++++++++++++++++++
 2 files changed, 125 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5250-arndale.dts
arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..60a9e52 100644
@@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
 	exynos4210-trats.dtb \
 	exynos4412-smdk4412.dtb \
 	exynos5250-smdk5250.dtb \
+	exynos5250-arndale.dtb \
 	exynos5250-snow.dtb \
 	exynos5440-ssdk5440.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
arch/arm/boot/dts/exynos5250-arndale.dts new file +124 -0

124 lines not on this page · raw message

Signature · 1 line
1.7.4.1
#1 lore raw

PATCH 1/1 ARM: DTS: exynos5250-arndale: Add initial board support file

Hi Tushar,

Just a couple of minor comments.

Quoted 18 lines · Tushar Behera

From: Girish K S <[email protected]>

Arndale is a low cost board based on the Samsung Exynos5250 SoC. This patch adds initial device tree support for this board.

Signed-off-by Girish K S <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/boot/dts/Makefile               |    1 +
 arch/arm/boot/dts/exynos5250-arndale.dts |  124 ++++++++++++++++++++++++++++++
 2 files changed, 125 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5250-arndale.dts
arch/arm/boot/dts/Makefile +0 -0
index 5ebb44f..60a9e52 100644

arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \ · line 47

Quoted 4 lines
arch/arm/boot/dts/Makefile +1 -0
@@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
        exynos4210-trats.dtb \
        exynos4412-smdk4412.dtb \
        exynos5250-smdk5250.dtb \
+       exynos5250-arndale.dtb \

I think this entry could be moved one step up for maintaining alphabetical order.

arch/arm/boot/dts/exynos5250-arndale.dts line 4

Quoted 13 lines
arch/arm/boot/dts/Makefile +0 -0
        exynos5250-snow.dtb \
        exynos5440-ssdk5440.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
arch/arm/boot/dts/exynos5250-arndale.dts new file +4 -0
new file mode 100644
index 0000000..7504cf3
@@ -0,0 +1,124 @@
+/*
+ * Samsung's Exynos5250 based Arndale board device tree source
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.

2013?

Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +10 -0
+ *             http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ "exynos5250.dtsi"
+

arch/arm/boot/dts/exynos5250-arndale.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +10 -0
+/ {
+       model = "Insignal Arndale evaluation board based on EXYNOS5250";
+       compatible = "insignal,arndale", "samsung,exynos5250";
+
+       memory {
+               reg = <0x40000000 0x80000000>;
+       };
+
+       chosen {
+               bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";

This could be resticted only to console

                bootargs = "console=ttySAC2,115200";
Quoted 107 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +100 -1
+       };
+
+       i2c at 12C60000 {
+               status = "disabled";
+       };
+
+       i2c at 12C70000 {
+               status = "disabled";
+       };
+
+       i2c at 12C80000 {
+               status = "disabled";
+       };
+
+       i2c at 12C90000 {
+               status = "disabled";
+       };
+
+       i2c at 12CA0000 {
+               status = "disabled";
+       };
+
+       i2c at 12CB0000 {
+               status = "disabled";
+       };
+
+       i2c at 12CC0000 {
+               status = "disabled";
+       };
+
+       i2c at 12CD0000 {
+               status = "disabled";
+       };
+
+       i2c at 121D0000 {
+               status = "disabled";
+       };
+
+       dwmmc_0: dwmmc0 at 12200000 {
+               num-slots = <1>;
+               supports-highspeed;
+               broken-cd;
+               fifo-depth = <0x80>;
+               card-detect-delay = <200>;
+               samsung,dw-mshc-ciu-div = <3>;
+               samsung,dw-mshc-sdr-timing = <2 3>;
+               samsung,dw-mshc-ddr-timing = <1 2>;
+
+               slot at 0 {
+                       reg = <0>;
+                       bus-width = <8>;
+                       gpios = <&gpc0 0 2 0 3>, <&gpc0 1 2 0 3>,
+                               <&gpc1 0 2 3 3>, <&gpc1 1 2 3 3>,
+                               <&gpc1 2 2 3 3>, <&gpc1 3 2 3 3>,
+                               <&gpc0 3 2 3 3>, <&gpc0 4 2 3 3>,
+                               <&gpc0 5 2 3 3>, <&gpc0 6 2 3 3>;
+               };
+       };
+
+       dwmmc_1: dwmmc1 at 12210000 {
+               status = "disabled";
+       };
+
+       dwmmc_2: dwmmc2 at 12220000 {
+               num-slots = <1>;
+               supports-highspeed;
+               fifo-depth = <0x80>;
+               card-detect-delay = <200>;
+               samsung,dw-mshc-ciu-div = <3>;
+               samsung,dw-mshc-sdr-timing = <2 3>;
+               samsung,dw-mshc-ddr-timing = <1 2>;
+
+               slot at 0 {
+                       reg = <0>;
+                       bus-width = <4>;
+                       samsung,cd-pinmux-gpio = <&gpc3 2 2 3 3>;
+                       gpios = <&gpc3 0 2 0 3>, <&gpc3 1 2 0 3>,
+                               <&gpc3 3 2 3 3>, <&gpc3 4 2 3 3>,
+                               <&gpc3 5 2 3 3>, <&gpc3 6 2 3 3>,
+                               <&gpc4 3 3 3 3>, <&gpc4 3 3 3 3>,
+                               <&gpc4 5 3 3 3>, <&gpc4 6 3 3 3>;
+               };
+       };
+
+       dwmmc_3: dwmmc3 at 12230000 {
+               status = "disabled";
+       };
+
+       spi_0: spi at 12d20000 {
+               status = "disabled";
+       };
+
+       spi_1: spi at 12d30000 {
+               status = "disabled";
+       };
+
+       spi_2: spi at 12d40000 {
+               status = "disabled";
+       };
+};
--

1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
With warm regards,
Sachin
author
#2 lore raw

PATCH 1/1 ARM: DTS: exynos5250-arndale: Add initial board support file

Quoted 4 lines · Sachin Kamat
Quoted 4 lines
arch/arm/boot/dts/Makefile +0 -0
index 5ebb44f..60a9e52 100644
Quoted 9 lines

arch/arm/boot/dts/Makefile dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \ · line 47

Quoted 5 lines
arch/arm/boot/dts/Makefile +1 -0
@@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
        exynos4210-trats.dtb \
        exynos4412-smdk4412.dtb \
        exynos5250-smdk5250.dtb \
+       exynos5250-arndale.dtb \

I think this entry could be moved one step up for maintaining alphabetical order.

Ok.

Quoted 7 lines
Quoted 7 lines
arch/arm/boot/dts/Makefile +0 -0
        exynos5250-snow.dtb \
        exynos5440-ssdk5440.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
arch/arm/boot/dts/exynos5250-arndale.dts new file +0 -1
new file mode 100644
index 0000000..7504cf3
--- /dev/null
Quoted 9 lines

arch/arm/boot/dts/exynos5250-arndale.dts line 4

Quoted 6 lines

+++ b/arch/arm/boot/dts/exynos5250-arndale.dts

arch/arm/boot/dts/exynos5250-arndale.dts new file +4 -0
@@ -0,0 +1,124 @@
+/*
+ * Samsung's Exynos5250 based Arndale board device tree source
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.

2013?

Ok.

Quoted 22 lines
Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +10 -0
+ *             http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ "exynos5250.dtsi"
+

arch/arm/boot/dts/exynos5250-arndale.dts line 24

Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +10 -0
+/ {
+       model = "Insignal Arndale evaluation board based on EXYNOS5250";
+       compatible = "insignal,arndale", "samsung,exynos5250";
+
+       memory {
+               reg = <0x40000000 0x80000000>;
+       };
+
+       chosen {
+               bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";

This could be resticted only to console

Quoted 3 lines
                bootargs = "console=ttySAC2,115200";

Ok.

I will resubmit the patchset.

Signature · 1 line
Tushar Behera
#3 lore raw

PATCH 1/1 ARM: DTS: exynos5250-arndale: Add initial board support file

In reply to Tushar Behera

Hi Tushar,

Quoted 83 lines · Tushar Behera

From: Girish K S <[email protected]>

Arndale is a low cost board based on the Samsung Exynos5250 SoC. This patch adds initial device tree support for this board.

Signed-off-by Girish K S <[email protected]>
Signed-off-by Tushar Behera <[email protected]>
---
 arch/arm/boot/dts/Makefile               |    1 +
 arch/arm/boot/dts/exynos5250-arndale.dts |  124 ++++++++++++++++++++++++++++++
 2 files changed, 125 insertions(+), 0 deletions(-)
 create mode 100644 arch/arm/boot/dts/exynos5250-arndale.dts
arch/arm/boot/dts/Makefile +1 -0
index 5ebb44f..60a9e52 100644
@@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_EXYNOS) += exynos4210-origen.dtb \
        exynos4210-trats.dtb \
        exynos4412-smdk4412.dtb \
        exynos5250-smdk5250.dtb \
+       exynos5250-arndale.dtb \
        exynos5250-snow.dtb \
        exynos5440-ssdk5440.dtb
 dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
arch/arm/boot/dts/exynos5250-arndale.dts new file +52 -0
new file mode 100644
index 0000000..7504cf3
@@ -0,0 +1,124 @@
+/*
+ * Samsung's Exynos5250 based Arndale board device tree source
+ *
+ * Copyright (c) 2012 Samsung Electronics Co., Ltd.
+ *             http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ "exynos5250.dtsi"
+
+/ {
+       model = "Insignal Arndale evaluation board based on EXYNOS5250";
+       compatible = "insignal,arndale", "samsung,exynos5250";
+
+       memory {
+               reg = <0x40000000 0x80000000>;
+       };
+
+       chosen {
+               bootargs = "root=/dev/ram0 rw ramdisk=8192 initrd=0x41000000,8M console=ttySAC2,115200 init=/linuxrc";
+       };
+
+       i2c at 12C60000 {
+               status = "disabled";
+       };
+
+       i2c at 12C70000 {
+               status = "disabled";
+       };
+
+       i2c at 12C80000 {
+               status = "disabled";
+       };
+
+       i2c at 12C90000 {
+               status = "disabled";
+       };
+
+       i2c at 12CA0000 {
+               status = "disabled";
+       };
+
+       i2c at 12CB0000 {
+               status = "disabled";
+       };
+
+       i2c at 12CC0000 {
+               status = "disabled";

arch/arm/boot/dts/exynos5250-arndale.dts line 62

Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +10 -0
+       };
+
+       i2c at 12CD0000 {
+               status = "disabled";
+       };
+
+       i2c at 121D0000 {
+               status = "disabled";
+       };
+

Why to disable these i2c devices here? Any particular reason? You can moves these to exynos5250.dtsi which is suppose to be common for all the exynos5250 platforms.
Please see the exynos4.dtsi for reference.

Quoted 51 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +51 -0
+       dwmmc_0: dwmmc0 at 12200000 {
+               num-slots = <1>;
+               supports-highspeed;
+               broken-cd;
+               fifo-depth = <0x80>;
+               card-detect-delay = <200>;
+               samsung,dw-mshc-ciu-div = <3>;
+               samsung,dw-mshc-sdr-timing = <2 3>;
+               samsung,dw-mshc-ddr-timing = <1 2>;
+
+               slot at 0 {
+                       reg = <0>;
+                       bus-width = <8>;
+                       gpios = <&gpc0 0 2 0 3>, <&gpc0 1 2 0 3>,
+                               <&gpc1 0 2 3 3>, <&gpc1 1 2 3 3>,
+                               <&gpc1 2 2 3 3>, <&gpc1 3 2 3 3>,
+                               <&gpc0 3 2 3 3>, <&gpc0 4 2 3 3>,
+                               <&gpc0 5 2 3 3>, <&gpc0 6 2 3 3>;
+               };
+       };
+
+       dwmmc_1: dwmmc1 at 12210000 {
+               status = "disabled";
+       };
+
+       dwmmc_2: dwmmc2 at 12220000 {
+               num-slots = <1>;
+               supports-highspeed;
+               fifo-depth = <0x80>;
+               card-detect-delay = <200>;
+               samsung,dw-mshc-ciu-div = <3>;
+               samsung,dw-mshc-sdr-timing = <2 3>;
+               samsung,dw-mshc-ddr-timing = <1 2>;
+
+               slot at 0 {
+                       reg = <0>;
+                       bus-width = <4>;
+                       samsung,cd-pinmux-gpio = <&gpc3 2 2 3 3>;
+                       gpios = <&gpc3 0 2 0 3>, <&gpc3 1 2 0 3>,
+                               <&gpc3 3 2 3 3>, <&gpc3 4 2 3 3>,
+                               <&gpc3 5 2 3 3>, <&gpc3 6 2 3 3>,
+                               <&gpc4 3 3 3 3>, <&gpc4 3 3 3 3>,
+                               <&gpc4 5 3 3 3>, <&gpc4 6 3 3 3>;
+               };
+       };
+
+       dwmmc_3: dwmmc3 at 12230000 {
+               status = "disabled";
+       };
+
+       spi_0: spi at 12d20000 {

arch/arm/boot/dts/exynos5250-arndale.dts line 123

Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +10 -0
+               status = "disabled";
+       };
+
+       spi_1: spi at 12d30000 {
+               status = "disabled";
+       };
+
+       spi_2: spi at 12d40000 {
+               status = "disabled";
+       };

Same as above.

Quoted 8 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +1 -1
+};
--

1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html

Signature · 2 lines
Regards,
Alim
author
#4 lore raw

PATCH 1/1 ARM: DTS: exynos5250-arndale: Add initial board support file

Quoted 10 lines · Alim Akhtar
Quoted 10 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +10 -0
+
+       i2c at 12CC0000 {
+               status = "disabled";
+       };
+
+       i2c at 12CD0000 {
+               status = "disabled";
+       };
+
+       i2c at 121D0000 {
Quoted 9 lines

arch/arm/boot/dts/exynos5250-arndale.dts line 30

Quoted 3 lines
arch/arm/boot/dts/exynos5250-arndale.dts new file +3 -0
+               status = "disabled";
+       };
+

Why to disable these i2c devices here? Any particular reason? You can moves these to exynos5250.dtsi which is suppose to be common for all the exynos5250 platforms.
Please see the exynos4.dtsi for reference.

Agreed. There was a discussion going on in [1] related to this. Since there was no consensus on that, I preferred to go with the current approach that is followed for other EXYNOS5250 based scripts.

If it is agreed by Kukjin to move to Exynos4 style, then I can submit patches for that.

[1]
http://www.mail-archive.com/linux-samsung-soc at vger.kernel.org/msg15013.html

Signature · 1 line
Tushar Behera