ci: reduce examples built for static builds
RFC PATCH 1/1 ci: reduce examples built for static builds
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds.
--- .ci/linux-build.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
.ci/linux-build.sh +7 -1
@@ -42,9 +42,15 @@ if [ "$BUILD_32BIT" = "1" ]; then export PKG_CONFIG_LIBDIR="/usr/lib32/pkgconfig" fi +if [ "$DEF_LIB" = "static" ] ; then + OPTS="$OPTS -Dexamples=l2fwd,l3fwd" +else + OPTS="$OPTS -Dexamples=all" +fi + OPTS="$OPTS --default-library=$DEF_LIB" OPTS="$OPTS --buildtype=debugoptimized" -meson build --werror -Dexamples=all $OPTS +meson build --werror $OPTS ninja -C build if [ "$AARCH64" != "1" ]; then
Signature · 1 line
2.24.1
Quoted 5 lines · Bruce Richardson
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds.
Signed-off-by Bruce Richardson <[email protected]>---
It looks good to me. I'll try a run with Ruifeng's no-huge series and see if I can trigger errors on my side (and then see what happens with the cache sizes, too). Might take some time as I adjust some things here.
Quoted 24 lines
.ci/linux-build.sh | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-).ci/linux-build.sh +7
-1@@ -42,9 +42,15 @@ if [ "$BUILD_32BIT" = "1" ]; then export PKG_CONFIG_LIBDIR="/usr/lib32/pkgconfig" fi +if [ "$DEF_LIB" = "static" ] ; then + OPTS="$OPTS -Dexamples=l2fwd,l3fwd" +else + OPTS="$OPTS -Dexamples=all" +fi + OPTS="$OPTS --default-library=$DEF_LIB" OPTS="$OPTS --buildtype=debugoptimized" -meson build --werror -Dexamples=all $OPTS +meson build --werror $OPTS ninja -C build if [ "$AARCH64" != "1" ]; then
Quoted 6 lines · Aaron Conole
Quoted 3 lines · Bruce Richardson
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds.
Quoted 7 lines
Quoted 2 lines
Signed-off-by Bruce Richardson <[email protected]>---
It looks good to me. I'll try a run with Ruifeng's no-huge series and see if I can trigger errors on my side (and then see what happens with the cache sizes, too). Might take some time as I adjust some things here.
- The disk quota issue was reproduced on master without Ruifeng patches:
https://travis-ci.com/github/DPDK/dpdk/jobs/298584616
https://travis-ci.com/github/DPDK/dpdk/jobs/298858638
And for this, the cache is not really big. cache-arm64-linux-bionic-a550182015679db90d1e0a2460464d106712e1c2c29f3efc7db1dc1b6fd86ebb--compiler-gcc.tgz
last modified: 2020-03-16 11:28:59 size: 160.84 MiB
I remember bigger caches in the past.
I deleted this job cache and restarted the first job, and it passed. Restarted again, and then it failed o_O.
- So I went and restarted a couple of times both of those jobs (leaving the cache as is, which now contains 60MB of data). I get random failures.
It does not seem to depend on the system: it failed once on [email protected], then worked later.
hostname: [email protected]: KO
hostname: [email protected]: ok
hostname: [email protected]: ok
hostname: [email protected]: ok
hostname: [email protected]: ok
hostname: [email protected]: KO
hostname: [email protected]: ok
hostname: [email protected]: ok
hostname: [email protected]: KO
hostname: [email protected]: ok
Signature · 1 line
David Marchand
Quoted 10 lines · David Marchand
Quoted 9 lines · Aaron Conole
Quoted 5 lines · Bruce Richardson
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds.
Signed-off-by Bruce Richardson <[email protected]>---
Quoted 8 lines
Quoted 4 lines
It looks good to me. I'll try a run with Ruifeng's no-huge series and see if I can trigger errors on my side (and then see what happens with the cache sizes, too). Might take some time as I adjust some things here.
- The disk quota issue was reproduced on master without Ruifeng patches:
https://travis-ci.com/github/DPDK/dpdk/jobs/298584616
https://travis-ci.com/github/DPDK/dpdk/jobs/298858638
Okay - guess I should just ack those patches, then. They look good otherwise.
Quoted 10 lines
And for this, the cache is not really big. cache-arm64-linux-bionic-a550182015679db90d1e0a2460464d106712e1c2c29f3efc7db1dc1b6fd86ebb--compiler-gcc.tgz
last modified: 2020-03-16 11:28:59 size: 160.84 MiB
I remember bigger caches in the past.I deleted this job cache and restarted the first job, and it passed. Restarted again, and then it failed
o_O.
Quoted 6 lines
- So I went and restarted a couple of times both of those jobs (leaving the cache as is, which now contains 60MB of data). I get random failures.
It does not seem to depend on the system: it failed once on [email protected], then worked later.
Seems it's all arm64 builds that are failing. I went to file an issue, but looks like you beat me to it :)
https://travis-ci.community/t/disk-quota-exceeded-on-arm64/7619
I'll help promote the issue however I can
Quoted 11 lines
hostname: [email protected]: KO
hostname: [email protected]: ok
hostname: [email protected]: ok
hostname: [email protected]: ok
hostname: [email protected]: okhostname: [email protected]: KO
hostname: [email protected]: ok
hostname: [email protected]: ok
hostname: [email protected]: KO
hostname: [email protected]: ok
16/03/2020 18:09, Bruce Richardson:
.ci/linux-build.sh if [ "$BUILD_32BIT" = "1" ]; then · line 49
Quoted 12 lines
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds.
Signed-off-by Bruce Richardson <[email protected]>---
.ci/linux-build.sh +5
-0+if [ "$DEF_LIB" = "static" ] ; then + OPTS="$OPTS -Dexamples=l2fwd,l3fwd" +else + OPTS="$OPTS -Dexamples=all" +fi
I was thinking about doing this kind of change in devtools/test-meson-builds.sh What do you think?
Quoted 4 lines · Thomas Monjalon
16/03/2020 18:09, Bruce Richardson:
Quoted 3 lines
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds.
Quoted 13 lines
.ci/linux-build.sh if [ "$BUILD_32BIT" = "1" ]; then · line 49
Quoted 9 lines
Signed-off-by Bruce Richardson <[email protected]>---
.ci/linux-build.sh +5
-0+if [ "$DEF_LIB" = "static" ] ; then + OPTS="$OPTS -Dexamples=l2fwd,l3fwd" +else + OPTS="$OPTS -Dexamples=all" +fiI was thinking about doing this kind of change in
devtools/test-meson-builds.shWhat do you think?
No major objection. It's probably less likely to be an issue for people running their own test-builds, though if it saves time and space and doesn't much affect the number of issues we are going to hit/miss, I don't see why not do so.
Thomas Monjalon
Applied16/03/2020 18:09, Bruce Richardson:
Quoted 4 lines
Static builds can take a lot of space, so reduce the number of examples built when doing those static builds.
Signed-off-by Bruce Richardson <[email protected]>
No objection after one month, it is a RFC but I see nothing to change.
Applied, thanks