Skip to contentSkip to conversation

arm: zynq: Add missing irqchip.h to common.c

PATCH New Michal Simek 4 participants 4 messages Jan 28, 2013 – Jan 29, 2013

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Zynq architecture
lore
Share & tools
lore

Michal Simek

author
#0 lore raw

PATCH 1/1 arm: zynq: Add missing irqchip.h to common.c

The patch: "ARM: use common irqchip_init for GIC init" (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) should also add linux/irqchip.h header.

Error message:
arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
undeclared here (not in a function)

Signed-off-by Michal Simek <[email protected]>
---
 arch/arm/mach-zynq/common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-zynq/common.c +1 -0
index 6472a69..cf3ec54 100644
@@ -24,6 +24,7 @@
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>
 #include <linux/of.h>
+#include <linux/irqchip.h>
 
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
Signature · 1 line
1.7.0.4
#1 lore raw

PATCH 1/1 arm: zynq: Add missing irqchip.h to common.c

Quoted 9 lines · Michal Simek

The patch: "ARM: use common irqchip_init for GIC init" (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) should also add linux/irqchip.h header.

Error message:
arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
undeclared here (not in a function)

Signed-off-by Michal Simek <[email protected]>

FYI, there's already a patch posted for this:

http://www.spinics.net/lists/arm-kernel/msg219556.html

Rob

Quoted 17 lines
---
 arch/arm/mach-zynq/common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-zynq/common.c +1 -0
index 6472a69..cf3ec54 100644
@@ -24,6 +24,7 @@
 #include <linux/of_irq.h>
 #include <linux/of_platform.h>
 #include <linux/of.h>
+#include <linux/irqchip.h>
 
 #include <asm/mach/arch.h>
 #include <asm/mach/map.h>
#2 lore raw

PATCH 1/1 arm: zynq: Add missing irqchip.h to common.c

Hi Rob,

2013/1/28 Rob Herring <[email protected]>:

Quoted 9 lines · Michal Simek
Quoted 8 lines

The patch: "ARM: use common irqchip_init for GIC init" (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) should also add linux/irqchip.h header.

Error message:
arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
undeclared here (not in a function)

Quoted 5 lines
Quoted 1 line
Signed-off-by Michal Simek <[email protected]>

FYI, there's already a patch posted for this:

http://www.spinics.net/lists/arm-kernel/msg219556.html

Interesting that I am completely ignored in CC. Anyway updated maintainer fragment hopefully resolve this.

Thanks,
Michal

Signature · 5 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
Applied
#3 lore raw

PATCH 1/1 arm: zynq: Add missing irqchip.h to common.c

In reply to Michal Simek
Quoted 9 lines · Michal Simek

The patch: "ARM: use common irqchip_init for GIC init" (sha1: 0529e315bbda5d502c93df2cfafba9bb337fbdf4) should also add linux/irqchip.h header.

Error message:
arch/arm/mach-zynq/common.c:99:14: error: 'irqchip_init'
undeclared here (not in a function)

Signed-off-by Michal Simek <[email protected]>

Applied.

-Olof