Skip to contentSkip to conversation

netfilter ip6table_mangle: Use ipv6_addr_equal() where appropriate.

PATCH Applied YOSHIFUJI Hideaki 2 participants 2 messages Jan 29, 2013 – Jan 30, 2013

Subsystems (3)
Networking Network drivers netfilter
lore
Share & tools
lore

YOSHIFUJI Hideaki

author
#0 lore raw

PATCH 4/5 netfilter ip6table_mangle: Use ipv6_addr_equal() where appropriate.

Signed-off-by YOSHIFUJI Hideaki <[email protected]>
---
 net/ipv6/netfilter/ip6table_mangle.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
net/ipv6/netfilter/ip6table_mangle.c +3 -2
index 7431121..6134a1e 100644
@@ -11,6 +11,7 @@
 #include <linux/module.h>
 #include <linux/netfilter_ipv6/ip6_tables.h>
 #include <linux/slab.h>
+#include <net/ipv6.h>
 
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Netfilter Core Team <[email protected]>");

@@ -60,8 +61,8 @@ ip6t_mangle_out(struct sk_buff *skb, const struct net_device *out)
 			    dev_net(out)->ipv6.ip6table_mangle);
 
 	if (ret != NF_DROP && ret != NF_STOLEN &&
-	    (memcmp(&ipv6_hdr(skb)->saddr, &saddr, sizeof(saddr)) ||
-	     memcmp(&ipv6_hdr(skb)->daddr, &daddr, sizeof(daddr)) ||
+	    (!ipv6_addr_equal(&ipv6_hdr(skb)->saddr, &saddr) ||
+	     !ipv6_addr_equal(&ipv6_hdr(skb)->daddr, &daddr) ||
 	     skb->mark != mark ||
 	     ipv6_hdr(skb)->hop_limit != hop_limit ||
 	     flowlabel != *((u_int32_t *)ipv6_hdr(skb))))
Signature · 1 line
1.7.9.5