KEXEC: Get rid of duplicate check for hole_end
Subsystems (3)
PATCH 1/1 KEXEC: Get rid of duplicate check for hole_end
hole_end has been checked to make sure it is <= crash_res.end in the while condition check, so the if condition check is duplicate.
Signed-off-by Zhang Yanfei <[email protected]>
--- kernel/kexec.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
kernel/kexec.c +0 -2
@@ -497,8 +497,6 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,if (hole_end >KEXEC_CRASH_CONTROL_MEMORY_LIMIT )break ; -if (hole_end > crashk_res.end) -break ;/* See if I overlap any of the segments */ for (i =0 ; i < image->nr_segments; i++) {unsigned long mstart, mend;
Signature · 1 line
1.7.1
Quoted 2 lines · Zhang Yanfei
hole_endhas been checked to make sure it is <= crash_res.end in the while condition check, so the if condition check is duplicate.
That test is definitely a duplicate.
Reviewed-by "Eric W. Biederman" <[email protected]>
Quoted 18 lines
Signed-off-by Zhang Yanfei <[email protected]>--- kernel/kexec.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)kernel/kexec.c +0
-2@@ -497,8 +497,6 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,if (hole_end >KEXEC_CRASH_CONTROL_MEMORY_LIMIT )break ; -if (hole_end > crashk_res.end) -break ;/* See if I overlap any of the segments */ for (i =0 ; i < image->nr_segments; i++) {unsigned long mstart, mend;