Skip to contentSkip to conversation

ARM: dts: remove generated .dtb files on clean

PATCH New Nishanth Menon 3 participants 4 messages Jan 22, 2013 – Mar 1, 2013 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: remove generated .dtb files on clean

commit 5f300acd8ae9f3d4585154370012ffc5c665330f (ARM: 7152/1: distclean: Remove generated .dtb files) ensured that dtbs were cleaned up when they were in arch/arm/boot.
However, with the following commit:
commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8 (ARM: dt: change .dtb build rules to build in dts directory)

make clean now leaves dtbs in arch/arm/boot/dts/ untouched. Include dts directory so that clean-files rule from arch/arm/boot/dts/Makefile is invoked when make clean is done.

Cc Dirk Behme <[email protected]>
CC Grant Likely <[email protected]>
---
 arch/arm/boot/Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/Makefile +1 -1
index abfce28..3837f97 100644
@@ -115,4 +115,4 @@ i:
 	$(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
 	$(obj)/Image System.map "$(INSTALL_PATH)"
 
-subdir-	    := bootp compressed
+subdir-	    := bootp compressed dts
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: remove generated .dtb files on clean

Looping RMK, Arnd

Quoted 27 lines · Nishanth Menon

commit 5f300acd8ae9f3d4585154370012ffc5c665330f (ARM: 7152/1: distclean: Remove generated .dtb files) ensured that dtbs were cleaned up when they were in arch/arm/boot.
However, with the following commit:
commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8 (ARM: dt: change .dtb build rules to build in dts directory)

make clean now leaves dtbs in arch/arm/boot/dts/ untouched. Include dts directory so that clean-files rule from arch/arm/boot/dts/Makefile is invoked when make clean is done.

Cc Dirk Behme <[email protected]>
CC Grant Likely <[email protected]>
---
  arch/arm/boot/Makefile |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/Makefile +0 -0
index abfce28..3837f97 100644

arch/arm/boot/Makefile i: · line 118

Quoted 5 lines
arch/arm/boot/Makefile +1 -1
@@ -115,4 +115,4 @@ i:
  	$(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
  	$(obj)/Image System.map "$(INSTALL_PATH)"
 
-subdir-	    := bootp compressed
+subdir-	    := bootp compressed dts

Seems to be the valid fix for me.

Regards,
Santosh

#2 lore raw
Quoted 1 line · Santosh Shilimkar

Looping RMK, Arnd

Gentle query if we are still interested in this:
https://patchwork.kernel.org/patch/2020831/

Looks like linux master still wont delete the dtbs on make clean etc.. I think leaving the stale dtbs
around could have it's set of user errors.
Regards,
Nishanth Menon

Quoted 47 lines · Nishanth Menon
Quoted 28 lines

commit 5f300acd8ae9f3d4585154370012ffc5c665330f (ARM: 7152/1: distclean: Remove generated .dtb files) ensured that dtbs were cleaned up when they were in arch/arm/boot.
However, with the following commit:
commit 499cd8298628eeabf0eb5eb6525d4faa0eec80d8 (ARM: dt: change .dtb build rules to build in dts directory)

make clean now leaves dtbs in arch/arm/boot/dts/ untouched. Include dts directory so that clean-files rule from arch/arm/boot/dts/Makefile is invoked when make clean is done.

Cc Dirk Behme <[email protected]>
CC Grant Likely <[email protected]>
---
  arch/arm/boot/Makefile |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/Makefile +0 -0
index abfce28..3837f97 100644

arch/arm/boot/Makefile i: · line 118

Quoted 5 lines
arch/arm/boot/Makefile +1 -1
@@ -115,4 +115,4 @@ i:
        $(CONFIG_SHELL) $(srctree)/$(src)/install.sh $(KERNELRELEASE) \
        $(obj)/Image System.map "$(INSTALL_PATH)"
 
-subdir-            := bootp compressed
+subdir-            := bootp compressed dts

Seems to be the valid fix for me.

Regards,
Santosh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#3 lore raw
Quoted 9 lines · Nishanth Menon
Quoted 1 line · Santosh Shilimkar

Looping RMK, Arnd

Gentle query if we are still interested in this:
https://patchwork.kernel.org/patch/2020831/

Looks like linux master still wont delete the dtbs on make clean etc.. I think leaving the stale dtbs
around could have it's set of user errors.

Applied to arm-soc fixes for 3.9.

-Olof