Skip to contentSkip to conversation

ARM: omap4: clock data: Add missing clkdm association for dpll_usb

PATCH Superseded Rajendra Nayak 2 participants 4 messages Jan 25, 2013 – Jan 31, 2013

Subsystems (4)
Arm (32-bit) Arm sub-architectures OMAP2+ support OMAP clock framework support

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Rajendra Nayak

author
#0 lore raw

PATCH 1/1 ARM: omap4: clock data: Add missing clkdm association for dpll_usb

dpll_usb needs the clkdm association so the clkdm can be turned on before a relock. All other dplls for omap4 belong to the ALWON (always on) domain.

The association was present as part of the older data file (clock44xx_data.c) but looks like was accidently dropped with the common clk convertion.

More details of the patch which fixed this up in the older data file can be dound here..
http://www.spinics.net/lists/linux-omap/msg63076.html

Signed-off-by Rajendra Nayak <[email protected]>
---
 arch/arm/mach-omap2/cclock44xx_data.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/mach-omap2/cclock44xx_data.c +1 -0
index 5789a5e..fdea8da 100644
@@ -601,6 +601,7 @@ static struct clk_hw_omap dpll_usb_ck_hw = {
 	},
 	.dpll_data	= &dpll_usb_dd,
 	.ops		= &clkhwops_omap3_dpll,
+	.clkdm_name	= "l3_init_clkdm",
 };
 
 DEFINE_STRUCT_CLK(dpll_usb_ck, dpll_usb_ck_parents, dpll_ck_ops);
Signature · 1 line
1.7.9.5
maintainer
#1 lore raw

PATCH 1/1 ARM: omap4: clock data: Add missing clkdm association for dpll_usb

Quoted 7 lines · Rajendra Nayak

dpll_usb needs the clkdm association so the clkdm can be turned on before a relock. All other dplls for omap4 belong to the ALWON (always on) domain.

The association was present as part of the older data file (clock44xx_data.c) but looks like was accidently dropped with the common clk convertion.

Thanks, queued for v3.8-rc fixes.

- Paul

author
#2 lore raw

PATCH 1/1 ARM: omap4: clock data: Add missing clkdm association for dpll_usb

Hi Paul,

Quoted 9 lines
Quoted 7 lines

dpll_usb needs the clkdm association so the clkdm can be turned on before a relock. All other dplls for omap4 belong to the ALWON (always on) domain.

The association was present as part of the older data file (clock44xx_data.c) but looks like was accidently dropped with the common clk convertion.

Thanks, queued for v3.8-rc fixes.

I just realized that apart from adding the missing .clkdm_name, I also need to populate a .init as part of clk_ops for dpll_usb so the clockdomain lookup can then happen based on the .clkdm_name.

I have updated the $Subject patch and posted a v2 (http://marc.info
/?l=linux-omap&m=135963212530790&w=2). Would it be possible for you to pick the v2 instead and drop this one from your fixes branch.

regards,
Rajendra

Quoted 3 lines

- Paul

maintainer
#3 lore raw

PATCH 1/1 ARM: omap4: clock data: Add missing clkdm association for dpll_usb

Quoted 12 lines · Rajendra Nayak

Hi Paul,

Quoted 9 lines
Quoted 7 lines

dpll_usb needs the clkdm association so the clkdm can be turned on before a relock. All other dplls for omap4 belong to the ALWON (always on) domain.

The association was present as part of the older data file (clock44xx_data.c) but looks like was accidently dropped with the common clk convertion.

Thanks, queued for v3.8-rc fixes.

Quoted 7 lines

I just realized that apart from adding the missing .clkdm_name, I also need to populate a .init as part of clk_ops for dpll_usb so the clockdomain lookup can then happen based on the .clkdm_name.

I have updated the $Subject patch and posted a v2 (http://marc.info
/?l=linux-omap&m=135963212530790&w=2). Would it be possible for you to pick the v2 instead and drop this one from your fixes branch.

No problem.

- Paul