Skip to contentSkip to conversation

openvswtich: start openvswitch at the boot time

PATCH In review [email protected] 2 participants 4 messages Jan 31, 2013 – Feb 1, 2013

lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 openvswtich: start openvswitch at the boot time

From: Lei Yang <[email protected]>

When I define the bridge, I get below error

root@intel_5500_server:~# ovs-vsctl add-br ovsbr0
Jan 25 17:34:07|00002|stream_unix|ERR|/tmp/stream-unix.1487.0: connection to /var/run/openvswitch/db.sock
failed: No such file or directory
........
........

This is because openvswitch damon isn't running,so we'd better start it at the boot time. The split-pacakage ${PN}-switch ${PN}-controller provide us to start nessary damon with update-rc.d so we add them to the RDEPENDS.

Since openvswtich depends on openvswtich kernel module,so auto load the kernel module too.

Signed-off-by Lei Yang <[email protected]>
Tested-by Lei Yang <[email protected]>
---
 recipes-kernel/linux/linux-yocto_3.4.bbappend      |    2 +-
 .../openvswitch/openvswitch_1.4.3.bb               |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes-kernel/linux/linux-yocto_3.4.bbappend +1 -1
index 5b163ff..918302a 100644
@@ -5,4 +5,4 @@ SRC_URI += "file://xt-checksum.scc \
 	    file://vswitch.scc \
 	    file://lxc.scc \
 	    "
-
+module_autoload_openvswitch = "openvswitch"
recipes-networking/openvswitch/openvswitch_1.4.3.bb +1 -1
index 88f0114..6764073 100644
@@ -7,7 +7,7 @@ LICENSE = "Apache-2"
 DEPENDS += "bridge-utils openssl python perl"
 
 RDEPENDS_${PN} += "util-linux-uuidgen util-linux-libuuid \
-	       python perl perl-module-strict"
+	       python perl perl-module-strict ${PN}-switch ${PN}-controller"
 RDEPENDS_${PN}-controller = "${PN} lsb ${PN}-pki"
 RDEPENDS_${PN}-switch = "${PN} openssl procps util-linux-uuidgen"
 RDEPENDS_${PN}-pki = "${PN}"
Signature · 1 line
1.7.1
#1 lore raw
Quoted 11 lines · On Thu, Jan 31, 2013 at 2:18 AM, <[email protected]> wrote:

From: Lei Yang <[email protected]>

When I define the bridge, I get below error

root@intel_5500_server:~# ovs-vsctl add-br ovsbr0
Jan 25 17:34:07|00002|stream_unix|ERR|/tmp/stream-unix.1487.0: connection
to /var/run/openvswitch/db.sock
failed: No such file or directory
........
........
Quoted 5 lines

This is because openvswitch damon isn't running,so we'd better start it at the boot time.
The split-pacakage ${PN}-switch ${PN}-controller provide us to start nessary damon with update-rc.d

s/pacakage/package/
s/nessary/necessary/
s/damon/daemon/

Quoted 5 lines

so we add them to the RDEPENDS.

Since openvswtich depends on openvswtich kernel module,so auto load the kernel module too.

s/openvswtich/openvswitch/

Quoted 4 lines
Signed-off-by Lei Yang <[email protected]>
Tested-by Lei Yang <[email protected]>

We can drop the Tested-by: since it is your patch :)

I can make the changes below if you agree with them, and save us another revision
of the patch.

Cheers,

Bruce

Quoted 35 lines
---
 recipes-kernel/linux/linux-yocto_3.4.bbappend      |    2 +-
 .../openvswitch/openvswitch_1.4.3.bb               |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
recipes-kernel/linux/linux-yocto_3.4.bbappend +1 -1
index 5b163ff..918302a 100644
@@ -5,4 +5,4 @@ SRC_URI += "file://xt-checksum.scc \
            file://vswitch.scc \
            file://lxc.scc \
            "
-
+module_autoload_openvswitch = "openvswitch"
(quoted diff) +0 -0

openvswitch_1.4.3.bb
index 88f0114..6764073 100644

recipes-networking/openvswitch/openvswitch_1.4.3.bb +1 -1
@@ -7,7 +7,7 @@ LICENSE = "Apache-2"
 DEPENDS += "bridge-utils openssl python perl"
 
 RDEPENDS_${PN} += "util-linux-uuidgen util-linux-libuuid \
-              python perl perl-module-strict"
+              python perl perl-module-strict ${PN}-switch

${PN}-controller"
RDEPENDS_${PN}-controller = "${PN} lsb ${PN}-pki" RDEPENDS_${PN}-switch = "${PN} openssl procps util-linux-uuidgen" RDEPENDS_${PN}-pki = "${PN}"
--
1.7.1

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"
author
#2 lore raw
Quoted 38 lines · Bruce Ashfield

On Thu, Jan 31, 2013 at 2:18 AM, <[email protected] <mailto:[email protected]>> wrote:

From: Lei Yang <[email protected]
<mailto:[email protected]>>

When I define the bridge, I get below error

root@intel_5500_server:~# ovs-vsctl add-br ovsbr0 Jan 25 17:34:07|00002|stream_unix|ERR|/tmp/stream-unix.1487.0:
connection to /var/run/openvswitch/db.sock
failed: No such file or directory
........
........

This is because openvswitch damon isn't running,so we'd better start it at the boot time.
The split-pacakage ${PN}-switch ${PN}-controller provide us to start nessary damon with update-rc.d

s/pacakage/package/
s/nessary/necessary/
s/damon/daemon/

so we add them to the RDEPENDS.

Since openvswtich depends on openvswtich kernel module,so auto load the kernel module too.

s/openvswtich/openvswitch/

Signed-off-by Lei Yang <[email protected]

<mailto:[email protected]>>

Quoted 9 lines
Tested-by Lei Yang <[email protected]

<mailto:[email protected]>>

We can drop the Tested-by: since it is your patch :)

I can make the changes below if you agree with them, and save us another revision of the patch.

Agree, I don't trust "set spell" again in vim :-( , it doesn't help me for this spelling error

Lei

Quoted 48 lines

Cheers,

Bruce

    ---
     recipes-kernel/linux/linux-yocto_3.4.bbappend      |    2 +-
     .../openvswitch/openvswitch_1.4.3.bb
    <http://openvswitch_1.4.3.bb>               |    2 +-
     2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/recipes-kernel/linux/linux-yocto_3.4.bbappend
    b/recipes-kernel/linux/linux-yocto_3.4.bbappend
    index 5b163ff..918302a 100644
    --- a/recipes-kernel/linux/linux-yocto_3.4.bbappend
    +++ b/recipes-kernel/linux/linux-yocto_3.4.bbappend
    @@ -5,4 +5,4 @@ SRC_URI += "file://xt-checksum.scc \
                file://vswitch.scc \
                file://lxc.scc \
                "
    -
    +module_autoload_openvswitch = "openvswitch"
    diff --git a/recipes-networking/openvswitch/openvswitch_1.4.3.bb
    <http://openvswitch_1.4.3.bb>
    b/recipes-networking/openvswitch/openvswitch_1.4.3.bb
    <http://openvswitch_1.4.3.bb>
    index 88f0114..6764073 100644
    --- a/recipes-networking/openvswitch/openvswitch_1.4.3.bb
    <http://openvswitch_1.4.3.bb>
    +++ b/recipes-networking/openvswitch/openvswitch_1.4.3.bb
    <http://openvswitch_1.4.3.bb>
    @@ -7,7 +7,7 @@ LICENSE = "Apache-2"
     DEPENDS += "bridge-utils openssl python perl"

     RDEPENDS_${PN} += "util-linux-uuidgen util-linux-libuuid \
    -              python perl perl-module-strict"
    +              python perl perl-module-strict ${PN}-switch
    ${PN}-controller"
     RDEPENDS_${PN}-controller = "${PN} lsb ${PN}-pki"
     RDEPENDS_${PN}-switch = "${PN} openssl procps util-linux-uuidgen"
     RDEPENDS_${PN}-pki = "${PN}"
    --
    1.7.1
Signature · 1 line
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"
#3 lore raw
Quoted 49 lines · lei yang
Quoted 47 lines · Bruce Ashfield

On Thu, Jan 31, 2013 at 2:18 AM, <[email protected] <mailto:
[email protected]**>> wrote:

From: Lei Yang <[email protected]
<mailto:[email protected]**>>

When I define the bridge, I get below error

root@intel_5500_server:~# ovs-vsctl add-br ovsbr0
Jan 25 17:34:07|00002|stream_unix|**ERR|/tmp/stream-unix.1487.0:
connection to /var/run/openvswitch/db.sock
failed: No such file or directory
........
........

This is because openvswitch damon isn't running,so we'd better start it at the boot time.
The split-pacakage ${PN}-switch ${PN}-controller provide us to start nessary damon with update-rc.d

s/pacakage/package/
s/nessary/necessary/
s/damon/daemon/

so we add them to the RDEPENDS.

Since openvswtich depends on openvswtich kernel module,so auto load the kernel module too.

s/openvswtich/openvswitch/

Signed-off-by Lei Yang <[email protected]

<mailto:[email protected]**>>

Tested-by Lei Yang <[email protected]

<mailto:[email protected]**>>

We can drop the Tested-by: since it is your patch :)

Quoted 9 lines
Quoted 5 lines

I can make the changes below if you agree with them, and save us another revision
of the patch.

Agree, I don't trust "set spell" again in vim :-( , it doesn't help me for this spelling error

No worries, we all make spelling mistakes and typos.

I wrapped the commit message to 72 chars, fixed the few issues and pushed it to master.

Bruce

Quoted 59 lines

Lei

Cheers,

Quoted 52 lines

Bruce

    ---
     recipes-kernel/linux/linux-**yocto_3.4.bbappend      |    2 +-
     .../openvswitch/openvswitch_1.**4.3.bb <http://openvswitch_1.4.3.bb>
    <http://openvswitch_1.4.3.bb>               |    2 +-

     2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/recipes-kernel/linux/linux-**yocto_3.4.bbappend
    b/recipes-kernel/linux/linux-**yocto_3.4.bbappend
    index 5b163ff..918302a 100644
    --- a/recipes-kernel/linux/linux-**yocto_3.4.bbappend
    +++ b/recipes-kernel/linux/linux-**yocto_3.4.bbappend
    @@ -5,4 +5,4 @@ SRC_URI += "file://xt-checksum.scc \
                file://vswitch.scc \
                file://lxc.scc \
                "
    -
    +module_autoload_openvswitch = "openvswitch"
    diff --git a/recipes-networking/**openvswitch/openvswitch_1.4.3.**bb<http://openvswitch_1.4.3.bb>
    <http://openvswitch_1.4.3.bb>
    b/recipes-networking/**openvswitch/openvswitch_1.4.3.**bb<http://openvswitch_1.4.3.bb>
    <http://openvswitch_1.4.3.bb>

    index 88f0114..6764073 100644
    --- a/recipes-networking/**openvswitch/openvswitch_1.4.3.**bb<http://openvswitch_1.4.3.bb>
    <http://openvswitch_1.4.3.bb>
    +++ b/recipes-networking/**openvswitch/openvswitch_1.4.3.**bb<http://openvswitch_1.4.3.bb>
    <http://openvswitch_1.4.3.bb>

    @@ -7,7 +7,7 @@ LICENSE = "Apache-2"
     DEPENDS += "bridge-utils openssl python perl"

     RDEPENDS_${PN} += "util-linux-uuidgen util-linux-libuuid \
    -              python perl perl-module-strict"
    +              python perl perl-module-strict ${PN}-switch
    ${PN}-controller"
     RDEPENDS_${PN}-controller = "${PN} lsb ${PN}-pki"
     RDEPENDS_${PN}-switch = "${PN} openssl procps util-linux-uuidgen"
     RDEPENDS_${PN}-pki = "${PN}"
    --
    1.7.1

--
"Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end"

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end"