SG_SCSI_RESET ioctl should only perform requested operation
PATCH 1/1 SG_SCSI_RESET ioctl should only perform requested operation
Quoted 1 line
From all the documentation I've found, it is not clear that users of the
SG_SCSI_RESET ioctl may have their requests progress up the hierarchy of reset operations.
Basically, requests for a SCSI_TRY_RESET_DEVICE may eventually result in a TARGET, BUS, or HOST reset. The sg_reset utility hints at the error handling, but actually leads the user to believe that they should reissue the sg_reset command themselves to enact more aggressive reset functions. It also says:
"Note that a host reset and a bus reset may cause collateral damage."
In the interest of error isolation, I have attached a patch which changes the behavior. The existing behavior is obviously intentional, but I don't believe its the best choice.
There are other alternatives to this patch. For one, to avoid the possibility of breaking an existing application, maybe SG_SCSI_RESET needs some new values like "SG_SCSI_RESET_DEVICE_ONLY". While leaving the existing operations alone.
Just in case...
---
drivers/scsi/scsi_error.c +3 -9
@@ -1999,19 +1999,13 @@ scsi_reset_provider(struct scsi_device *dev, int flag)switch (flag) {case SCSI_TRY_RESET_DEVICE : rtn =scsi_try_bus_device_reset (scmd); -if (rtn ==SUCCESS ) -break ; -/* FALLTHROUGH */ +break ;case SCSI_TRY_RESET_TARGET : rtn =scsi_try_target_reset (scmd); -if (rtn ==SUCCESS ) -break ; -/* FALLTHROUGH */ +break ;case SCSI_TRY_RESET_BUS : rtn =scsi_try_bus_reset (scmd); -if (rtn ==SUCCESS ) -break ; -/* FALLTHROUGH */ +break ;case SCSI_TRY_RESET_HOST : rtn =scsi_try_host_reset (scmd);break ;
Quoted 42 lines · Jeremy Linton
Quoted 1 line
From all the documentation I've found, it is not clear that users of the
SG_SCSI_RESETioctl may have their requests progress up the hierarchy of reset operations.Basically, requests for a
SCSI_TRY_RESET_DEVICEmay eventually result in a TARGET, BUS, or HOST reset. Thesg_resetutility hints at the error handling, but actually leads the user to believe that they should reissue thesg_resetcommand themselves to enact more aggressive reset functions. It also says:
"Note that a host reset and a bus reset may cause collateral damage."In the interest of error isolation, I have attached a patch which changes the behavior. The existing behavior is obviously intentional, but I don't believe its the best choice.
There are other alternatives to this patch. For one, to avoid the possibility of breaking an existing application, maybe
SG_SCSI_RESETneeds some new values like "SG_SCSI_RESET_DEVICE_ONLY". While leaving the existing operations alone.Just in case...
Signed-off-by Jeremy Linton <[email protected]>---
drivers/scsi/scsi_error.c +2
-6@@ -1999,19 +1999,13 @@ scsi_reset_provider(struct scsi_device *dev, int flag)switch (flag) {case SCSI_TRY_RESET_DEVICE : rtn =scsi_try_bus_device_reset (scmd); -if (rtn ==SUCCESS ) -break ; -/* FALLTHROUGH */ +break ;case SCSI_TRY_RESET_TARGET : rtn =scsi_try_target_reset (scmd); -if (rtn ==SUCCESS ) -break ; -/* FALLTHROUGH */ +break ;
drivers/scsi/scsi_error.c scsi_reset_provider(struct scsi_device *dev, int flag)
Quoted 10 lines
drivers/scsi/scsi_error.c +1
-4case SCSI_TRY_RESET_BUS : rtn =scsi_try_bus_reset (scmd); -if (rtn ==SUCCESS ) -break ; -/* FALLTHROUGH */ +break ;case SCSI_TRY_RESET_HOST : rtn =scsi_try_host_reset (scmd);break ; --
Jeremy,
That is way too sensible to be approved as it will most likely break existing code that assumes the escalation property.
Perhaps some new constants could be introduced (e.g. SCSI_TRY_RESET_TARGET_ONLY) that could be passed to the SG_SCSI_RESET ioctl. And perhaps that new set of constants could more accurately reflect how such things are done in modern SCSI.
Doug Gilbert