Skip to contentSkip to conversation

quota: Add QFMT_VFS_V1 -> quota_v2 entry to INIT_QUOTA_MODULE_NAMES

PATCH In review Jeff Mahoney 2 participants 2 messages Feb 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 quota: Add QFMT_VFS_V1 -> quota_v2 entry to INIT_QUOTA_MODULE_NAMES

Commit 498c6015 (quota: Implement quota format with 64-bit space and inode limits) added the vfsv1 quota format but didn't add it to INIT_QUOTA_MODULE_NAMES.

File systems using QFMT_VFS_V1 format quotas with CONFIG_QFMT_V1=m, will fail to enable quotas with ESRCH because the module won't be loaded.

This patch adds it to the list.

---
 include/linux/quota.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/quota.h +1 -0
@@ -405,6 +405,7 @@ struct quota_module_name {
 #define INIT_QUOTA_MODULE_NAMES {\
 	{QFMT_VFS_OLD, "quota_v1"},\
 	{QFMT_VFS_V0, "quota_v2"},\
+	{QFMT_VFS_V1, "quota_v2"},\
 	{0, NULL}}
 
 #endif /* _QUOTA_ */
Signature · 2 lines
Jeff Mahoney
SUSE Labs
reviewer
#1 lore raw
Quoted 8 lines · Jeff Mahoney

Commit 498c6015 (quota: Implement quota format with 64-bit space and inode limits) added the vfsv1 quota format but didn't add it to INIT_QUOTA_MODULE_NAMES.

File systems using QFMT_VFS_V1 format quotas with CONFIG_QFMT_V1=m, will fail to enable quotas with ESRCH because the module won't be loaded.

Quoted 5 lines

This patch adds it to the list.

Thanks for the patch. Ted Tso actually found the problem few days ago as
well and is carrying the fix in his tree. So this should get fixed once the next merge window opens.

Honza

Quoted 18 lines
---
 include/linux/quota.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/quota.h +1 -0
@@ -405,6 +405,7 @@ struct quota_module_name {
 #define INIT_QUOTA_MODULE_NAMES {\
 	{QFMT_VFS_OLD, "quota_v1"},\
 	{QFMT_VFS_V0, "quota_v2"},\
+	{QFMT_VFS_V1, "quota_v2"},\
 	{0, NULL}}
 
 #endif /* _QUOTA_ */
Signature · 3 lines
-- 
Jeff Mahoney
SUSE Labs
Signature · 2 lines
Jan Kara <[email protected]>
SUSE Labs, CR