Skip to contentSkip to conversation

drivers/gpio: using common order: let 'static const' instead of 'const static'

PATCH Superseded Chen Gang 3 participants 7 messages Feb 6, 2013 – Feb 9, 2013

Subsystems (2)
lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 drivers/gpio: using common order: let 'static const' instead of 'const static'

'const static ' is not a common order, better to use 'const static' instead.

building:
make EXTRA_CFLAGS=-W ARCH=arm

drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration

---
 drivers/gpio/gpio-omap.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpio/gpio-omap.c +3 -3
index f1fbedb2..159f5c5 100644
@@ -1476,19 +1476,19 @@ static struct omap_gpio_reg_offs omap4_gpio_regs = {
 	.fallingdetect =	OMAP4_GPIO_FALLINGDETECT,
 };
 
-const static struct omap_gpio_platform_data omap2_pdata = {
+static const struct omap_gpio_platform_data omap2_pdata = {
 	.regs = &omap2_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = false,
 };
 
-const static struct omap_gpio_platform_data omap3_pdata = {
+static const struct omap_gpio_platform_data omap3_pdata = {
 	.regs = &omap2_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = true,
 };
 
-const static struct omap_gpio_platform_data omap4_pdata = {
+static const struct omap_gpio_platform_data omap4_pdata = {
 	.regs = &omap4_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = true,
Signature · 1 line
1.7.7.6
Acked-by on v1 1/1
#1 lore raw
Quoted 2 lines · Chen Gang

'const static ' is not a common order, better to use 'const static' instead.

You mean " use static const instead ", right ?

Quoted 11 lines

building:
make EXTRA_CFLAGS=-W ARCH=arm

drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration

Quoted 2 lines

---

With change log fixed,

author
#2 lore raw
Quoted 5 lines · Santosh Shilimkar
Quoted 2 lines · Chen Gang
Quoted 2 lines

'const static ' is not a common order, better to use 'const static' instead.

You mean " use static const instead ", right ?

oh, yes. it is my miswritten.

if necessary to send patch v2, please tell me.

thanks.

:-)

Signature · 7 lines
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
Quoted 11 lines · Chen Gang
Quoted 5 lines · Santosh Shilimkar
Quoted 2 lines · Chen Gang
Quoted 2 lines

'const static ' is not a common order, better to use 'const static' instead.

You mean " use static const instead ", right ?

oh, yes. it is my miswritten.

if necessary to send patch v2, please tell me.

Please do send updated version.

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

author
#4 lore raw

PATCH v2 1/1 drivers/gpio: using common order: let 'static const' instead of 'const static'

'const static ' is not a common order, better to use 'static const' instead.

building:
make EXTRA_CFLAGS=-W ARCH=arm

drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration

Cc Santosh Shilimkar <[email protected]>
---
 drivers/gpio/gpio-omap.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpio/gpio-omap.c +3 -3
index f1fbedb2..159f5c5 100644
@@ -1476,19 +1476,19 @@ static struct omap_gpio_reg_offs omap4_gpio_regs = {
 	.fallingdetect =	OMAP4_GPIO_FALLINGDETECT,
 };
 
-const static struct omap_gpio_platform_data omap2_pdata = {
+static const struct omap_gpio_platform_data omap2_pdata = {
 	.regs = &omap2_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = false,
 };
 
-const static struct omap_gpio_platform_data omap3_pdata = {
+static const struct omap_gpio_platform_data omap3_pdata = {
 	.regs = &omap2_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = true,
 };
 
-const static struct omap_gpio_platform_data omap4_pdata = {
+static const struct omap_gpio_platform_data omap4_pdata = {
 	.regs = &omap4_gpio_regs,
 	.bank_width = 32,
 	.dbck_flag = true,
Signature · 1 line
1.7.7.6
Acked-by on v2 1/1
#5 lore raw
Quoted 14 lines · Chen Gang

'const static ' is not a common order, better to use 'static const' instead.

building:
make EXTRA_CFLAGS=-W ARCH=arm

drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration

Quoted 3 lines
Cc Santosh Shilimkar <[email protected]>

---

Thanks for update.

Applied
#6 lore raw
Quoted 15 lines · Santosh Shilimkar
Quoted 14 lines · Chen Gang

'const static ' is not a common order, better to use 'static const' instead.

building:
make EXTRA_CFLAGS=-W ARCH=arm

drivers/gpio/gpio-omap.c:1479:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1485:
warning: 'static' is not at beginning of declaration
drivers/gpio/gpio-omap.c:1491:
warning: 'static' is not at beginning of declaration

Quoted 5 lines
Quoted 3 lines
Cc Santosh Shilimkar <[email protected]>

---

Thanks for update.

Applied, thanks.

g.