Skip to contentSkip to conversation

Ext2: mark inode dirty after the function dquot_free_block_nodirty is called

PATCH In review Wang Shilong 1 participant 1 message Feb 6, 2013 ext2 file system

lore
Share & tools
lore
#0 lore raw

PATCH 2/3 Ext2: mark inode dirty after the function dquot_free_block_nodirty is called

From: Wang Shilong <[email protected]>

We should mark inode dirty after the function dquot_free_block_nodirty is called.Besides,add a check whether it is necessary to call dquot_free_block_nodirty functon.

---
fs/ext2/balloc.c | 15 ++++++++++-----
fs/ext2/xattr.c | 1 +

2 files changed, 11 insertions(+), 5 deletions(-)
fs/ext2/balloc.c +0 -0
index 22993a0..9d372bf 100644
@@ -568,8 +568,11 @@ do_more:

}
error_return:
brelse(bitmap_bh);
- release_blocks(sb, freed);
- dquot_free_block_nodirty(inode, freed);
+ if (freed) {
+ release_blocks(sb, freed);
+ dquot_free_block_nodirty(inode, freed);
+ mark_inode_dirty(inode);
+ }
}

/**
@@ -1412,9 +1415,11 @@ allocated:

*errp = 0;
brelse(bitmap_bh);
- dquot_free_block_nodirty(inode, *count-num);
- mark_inode_dirty(inode);
- *count = num;
+ if (num < *count) {
+ dquot_free_block_nodirty(inode, *count-num);
+ mark_inode_dirty(inode);
+ *count = num;
+ }
return ret_block;

io_error:

fs/ext2/xattr.c +0 -0
index b6754db..4c4cda9 100644
@@ -795,6 +795,7 @@ ext2_xattr_delete_inode(struct inode *inode)

if (IS_SYNC(inode))
sync_dirty_buffer(bh);
dquot_free_block_nodirty(inode, 1);
+ mark_inode_dirty(inode);
}
EXT2_I(inode)->i_file_acl = 0;

Signature · 1 line
1.7.11.7