Skip to contentSkip to conversation

configs/{ea3250, fdi3250, phy3250}: lock down kernel headers version

PATCH New Gustavo Zacarias 3 participants 4 messages Feb 6, 2013 – Feb 7, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 configs/{ea3250, fdi3250, phy3250}: lock down kernel headers version

Update {ea3250,fdi3250,phy3250}_defconfig to lock down kernel headers to an appropiate version.
Otherwise the target is building with, at the moment of this writing, version 3.7 headers and a 2.6.34 kernel which usually isn't wise.

---
 configs/ea3250_defconfig  | 4 ++++
 configs/fdi3250_defconfig | 4 ++++
 configs/phy3250_defconfig | 4 ++++
 3 files changed, 12 insertions(+)
configs/ea3250_defconfig +4 -0
index 9cd7b34..2574dde 100644
@@ -11,6 +11,10 @@ BR2_ARM_EABI=y
 # that will compile a kernel with ethernet working correctly
 BR2_GCC_VERSION_4_3_X=y
 
+# Lock down headers to avoid breaking with new defaults
+BR2_KERNEL_HEADERS_VERSION=y
+BR2_DEFAULT_KERNEL_VERSION="2.6.34.7"
+BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7"
 
 #
 # Host utilities
configs/fdi3250_defconfig +4 -0
index 1fd0b05..b1c6684 100644
@@ -11,6 +11,10 @@ BR2_ARM_EABI=y
 # that will compile a kernel with ethernet working correctly
 BR2_GCC_VERSION_4_3_X=y
 
+# Lock down headers to avoid breaking with new defaults
+BR2_KERNEL_HEADERS_VERSION=y
+BR2_DEFAULT_KERNEL_VERSION="2.6.34.7"
+BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7"
 
 #
 # Host utilities
configs/phy3250_defconfig +4 -0
index bc17d5c..e95546f 100644
@@ -11,6 +11,10 @@ BR2_ARM_EABI=y
 # that will compile a kernel with ethernet working correctly
 BR2_GCC_VERSION_4_3_X=y
 
+# Lock down headers to avoid breaking with new defaults
+BR2_KERNEL_HEADERS_VERSION=y
+BR2_DEFAULT_KERNEL_VERSION="2.6.34.7"
+BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7"
 
 #
 # Host utilities
Signature · 1 line
1.7.12.4
#1 lore raw

PATCH 1/1 configs/{ea3250, fdi3250, phy3250}: lock down kernel headers version

Quoted 4 lines · Gustavo Zacarias

Update {ea3250,fdi3250,phy3250}_defconfig to lock down kernel headers to an appropiate version.
Otherwise the target is building with, at the moment of this writing, version 3.7 headers and a 2.6.34 kernel which usually isn't wise.

This should really be done for all defconfigs that build a custom
kernel version:

arm_foundationv8_defconfig
armadeus_apf9328_defconfig
at91sam9g20dfc_defconfig
atstk100x_defconfig
beaglebone_defconfig
calao_snowball_defconfig
kb9202_defconfig
mini2440_defconfig
mx53loco_defconfig
sheevaplug_defconfig

And the ones that allow it should probably set
BR2_LINUX_KERNEL_SAME_AS_HEADERS.

But all that is a lot of testing :-)

Quoted 13 lines
---
  configs/ea3250_defconfig  | 4 ++++
  configs/fdi3250_defconfig | 4 ++++
  configs/phy3250_defconfig | 4 ++++
  3 files changed, 12 insertions(+)
configs/ea3250_defconfig +0 -0
index 9cd7b34..2574dde 100644

configs/ea3250_defconfig BR2_ARM_EABI=y · line 17

Quoted 7 lines
configs/ea3250_defconfig +4 -0
@@ -11,6 +11,10 @@ BR2_ARM_EABI=y
  # that will compile a kernel with ethernet working correctly
  BR2_GCC_VERSION_4_3_X=y
 
+# Lock down headers to avoid breaking with new defaults
+BR2_KERNEL_HEADERS_VERSION=y
+BR2_DEFAULT_KERNEL_VERSION="2.6.34.7"
+BR2_DEFAULT_KERNEL_HEADERS="2.6.34.7"

Only BR2_DEFAULT_KERNEL_VERSION is necessary -
BR2_DEFAULT_KERNEL_HEADERS is derived from it by Kconfig.

Regards,
Arnout

Signature · 6 lines
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 configs/{ea3250, fdi3250, phy3250}: lock down kernel headers version

Quoted 14 lines · Arnout Vandecappelle

This should really be done for all defconfigs that build a custom
kernel version:

arm_foundationv8_defconfig
armadeus_apf9328_defconfig
at91sam9g20dfc_defconfig
atstk100x_defconfig
beaglebone_defconfig
calao_snowball_defconfig
kb9202_defconfig
mini2440_defconfig
mx53loco_defconfig
sheevaplug_defconfig

Quoted 4 lines

And the ones that allow it should probably set
BR2_LINUX_KERNEL_SAME_AS_HEADERS.

But all that is a lot of testing :-)

Yes, i'm sending as i'm testing :)
I'll also be switching these ones (*3250*) configs to git tags/releases != master because there's a filename clash possibility there. Not at the moment though since those use the same upstream and no other BSP config does that, but it could happen.

Quoted 2 lines

Only BR2_DEFAULT_KERNEL_VERSION is necessary -
BR2_DEFAULT_KERNEL_HEADERS is derived from it by Kconfig.

Cool, i'll minimize them then.
Regards.

#3 lore raw

PATCH 1/1 configs/{ea3250, fdi3250, phy3250}: lock down kernel headers version

In reply to Gustavo Zacarias
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Gustavo" == Gustavo Zacarias <[email protected]> writes:

Gustavo> Update {ea3250,fdi3250,phy3250}_defconfig to lock down kernel headers to Gustavo> an appropiate version.
Gustavo> Otherwise the target is building with, at the moment of this writing, Gustavo> version 3.7 headers and a 2.6.34 kernel which usually isn't wise.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard