arch/arm: fix-up the ARM Kconfig warning
PATCH 1/1 arch/arm: fix-up the ARM Kconfig warning
Kconfig does not accepts that a symbol that is part of a choice be affected a default value.
Fix this by introducing a dummy EABI symbol., and nake the real EABI symbol a prompt-less option that depends on !OABI.
--- arch/Config.in.arm | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
arch/Config.in.arm +4 -3
@@ -76,7 +76,7 @@ choice Note: Using OABI is discouraged. -config BR2_ARM_EABI +config BR2_ARM_EABI_DUMMY bool "EABI" config BR2_ARM_OABI bool "OABI"
@@ -84,8 +84,9 @@ config BR2_ARM_OABI endchoice config BR2_ARM_EABI - default y - depends on !BR2_DEPRECATED + def_bool y + depends on BR2_arm || BR2_armeb + depends on !BR2_ARM_OABI config BR2_ARM_ENABLE_NEON bool "Enable NEON SIMD extension support"
Signature · 1 line
1.7.2.5
PATCH 1/1 arch/arm: fix-up the ARM Kconfig warning
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Yann" == Yann E MORIN <[email protected]> writes:
Yann> Kconfig does not accepts that a symbol that is part of a choice Yann> be affected a default value.
Yann> Fix this by introducing a dummy EABI symbol., and nake the real Yann> EABI symbol a prompt-less option that depends on !OABI.
Thanks, committed with small fixups (s/nake/make and below).
Yann> Signed-off-by: "Yann E. MORIN" <[email protected]> Yann> Cc: Peter Korsgaard <[email protected]>
Yann> Cc: Arnout Vandecappelle <[email protected]> Yann> ---
Yann> arch/Config.in.arm | 7 ++++---
Yann> 1 files changed, 4 insertions(+), 3 deletions(-)
Yann> diff --git a/arch/Config.in.arm b/arch/Config.in.arm Yann> index 37152c0..ecb45ab 100644
Yann> --- a/arch/Config.in.arm
Yann> +++ b/arch/Config.in.arm
Yann> @@ -76,7 +76,7 @@ choice
Yann> Note:
Yann> Using OABI is discouraged.
Yann> -config BR2_ARM_EABI
Yann> +config BR2_ARM_EABI_DUMMY
I renamed this to BR2_ARM_EABI_CHOICE
Yann> bool "EABI" Yann> config BR2_ARM_OABI Yann> bool "OABI"
Yann> @@ -84,8 +84,9 @@ config BR2_ARM_OABI
Yann> endchoice
Yann> config BR2_ARM_EABI
Yann> - default y
Yann> - depends on !BR2_DEPRECATED
Yann> + def_bool y
Yann> + depends on BR2_arm || BR2_armeb
The entire file is only sourced for arm || armeb, so this can be dropped.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 1/1 arch/arm: fix-up the ARM Kconfig warning
In reply to Yann E. MORINQuoted 2 lines · Yann E. MORIN
Kconfigdoes not accepts that a symbol that is part of a choice be affected a default value.
Weird, I thought I tested this...
Regards,
Arnout
Signature · 6 lines
Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F