rbd: add parentheses to object request iterator macros
Subsystems (2)
PATCH 1/1 rbd: add parentheses to object request iterator macros
The for_each_obj_request*() macros should parenthesize their uses of the ireq parameter.
Signed-off-by Alex Elder <[email protected]>
--- drivers/block/rbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/block/rbd.c +3 -3
@@ -226,11 +226,11 @@ struct rbd_img_request { };#define for_each_obj_request (ireq, oreq) \ - list_for_each_entry(oreq, &ireq->obj_requests, links) + list_for_each_entry(oreq, &(ireq)->obj_requests, links)#define for_each_obj_request_from (ireq, oreq) \ - list_for_each_entry_from(oreq, &ireq->obj_requests, links) + list_for_each_entry_from(oreq, &(ireq)->obj_requests, links)#define for_each_obj_request_safe (ireq, oreq, n) \ - list_for_each_entry_safe_reverse(oreq, n, &ireq->obj_requests, links) + list_for_each_entry_safe_reverse(oreq, n, &(ireq)->obj_requests, links)struct rbd_snap {struct device dev;
Signature · 1 line
1.7.9.5
Reviewed-by Josh Durgin <[email protected]>
Quoted 28 lines · Alex Elder
The for_each_obj_request*() macros should parenthesize their uses of the ireq parameter.
Signed-off-by Alex Elder <[email protected]>--- drivers/block/rbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/block/rbd.c +3
-3@@ -226,11 +226,11 @@ struct rbd_img_request { };#define for_each_obj_request (ireq, oreq) \ - list_for_each_entry(oreq, &ireq->obj_requests, links) + list_for_each_entry(oreq, &(ireq)->obj_requests, links)#define for_each_obj_request_from (ireq, oreq) \ - list_for_each_entry_from(oreq, &ireq->obj_requests, links) + list_for_each_entry_from(oreq, &(ireq)->obj_requests, links)#define for_each_obj_request_safe (ireq, oreq, n) \ - list_for_each_entry_safe_reverse(oreq, n, &ireq->obj_requests, links) + list_for_each_entry_safe_reverse(oreq, n, &(ireq)->obj_requests, links)struct rbd_snap {struct device dev;