rt-tests: make rpm fails if numactl-devel is missing

Hi all,

I'm not sure what the best solution for this is. Or if it is even worth fixing. So just reporting for the archives...

rt-tests can be built without NUMA:

make NUMA=0

But "make rpm" does not have a way to be successful without NUMA:

build_rt-tests_0.85> make rpm
for F in cyclictest signaltest pi_stress rt-migrate-test ptsematest sigwaittest svsematest pmqtest sendme pip_stress hackbench *.o .depend *.*~ *.orig *.rej rt-tests.spec *.d *.a ChangeLog; do find -type f -name $F | xargs rm -f; done rm -f hwlatdetect
rm -f tags
rm -rf BUILD BUILDROOT RPMS SRPMS SPECS releases *.tar.gz rt-tests.spec tmp
git log >ChangeLog
mkdir -p releases
mkdir -p tmp/rt-tests
cp -r Makefile COPYING ChangeLog src tmp/rt-tests
tar -C tmp -czf rt-tests-0.85.tar.gz rt-tests
rm -f ChangeLog
cp rt-tests-0.85.tar.gz releases
sed s/__VERSION__/0.85/ <rt-tests.spec-in >rt-tests.spec
rpmbuild -ba --define "_topdir /a/home/frowand/me/src/rt-tests/build_rt-tests_0.85" --define "_sourcedir /a/home/frowand/me/src/rt-tests/build_rt-tests_0.85/releases" --define "_builddir /a/home/frowand/me/src/rt-tests/build_rt-tests_0.85/BUILD" rt-tests.spec
error: Failed build dependencies:

	numactl-devel is needed by rt-tests-0.85-1.fc12.src

make: *** [rpm] Error 1

-Frank

I ran into this in the past with OBS on Suse.

There was a tertiary issue, because some distros use i386 and others use i586 or i686.

E.g.

[sven@www rt-tests]$ gcc -dumpmachine
i586-suse-linux

index 3a82407..7bb022c 100644
@@ -16,7 +16,7 @@ srcdir        ?= $(prefix)/src
 
 machinetype = $(shell $(CC) -dumpmachine | \
     sed -e 's/-.*//' -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/')
-ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),)
+ifneq ($(filter x86_64 i586 ia64 mips powerpc,$(machinetype)),)
 NUMA   := 1
 endif
 

So all in all, this feature probably only works on some, and maybe needs to be worked around more often than not.

Sven

OK, that prodded me enough to create an ugly patch, which will be following in another email.

-Frank