Python 3, simple, external package support
PATCH 1/1 Python 3, simple, external package support
This patch series refactor python support in buildroot to enable the use of from line 'This patch series refactor python support in buildroot to enable the use of external package with both python2 and python3. The packages python-bottle and python-serial have adapted as examples.
To support others external package more work is needed as they are based on python setuptools. It's no more supported by python3 and should be replaced by "Distribute". This should be done in another patch series.
PATCH 1/5 In order to have a better support for python external package make the python menu clearer. Python2 and Python3 are now mutually exclusive
--- package/Config.in | 19 +------------ package/python-generic/Config.in | 56 ++++++++++++++++++++++++++++++++++++++ package/python/Config.in | 14 ---------- package/python3/Config.in | 14 ---------- 4 files changed, 57 insertions(+), 46 deletions(-) create mode 100644 package/python-generic/Config.in
package/Config.in +1 -18
@@ -315,24 +315,7 @@ endmenu endif source "package/microperl/Config.in" source "package/php/Config.in" -source "package/python/Config.in" -source "package/python3/Config.in" -if BR2_PACKAGE_PYTHON -menu "external python modules" -source "package/python-bottle/Config.in" -source "package/python-dpkt/Config.in" -source "package/python-id3/Config.in" -source "package/python-mad/Config.in" -source "package/python-meld3/Config.in" -source "package/python-netifaces/Config.in" -source "package/python-nfc/Config.in" -source "package/python-protobuf/Config.in" -source "package/python-pygame/Config.in" -source "package/python-pyparsing/Config.in" -source "package/python-serial/Config.in" -source "package/python-setuptools/Config.in" -endmenu -endif +source "package/python-generic/Config.in" source "package/ruby/Config.in" source "package/tcl/Config.in" if BR2_PACKAGE_TCL
package/python-generic/Config.in new file +56 -0
56 lines not on this page · raw message
package/python/Config.in +0 -14
@@ -1,17 +1,3 @@ -config BR2_PACKAGE_PYTHON - bool "python" - depends on BR2_USE_WCHAR - # uses fork() - depends on BR2_USE_MMU - select BR2_PACKAGE_LIBFFI - help - The python language interpreter. - - http://www.python.org/ - -comment "python requires a toolchain with WCHAR support" - depends on !BR2_USE_WCHAR - if BR2_PACKAGE_PYTHON choice
package/python3/Config.in +0 -14
@@ -1,17 +1,3 @@ -config BR2_PACKAGE_PYTHON3 - bool "python3" - depends on BR2_USE_WCHAR - # uses fork() - depends on BR2_USE_MMU - select BR2_PACKAGE_LIBFFI - help - The python language interpreter. - - http://www.python.org/ - -comment "python3 requires a toolchain with WCHAR support" - depends on !BR2_USE_WCHAR - if BR2_PACKAGE_PYTHON3 choice
Signature · 1 line
1.7.10.4
PATCH 1/5 In order to have a better support for python external package make the python menu clearer. Python2 and Python3 are now mutually exclusive
Dear Patrick Gerber,
Quoted 9 lines · Patrick Gerber
Signed-off-by Patrick Gerber <[email protected]>--- package/Config.in | 19 +------------ package/python-generic/Config.in | 56 ++++++++++++++++++++++++++++++++++++++ package/python/Config.in | 14 ---------- package/python3/Config.in | 14 ---------- 4 files changed, 57 insertions(+), 46 deletions(-) create mode 100644 package/python-generic/Config.in
This seems really complicated. Can't we just have a depends on !BR2_PACKAGE_PYTHON in the python3 package, and a depends on !BR2_PACKAGE_PYTHON3 in the python package?
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/5 In order to have a better support for python external package make the python menu clearer. Python2 and Python3 are now mutually exclusive
Quoted 13 lines · Thomas Petazzoni
Dear Patrick Gerber,
Quoted 9 lines · Patrick Gerber
Signed-off-by Patrick Gerber <[email protected]>--- package/Config.in | 19 +------------ package/python-generic/Config.in | 56 ++++++++++++++++++++++++++++++++++++++ package/python/Config.in | 14 ---------- package/python3/Config.in | 14 ---------- 4 files changed, 57 insertions(+), 46 deletions(-)create mode 100644 package/python-generic/Config.in
Quoted 6 lines
This seems really complicated. Can't we just have a depends on !BR2_PACKAGE_PYTHON in the python3 package, and a depends on !BR2_PACKAGE_PYTHON3 in the python package?
Thomas
Hi Thomas,
This is not so complicated, I have only moved some lines from package/Config.in, package/python/Config.in and package/python3/Config.in to package/python-generic/Config.in and added few lines to handle the "choice" menu.
I have tried as you suggest but it have some strange behaviour...
If you care about the python-generic directory we need it also to add some "common" stuff to handle properly the support of both python's version by the external packages.
Patrick
PATCH 2/5 When using python3 a symlink "python" is added in staging and point to python3. This is needed to call python setup for external package. A second simlink is added to alias the config-3.3m directory to config
In reply to Patrick Gerber--- package/python3/python3.mk | 8 ++++++++ 1 file changed, 8 insertions(+)
package/python3/python3.mk +8 -0
@@ -160,6 +160,14 @@ ifneq ($(BR2_PACKAGE_PYTHON),y) PYTHON3_POST_INSTALL_TARGET_HOOKS += PYTHON3_INSTALL_SYMLINK endif +define HOST_PYTHON3_INSTALL_SYMLINK + ln -fs python3 $(HOST_DIR)/usr/bin/python + ln -fs config-3.3m $(HOST_DIR)/usr/lib/python3.3/config +endef + +HOST_PYTHON3_POST_INSTALL_HOOKS += HOST_PYTHON3_INSTALL_SYMLINK + + ifeq ($(BR2_PACKAGE_PYTHON3_PY_ONLY),y) define PYTHON3_REMOVE_MODULES_FILES for i in `find $(TARGET_DIR)/usr/lib/python$(PYTHON3_VERSION_MAJOR) \
Signature · 1 line
1.7.10.4
PATCH 2/5 When using python3 a symlink "python" is added in staging and point to python3. This is needed to call python setup for external package. A second simlink is added to alias the config-3.3m directory to config
Dear Patrick Gerber,
Please fix your git commit log. The first line of a git commit log becomes the title of the e-mails, so it should have a length no longer than 80-100 characters. After this first line, leave an empty new line, and add more details for your commit log.
Quoted 11 lines · Patrick Gerber
Signed-off-by Patrick Gerber <[email protected]>--- package/python3/python3.mk | 8 ++++++++ 1 file changed, 8 insertions(+)package/python3/python3.mk +0
-0
package/python3/python3.mk ifneq ($(BR2_PACKAGE_PYTHON),y) · line 168
Quoted 9 lines
package/python3/python3.mk +6
-0@@ -160,6 +160,14 @@ ifneq ($(BR2_PACKAGE_PYTHON),y) PYTHON3_POST_INSTALL_TARGET_HOOKS += PYTHON3_INSTALL_SYMLINK endif +define HOST_PYTHON3_INSTALL_SYMLINK + ln -fs python3 $(HOST_DIR)/usr/bin/python + ln -fs config-3.3m $(HOST_DIR)/usr/lib/python3.3/config +endef + +HOST_PYTHON3_POST_INSTALL_HOOKS += HOST_PYTHON3_INSTALL_SYMLINK
As Samuel pointed it out, this unfortunately may break a number of things in Buildroot. They are packages that depend on host-python, and would only be capable of using an Python 2.x host-python.
Or at least, I would like to have the confirmation that all packages that depend on host-python continue to build normally when host-python is Python 3.
That said, some packages are not really clear about this. For example, Scons uses the Python provided with the distribution, and not the host-python built by Buildroot.
As you can see, this is not a trivial topic.
Best regards,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 3/5 Define a new variable called PYTHON_GENERIC_DEPENDENCIES either to "python" or "python3" depending of the selected Python version. This is needed to easily set dependencies for packages that could be used either with Python 2 or Python 3.
In reply to Patrick Gerber--- package/python-generic/python-generic.mk | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) create mode 100644 package/python-generic/python-generic.mk
package/python-generic/python-generic.mk new file +16 -0
@@ -0,0 +1,16 @@ +############################################################# +# +# python-generic +# +############################################################# +# PYTHON_GENERIC_DEPENDENCIES is defined to the selected python +# version. + +ifeq ($(BR2_PACKAGE_PYTHON),y) + PYTHON_GENERIC_DEPENDENCIES = python +endif + +ifeq ($(BR2_PACKAGE_PYTHON3),y) + PYTHON_GENERIC_DEPENDENCIES = python3 +endif +
Signature · 1 line
1.7.10.4
PATCH 4/5 python-bottle: Convert package to be used with python2 or python3
In reply to Patrick Gerber--- package/python-bottle/Config.in | 1 + package/python-bottle/python-bottle.mk | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
package/python-bottle/Config.in +1 -0
@@ -1,5 +1,6 @@ config BR2_PACKAGE_PYTHON_BOTTLE bool "python-bottle" + depends on (BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3) help Bottle is a fast, simple and lightweight WSGI micro web-framework for Python. It is distributed as a single file module and has no
package/python-bottle/python-bottle.mk +1 -1
@@ -7,7 +7,7 @@ PYTHON_BOTTLE_VERSION = 0.11.4 PYTHON_BOTTLE_SOURCE = bottle-$(PYTHON_BOTTLE_VERSION).tar.gz PYTHON_BOTTLE_SITE = http://pypi.python.org/packages/source/b/bottle -PYTHON_BOTTLE_DEPENDENCIES = python +PYTHON_BOTTLE_DEPENDENCIES = $(PYTHON_GENERIC_DEPENDENCIES) PYTHON_BOTTLE_LICENSE = MIT # README.rst refers to the file "LICENSE" but it's not included
Signature · 1 line
1.7.10.4
PATCH 5/5 python-serial: Convert package to be used with python2 or python3
In reply to Patrick Gerber--- package/python-serial/Config.in | 2 +- package/python-serial/python-serial.mk | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
package/python-serial/Config.in +1 -1
@@ -1,6 +1,6 @@ config BR2_PACKAGE_PYTHON_SERIAL bool "python-serial" - depends on BR2_PACKAGE_PYTHON + depends on (BR2_PACKAGE_PYTHON || BR2_PACKAGE_PYTHON3) help python-serial is a Python library to access serial ports.
package/python-serial/python-serial.mk +1 -1
@@ -8,7 +8,7 @@ PYTHON_SERIAL_VERSION = 2.6 PYTHON_SERIAL_SOURCE = pyserial-$(PYTHON_SERIAL_VERSION).tar.gz PYTHON_SERIAL_SITE = http://pypi.python.org/packages/source/p/pyserial/ -PYTHON_SERIAL_DEPENDENCIES = python +PYTHON_SERIAL_DEPENDENCIES = $(PYTHON_GENERIC_DEPENDENCIES) define PYTHON_SERIAL_BUILD_CMDS (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build)
Signature · 1 line
1.7.10.4